All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Mailhol <vincent.mailhol@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Max Staudt <max@enpas.org>,
	Wolfgang Grandegger <wg@grandegger.com>,
	linux-can@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Oliver Neukum <oneukum@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters
Date: Fri, 13 May 2022 21:14:53 +0900	[thread overview]
Message-ID: <CAMZ6RqLZXyiW0CZg0spocXie+2-cnyS0Ai_9qTA6UiEHdH99bA@mail.gmail.com> (raw)
In-Reply-To: <20220513115223.b56etkaejphldjok@pengutronix.de>

On Fri 13 May 2022 at 20:52, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 13.05.2022 11:38:31, Vincent Mailhol wrote:
> > > +
> > > +       /* We shouldn't get here after a hardware fault:
> > > +        * can_bus_off() calls netif_carrier_off()
> > > +        */
> > > +       WARN_ON_ONCE(elm->uart_side_failure);
> > > +
> > > +       if (!elm->tty ||
> > > +           elm->uart_side_failure ||
> > > +           elm->can.ctrlmode & CAN_CTRLMODE_LISTENONLY) {
> >
> > Can the xmit function get called when CAN_CTRLMODE_LISTENONLY is on?
>
> I think yes. You can skip the whole CAN stack by injecting CAN frames in
> the kernel via the packet socket. Maybe we should add a check to
> can_dropped_invalid_skb().

Ack. Most of the drivers do not check for it (my doesn't). So better
to put it in can_dropped_invalid_skb().
I can do the patch for this.

And also noted for your previous comment on lockdep_assert_held().
@Max: please ignore this particular remark.

  reply	other threads:[~2022-05-13 12:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12 18:29 [PATCH v6] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters Max Staudt
2022-05-13  2:38 ` Vincent Mailhol
2022-05-13  6:31   ` Vincent Mailhol
2022-05-13 18:59     ` Max Staudt
2022-05-14  3:14       ` Vincent Mailhol
2022-05-14 11:11         ` Max Staudt
2022-05-14 12:24           ` Vincent Mailhol
2022-05-13 11:46   ` Marc Kleine-Budde
2022-05-13 11:52   ` Marc Kleine-Budde
2022-05-13 12:14     ` Vincent Mailhol [this message]
2022-05-14 11:04   ` Max Staudt
2022-05-14 12:10     ` Vincent Mailhol
2022-05-18 16:24 ` Vincent Mailhol
2022-05-18 16:31   ` Vincent Mailhol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMZ6RqLZXyiW0CZg0spocXie+2-cnyS0Ai_9qTA6UiEHdH99bA@mail.gmail.com \
    --to=vincent.mailhol@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max@enpas.org \
    --cc=mkl@pengutronix.de \
    --cc=oneukum@suse.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.