From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA2CC433EF for ; Mon, 20 Dec 2021 10:01:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbhLTKBE (ORCPT ); Mon, 20 Dec 2021 05:01:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230251AbhLTKBE (ORCPT ); Mon, 20 Dec 2021 05:01:04 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 306DDC061574 for ; Mon, 20 Dec 2021 02:01:04 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id iy13so3394410pjb.5 for ; Mon, 20 Dec 2021 02:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=glxIKfznhcNipnrkJByGI9s+AUxnZnIKmybM9HizRSA=; b=ZpDSg3GGMyKyLyKij38c9MVzCBq1litNCaAtMAZGrCtCncGp9k9Hndc8mept5FMffg erWQMOMVd6mw7WmyDMRK6T6pUWxfRjXBLyNjuCpCwItEwvI2yFCPOVAPLJbZ/MrCoysU 5RBJImkszLmpykN5ayQT1eX1V2mdAIfq9eMy8KsxEkXtG+mkf+Jmpmkr7Y1BAC9gSudM Iptl+nm/wkfbWAi0oJL29SkgpY+Hn5LEdS0t/LTXhzUzEDmV2sZaZXf3VTUp/Q/MIuBh HhN5baKfZK199yw1GSt0wbCC/BMfZbxvTKQnWogtlRDNoWVhVBYL5NX13G2yXMq5AdNY fuyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=glxIKfznhcNipnrkJByGI9s+AUxnZnIKmybM9HizRSA=; b=fwEfe+bWbKnW/s8wIuM1k+h/EnLPEkhymEy2gmEwTOKX0J+Su837NmoM0kh/4VXg+8 i/ZklE0TIU7k6NPX9KxLb20hfDxMkBy8rNI6N6tsBUQ5XbVuWbMJOgJDTaIZ0kbY5fyN fP3h6a2Tsa04kxahV+ATzoN6PeCpoZkTQiqDVUR7lY184iQ3bUqAsCh70hzdE4yf7NLo X+bz7tFbcxTYa3HfjkuNY0z5gvDFgbITi9q1ZI3A/C7ka+rhjfUC8oEanfEb1VK3NkVE lATnEV4MzjJ70wQviSOTXyy1lQ3+4YruZKebl44MJ5d8S/BqfJ2QOqp/I6c9X0NJG8uw S5xg== X-Gm-Message-State: AOAM531FJwz4/CEj4+k06nM5AvAeSEP9NwNt1EZkRsljFj1Vh4DmcB2l wpMe63Q6pntHw1Pu/Gy3002ebwgs1Z6VWQsQfDl1vA== X-Google-Smtp-Source: ABdhPJzT9dyHPL0f54cBqBFCr6WK2GpNgLSPMaBRAJ5GmbHyUhVZsqzeC+78Izoq8hsEYBMZvxe/ishN3wqS0tBbh7c= X-Received: by 2002:a17:902:760e:b0:148:f6af:f2c8 with SMTP id k14-20020a170902760e00b00148f6aff2c8mr9280960pll.95.1639994463118; Mon, 20 Dec 2021 02:01:03 -0800 (PST) MIME-Version: 1.0 References: <20210901084732.943248-1-ardb@kernel.org> <5bdf0bb1-150b-6b60-6f9d-86542b4d7695@linaro.org> In-Reply-To: <5bdf0bb1-150b-6b60-6f9d-86542b4d7695@linaro.org> From: Loic Poulain Date: Mon, 20 Dec 2021 11:12:32 +0100 Message-ID: Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Avoid stack buffer for IRQ name To: Andy Gross , Bjorn Andersson , Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, Thara Gopinath , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org > On 9/1/21 4:47 AM, Ard Biesheuvel wrote: > > Registering an IRQ requires the string buffer containing the name to > > remain allocated, as the name is not copied into another buffer. > > > > So let's add a irq_name field to the data struct instead, which is > > guaranteed to have the appropriate lifetime. > > > > Cc: Thara Gopinath > > Cc: Bjorn Andersson > > Cc: Andy Gross > > Cc: linux-arm-msm@vger.kernel.org > > Signed-off-by: Ard Biesheuvel > > Thanks for the fix. > > Reviewed-by: Thara Gopinath Seems this patch has been overlooked. Would it be possible to resubmit it with a 'Fixes' tag? Regards, Loic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3D56C433F5 for ; Mon, 20 Dec 2021 10:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eRC4WNnsqaK1+omzOzQbF5FEwPi+lTsU3qt2aI4T4Hk=; b=qpzeoxenVOPI+g aoW3D2ZblqQnIVXf8RfJjUvVHy0aP7BLv8uIVqZEKIjpILobC0vomKfQrB5BVDYCgwUmN58xyPB2Q lvzQa2IkF9kM+PnPQ0VRc8/9flq4BFGDgDlTHz1vrjhCqBfW7WsmyrzB07oHQmfnBxCnOCJSzhlus S6n6FRO4H5I+y4tdoEuYeyamb+5nYxO/G42g8OiCbw+0+AJ0zaYsBBHpfg/hT6FADNSL5NnV5MGpZ EIfvBcRziOZJpFLtw0oegovz3wHko3tKk0pBZJpx/0410uVaCeK+djLssJ4CJxY6kGy2srsP6Sq0y lfzAQwPXSjV7Tk3MOOSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzFTh-001YPk-Ln; Mon, 20 Dec 2021 10:01:09 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzFTd-001YOR-NR for linux-arm-kernel@lists.infradead.org; Mon, 20 Dec 2021 10:01:07 +0000 Received: by mail-pl1-x636.google.com with SMTP id v19so7674396plo.7 for ; Mon, 20 Dec 2021 02:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=glxIKfznhcNipnrkJByGI9s+AUxnZnIKmybM9HizRSA=; b=ZpDSg3GGMyKyLyKij38c9MVzCBq1litNCaAtMAZGrCtCncGp9k9Hndc8mept5FMffg erWQMOMVd6mw7WmyDMRK6T6pUWxfRjXBLyNjuCpCwItEwvI2yFCPOVAPLJbZ/MrCoysU 5RBJImkszLmpykN5ayQT1eX1V2mdAIfq9eMy8KsxEkXtG+mkf+Jmpmkr7Y1BAC9gSudM Iptl+nm/wkfbWAi0oJL29SkgpY+Hn5LEdS0t/LTXhzUzEDmV2sZaZXf3VTUp/Q/MIuBh HhN5baKfZK199yw1GSt0wbCC/BMfZbxvTKQnWogtlRDNoWVhVBYL5NX13G2yXMq5AdNY fuyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=glxIKfznhcNipnrkJByGI9s+AUxnZnIKmybM9HizRSA=; b=tUDJPRc6TOUSFVa4NsR3lqGVD0Jc0X5/qJhI6bIQo8r8hRi0diveGj+bc0chqMFEjV qewuCnEYLCGMnkhvzWDbGQDlRZ1zie96Y6obnDpyrS3z8TkbIdtlyh8cmDDjJ9IdJ58h tom6aRXzWgEKIsPNlCCVoWXdKVdmpIUAJzVoD73y0cyR6YMXIMjmE0kv3XEGnDqCO/U4 LCcY3K7RwU+mHpPze+FJ9Rmu03yMi5ExFQ2xtibT6Q2xxmXksB7XPEvqej2pQkBNbS3J TNvIhKHXI0wXLFIBZV+YLFVqvc0K8uFF0a+Pqk4wbBjlWitu6EfRG5G+fnN+CIjACXVY P5Cw== X-Gm-Message-State: AOAM530gA6d1XOkNtwipowP741dCKtNcMLtqOKKpCQ4uGmGXxVcnS7gt W1D27Bcc2fqa+c1RzrDCdnbGDoUGyTFhhAVrdbua/w== X-Google-Smtp-Source: ABdhPJzT9dyHPL0f54cBqBFCr6WK2GpNgLSPMaBRAJ5GmbHyUhVZsqzeC+78Izoq8hsEYBMZvxe/ishN3wqS0tBbh7c= X-Received: by 2002:a17:902:760e:b0:148:f6af:f2c8 with SMTP id k14-20020a170902760e00b00148f6aff2c8mr9280960pll.95.1639994463118; Mon, 20 Dec 2021 02:01:03 -0800 (PST) MIME-Version: 1.0 References: <20210901084732.943248-1-ardb@kernel.org> <5bdf0bb1-150b-6b60-6f9d-86542b4d7695@linaro.org> In-Reply-To: <5bdf0bb1-150b-6b60-6f9d-86542b4d7695@linaro.org> From: Loic Poulain Date: Mon, 20 Dec 2021 11:12:32 +0100 Message-ID: Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Avoid stack buffer for IRQ name To: Andy Gross , Bjorn Andersson , Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, Thara Gopinath , linux-arm-msm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211220_020105_852173_61C3B17D X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On 9/1/21 4:47 AM, Ard Biesheuvel wrote: > > Registering an IRQ requires the string buffer containing the name to > > remain allocated, as the name is not copied into another buffer. > > > > So let's add a irq_name field to the data struct instead, which is > > guaranteed to have the appropriate lifetime. > > > > Cc: Thara Gopinath > > Cc: Bjorn Andersson > > Cc: Andy Gross > > Cc: linux-arm-msm@vger.kernel.org > > Signed-off-by: Ard Biesheuvel > > Thanks for the fix. > > Reviewed-by: Thara Gopinath Seems this patch has been overlooked. Would it be possible to resubmit it with a 'Fixes' tag? Regards, Loic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel