From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB41EC433E0 for ; Wed, 24 Feb 2021 08:53:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E7A464ED4 for ; Wed, 24 Feb 2021 08:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234615AbhBXIww (ORCPT ); Wed, 24 Feb 2021 03:52:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234426AbhBXItc (ORCPT ); Wed, 24 Feb 2021 03:49:32 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E065AC06174A for ; Wed, 24 Feb 2021 00:48:51 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id k22so784734pll.6 for ; Wed, 24 Feb 2021 00:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1KFqIVPbE5ZdblNI5ye22qmuhyz5ygfjDdXNq8vyjqw=; b=xjGMavmCPdP1Vb4M3FpMy7QoXmyG6+7FbIjCUclqjEUYMlLV15IptGHKs6SMDiOgHE QVP8+YIiEE2wXXgyQDZINoM0fwhKHbwKeLAiGT7TlZozmqTa8LpHXIGB/8E5cc9rEV56 NSQBUXg/lDd4TEdPW2FENxWHVdWN1Ok0sOL4DM2C50D302aNl2Xy9c60d4mZcDcWoKUR S+Qb1nR3s/TVhYsBbsyaK/2tGKcWTltGUM9WyTmRQlL90Piwxe1doOkmB+DUhIQTlaHw VfJweWin9fOQY01lyWFe5Y4W1cF66A43zKcrcPcSoNENyHPW0/b+eq0a2sHI6JE7fNbT gnqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1KFqIVPbE5ZdblNI5ye22qmuhyz5ygfjDdXNq8vyjqw=; b=TALEtAzUn48lAz7L+MwalbeRocdmUF/R4+7B5ggU2MjlKLZ4FGJD1NhmMQ3Knj5KkN xUn3Emp+0nxosLG1ZED9vRs2PR7gpC7eL+TAeCsdtRCKBp+SgabJdf9MHUCedn4Y3qf0 MJy84H4BO10Gp1+oYlbOp/lCUbGhV2yn9DbA6lm/hRLN86X53xnd13QNim+ukCRzIK/E IGxSTQK3Rw/9LBNDP5DETjZMYX+hzJIspmo0yh2CTQgQAs8oSzzh9j8d7gAAnaNmD8PR w/RiX/k9to8DfGyNvp84BDe3dyaNWC/C6hAw3gqQflSCREaW+8/LldxQSR8faKLyJFL6 RjyQ== X-Gm-Message-State: AOAM532Oh0kCsLmPuTaLkrdMSSafry92hZiLstwzUK3MAqo0DtRyb5Ch OnrboamVEswWq29wXEXO03zjLLnbkAGeNKFCbPDqdg== X-Google-Smtp-Source: ABdhPJx1DaLSyiqD+F7sh1Ya2/foxqsCNSSC/o6wUiZ3aaPlKyawOYejecqj0UFQZXmUtmT90E4E9Y2tfwZ/tVPYehM= X-Received: by 2002:a17:90a:f18d:: with SMTP id bv13mr3546617pjb.13.1614156531491; Wed, 24 Feb 2021 00:48:51 -0800 (PST) MIME-Version: 1.0 References: <20210223180820.ee39f1544f2630d0eecf3a57@linux-foundation.org> <20210224040439.351882-1-mike.kravetz@oracle.com> In-Reply-To: <20210224040439.351882-1-mike.kravetz@oracle.com> From: Muchun Song Date: Wed, 24 Feb 2021 16:48:15 +0800 Message-ID: Subject: Re: [External] [PATCH] hugetlb: document the new location of page subpool pointer To: Mike Kravetz Cc: LKML , Linux Memory Management List , Michal Hocko , Oscar Salvador , Andrew Morton Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2021 at 12:04 PM Mike Kravetz wrote: > > Expand comments, no functional change. > > Signed-off-by: Mike Kravetz Reviewed-by: Muchun Song Thanks > --- > include/linux/hugetlb.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index cccd1aab69dd..c0467a7a1fe0 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -476,6 +476,9 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, > * huegtlb page specific state flags. These flags are located in page.private > * of the hugetlb head page. Functions created via the below macros should be > * used to manipulate these flags. > + * Note: The hugetlb page subpool pointer previously located at page.private > + * was moved to page[1].private to make room for flags in the head page. See > + * hugetlb_page_subpool(). > * > * HPG_restore_reserve - Set when a hugetlb page consumes a reservation at > * allocation time. Cleared when page is fully instantiated. Free > -- > 2.29.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E647C433DB for ; Wed, 24 Feb 2021 08:49:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BF1C5600CC for ; Wed, 24 Feb 2021 08:48:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF1C5600CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3BADC6B0070; Wed, 24 Feb 2021 03:48:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 391FD6B0071; Wed, 24 Feb 2021 03:48:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CF1C6B0072; Wed, 24 Feb 2021 03:48:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 134426B0070 for ; Wed, 24 Feb 2021 03:48:57 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D2B9A180AD81D for ; Wed, 24 Feb 2021 08:48:56 +0000 (UTC) X-FDA: 77852536272.22.898BDF3 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf21.hostedemail.com (Postfix) with ESMTP id D7A20E0011C4 for ; Wed, 24 Feb 2021 08:48:50 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id w18so770448plc.12 for ; Wed, 24 Feb 2021 00:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1KFqIVPbE5ZdblNI5ye22qmuhyz5ygfjDdXNq8vyjqw=; b=xjGMavmCPdP1Vb4M3FpMy7QoXmyG6+7FbIjCUclqjEUYMlLV15IptGHKs6SMDiOgHE QVP8+YIiEE2wXXgyQDZINoM0fwhKHbwKeLAiGT7TlZozmqTa8LpHXIGB/8E5cc9rEV56 NSQBUXg/lDd4TEdPW2FENxWHVdWN1Ok0sOL4DM2C50D302aNl2Xy9c60d4mZcDcWoKUR S+Qb1nR3s/TVhYsBbsyaK/2tGKcWTltGUM9WyTmRQlL90Piwxe1doOkmB+DUhIQTlaHw VfJweWin9fOQY01lyWFe5Y4W1cF66A43zKcrcPcSoNENyHPW0/b+eq0a2sHI6JE7fNbT gnqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1KFqIVPbE5ZdblNI5ye22qmuhyz5ygfjDdXNq8vyjqw=; b=dPE9U48aIVnbMYGzM+U2XzAm7ulkd5rVbx8Tc233BFcRqjUoIiHv95uuTn7ueUSOAG X8uiH4sOJSUaa++0S2caaphi9cqkNj7qYPWWo4MB+m9y8d36DgDrA3fQmhKlsWjiY/Yg yUnkHryTIpL04a3Jftecew/4p7xVlUzAfW3h7eQNwv3jIyFWoXSuhYkrFBw859gdGleC MRfVbt2tWo+DUByUNQnXFOt1cgU2pkGioTd5y7LMkmj8/DOobBIXuQDTwrec3k36K3hm nO7dsI63nuyReaY7ocFEzoQ5Tb7QCA7ZRJ1PKwNyhz/0hoyvq3DiOahLaLs3ZeR/95QD glrA== X-Gm-Message-State: AOAM531TcdXORXPAPdflFsbZLPj7fTXjLY1IVm31ir4WB0me6hxVDMIx skbjJR+IxiiJuh1HKKRQC5smj4cianb5x99lb184kA== X-Google-Smtp-Source: ABdhPJx1DaLSyiqD+F7sh1Ya2/foxqsCNSSC/o6wUiZ3aaPlKyawOYejecqj0UFQZXmUtmT90E4E9Y2tfwZ/tVPYehM= X-Received: by 2002:a17:90a:f18d:: with SMTP id bv13mr3546617pjb.13.1614156531491; Wed, 24 Feb 2021 00:48:51 -0800 (PST) MIME-Version: 1.0 References: <20210223180820.ee39f1544f2630d0eecf3a57@linux-foundation.org> <20210224040439.351882-1-mike.kravetz@oracle.com> In-Reply-To: <20210224040439.351882-1-mike.kravetz@oracle.com> From: Muchun Song Date: Wed, 24 Feb 2021 16:48:15 +0800 Message-ID: Subject: Re: [External] [PATCH] hugetlb: document the new location of page subpool pointer To: Mike Kravetz Cc: LKML , Linux Memory Management List , Michal Hocko , Oscar Salvador , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D7A20E0011C4 X-Stat-Signature: 1jxpjzihrz31gapjwasi7i79i5cphhro Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=mail-pl1-f179.google.com; client-ip=209.85.214.179 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614156530-728250 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 24, 2021 at 12:04 PM Mike Kravetz wrote: > > Expand comments, no functional change. > > Signed-off-by: Mike Kravetz Reviewed-by: Muchun Song Thanks > --- > include/linux/hugetlb.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index cccd1aab69dd..c0467a7a1fe0 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -476,6 +476,9 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, > * huegtlb page specific state flags. These flags are located in page.private > * of the hugetlb head page. Functions created via the below macros should be > * used to manipulate these flags. > + * Note: The hugetlb page subpool pointer previously located at page.private > + * was moved to page[1].private to make room for flags in the head page. See > + * hugetlb_page_subpool(). > * > * HPG_restore_reserve - Set when a hugetlb page consumes a reservation at > * allocation time. Cleared when page is fully instantiated. Free > -- > 2.29.2 >