From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2A95C4363A for ; Thu, 29 Oct 2020 16:34:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5040A20790 for ; Thu, 29 Oct 2020 16:34:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="f6D+/uNP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727012AbgJ2QeC (ORCPT ); Thu, 29 Oct 2020 12:34:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbgJ2QdG (ORCPT ); Thu, 29 Oct 2020 12:33:06 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 305EDC0613CF for ; Thu, 29 Oct 2020 09:33:04 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id w65so2799048pfd.3 for ; Thu, 29 Oct 2020 09:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CNp60uz7U6o1WyBX9AAMogQVRcPxcfAiqCLR+bSZ8wY=; b=f6D+/uNPO6HW47eS+XdsuzOWR1OMKIbf1tDWGNa/eHlbdNS1fFyq73++vFXANcz6x2 ytHLCE17oAxpQhTZeiOQrmqhH4JsQDnMKEzIq5jZmBroArNr7f6GsZp52FWH2KkhY3sM H8KsLn2uIX0lXXKFtXSbrA4roiZkm9N/rx+aLZ7Z/aAg0vhgc/QNYZtvX+naxEa054tr J0G6xItBIlWQ5zhq1bPzfF1wq31Xu/yYiQL3OtYyEzqwyevlKs28VqyQLH4Vw4YcJ7ti 8EQJyl5qnkFrglTZQ6jMXOEWKksSQAolyC8ztjX4eIQqPqjYVEB+NEeUU6DztL2Vnx9B 0Pjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CNp60uz7U6o1WyBX9AAMogQVRcPxcfAiqCLR+bSZ8wY=; b=Io7qf8i5r9rasO4UlRrOiihMGQu8RImYkCIBVc+ArwecvXmFc1R7atmaYAniISnnO7 B5og3mP+N+A0JnBVX5XgkBAM2EPOzuIUWSDdJEvVfTw4kqJ6QyBwQqxOHb/OlUdy1S95 kTnNtsYXf0nqvJqNjWOUsOECgigqLJ16cDRGyrp8LFcRCKkRMJ81grqG5Vhr9gwvh9PF IBCvA4ytRock9uPBWxTAv/je4Z858plJgIHY1csO0hNPaSqXBIP7GlhZdyVd/SRCWFqs 2jsYbmNrC4XDgZy+W/8ZfX21ZOqmzcn0zwRDRxYsN5vO1G5lLB9ZjlkviKlwsWU0er2D 8OJA== X-Gm-Message-State: AOAM530ULTYwQQYB7w9Lzsl5oXXOqIHKJZPSwevsAeE/qzaiIddv99eB KvvmomrwSLYhYS+2CvX1yZn26NOOWAMaSupZDGhPiA== X-Google-Smtp-Source: ABdhPJy1+WefzaCmcrBy2LFwrFD2Wq5MJeAwQJ74F2m6AHO5xCmR0PebTW6H1Op74Lq4+jARizRrOxwrObc2Oo0XhDY= X-Received: by 2002:a17:90b:198d:: with SMTP id mv13mr599421pjb.13.1603989183738; Thu, 29 Oct 2020 09:33:03 -0700 (PDT) MIME-Version: 1.0 References: <20201028035013.99711-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Fri, 30 Oct 2020 00:32:26 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Joonsoo Kim , Yafang Shao , Chris Down , Christian Brauner , "Peter Zijlstra (Intel)" , Ingo Molnar , Kees Cook , Thomas Gleixner , esyr@redhat.com, Suren Baghdasaryan , areber@redhat.com, Marco Elver , LKML , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 12:18 AM Shakeel Butt wrote: > > On Thu, Oct 29, 2020 at 9:09 AM Muchun Song wrote: > > > > On Thu, Oct 29, 2020 at 11:48 PM Shakeel Butt wrote: > > > > > > On Tue, Oct 27, 2020 at 8:50 PM Muchun Song wrote: > > > > > > > > Consider the following memcg hierarchy. > > > > > > > > root > > > > / \ > > > > A B > > > > > > > > If we get the objcg of memcg A failed, > > > > > > Please fix the above statement. > > > > Sorry, could you be more specific, I don't quite understand. > > Fix the grammar. Something like "If we failed to get the reference on > objcg of memcg A..." Got it. Sorry for my poor English, Thanks. -- Yours, Muchun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muchun Song Subject: Re: [External] Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg Date: Fri, 30 Oct 2020 00:32:26 +0800 Message-ID: References: <20201028035013.99711-1-songmuchun@bytedance.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CNp60uz7U6o1WyBX9AAMogQVRcPxcfAiqCLR+bSZ8wY=; b=f6D+/uNPO6HW47eS+XdsuzOWR1OMKIbf1tDWGNa/eHlbdNS1fFyq73++vFXANcz6x2 ytHLCE17oAxpQhTZeiOQrmqhH4JsQDnMKEzIq5jZmBroArNr7f6GsZp52FWH2KkhY3sM H8KsLn2uIX0lXXKFtXSbrA4roiZkm9N/rx+aLZ7Z/aAg0vhgc/QNYZtvX+naxEa054tr J0G6xItBIlWQ5zhq1bPzfF1wq31Xu/yYiQL3OtYyEzqwyevlKs28VqyQLH4Vw4YcJ7ti 8EQJyl5qnkFrglTZQ6jMXOEWKksSQAolyC8ztjX4eIQqPqjYVEB+NEeUU6DztL2Vnx9B 0Pjg== In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Joonsoo Kim , Yafang Shao , Chris Down , Christian Brauner , "Peter Zijlstra (Intel)" , Ingo Molnar , Kees Cook , Thomas Gleixner , esyr@redhat.com, Suren Baghdasaryan , areber@redhat.com, Marco Elver , LKML , Cgroups , Linux MM On Fri, Oct 30, 2020 at 12:18 AM Shakeel Butt wrote: > > On Thu, Oct 29, 2020 at 9:09 AM Muchun Song wrote: > > > > On Thu, Oct 29, 2020 at 11:48 PM Shakeel Butt wrote: > > > > > > On Tue, Oct 27, 2020 at 8:50 PM Muchun Song wrote: > > > > > > > > Consider the following memcg hierarchy. > > > > > > > > root > > > > / \ > > > > A B > > > > > > > > If we get the objcg of memcg A failed, > > > > > > Please fix the above statement. > > > > Sorry, could you be more specific, I don't quite understand. > > Fix the grammar. Something like "If we failed to get the reference on > objcg of memcg A..." Got it. Sorry for my poor English, Thanks. -- Yours, Muchun