From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A48C2BB40 for ; Thu, 17 Dec 2020 10:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E05923899 for ; Thu, 17 Dec 2020 10:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727739AbgLQKnU (ORCPT ); Thu, 17 Dec 2020 05:43:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgLQKnT (ORCPT ); Thu, 17 Dec 2020 05:43:19 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68DB3C0617A7 for ; Thu, 17 Dec 2020 02:42:39 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id i7so8360603pgc.8 for ; Thu, 17 Dec 2020 02:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1ISaOxv2M3y6rzTF7V0ZUu/XvyKLY1Lh8tc0RjKV/bE=; b=JdIliH6SeXTydvTW28vuoACmBG9WQrqrb7eKRimd1Cl9Rh8HMO0wnx7XJRZaA7s0sN dgXttyNW31CGIl4D9+NBOs8ygxpG55qZVW0OepUVtuNnw3MCLFVAP8MXJfyAaEmEMArH ud1l8hYWYRDL5TTsIuEMt8tTHpvlXlQG80iRvj6OkWGBKjMjpHnHEcRqFIr6t4P4hGRg 92iWo0ce2iAyOZv/ULkYH33m4ThMTdyKMzWezF9P85dqlZkW/btdOv1Jfr18pK85a3JX DuIGt2ihK02S2meZ+b1yNUwpJafxowwwPbj1PT3Hc/3fWv9yv5zlIYE8AG2IVjjmPq/N XxFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1ISaOxv2M3y6rzTF7V0ZUu/XvyKLY1Lh8tc0RjKV/bE=; b=P6sGkvVCxH/s4wZQ2TsXtaNi7eer6Aohw/2WImueijcYqFChDv8oGcLoGnruSFFxJJ BM/Adb//jBIs7wmcYmxDchDnDRjlg0KES5iVhD/m+I8jelx4O/GxkZ2C4imVHrINSDXe FxzxX0emwXEZyGoFDQqtpXCDnUCLyxmzPSnuJfOiEPuz/GCpNPDNPSW1xZVd7zedJGZk 9IxdThR3sUGJGUeFLBJKI2O1lxwtNUY9OTGyl/ujVzzJjbkXVYFHcaN/9Je1wbTUKoIE ZOjvdwQDR++DNmN6wP5cEjhrD/5rOOTOxKaifO7UI2mJtP7lMhmKPJu244eTakR6ks8E IvXQ== X-Gm-Message-State: AOAM531r/w5t+0kT/z1oMfnXXO8TwaADayRbHc2rYkMY/4i8srzt0dMe /D4lPz49rg7MSxuVIBsEjaSnNumoY+b3nU7ILjFfyw== X-Google-Smtp-Source: ABdhPJyQqONmSuuKMNSnMEKXcxXk9UVbNjaPbYGZ8ABrFQ0kIzVpoir8YmisZWEI9RBFKOOPGshygmfRmOp3NTZUEXA= X-Received: by 2002:a63:50a:: with SMTP id 10mr9159315pgf.273.1608201758996; Thu, 17 Dec 2020 02:42:38 -0800 (PST) MIME-Version: 1.0 References: <20201213154534.54826-1-songmuchun@bytedance.com> <20201213154534.54826-12-songmuchun@bytedance.com> <20201217103154.GA8481@linux> In-Reply-To: <20201217103154.GA8481@linux> From: Muchun Song Date: Thu, 17 Dec 2020 18:42:02 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v9 11/11] mm/hugetlb: Optimize the code with the help of the compiler To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 17, 2020 at 6:32 PM Oscar Salvador wrote: > > On Sun, Dec 13, 2020 at 11:45:34PM +0800, Muchun Song wrote: > > static inline unsigned int free_vmemmap_pages_per_hpage(struct hstate *h) > > { > > - return h->nr_free_vmemmap_pages; > > + return h->nr_free_vmemmap_pages && is_power_of_2(sizeof(struct page)); > > This is wrong as it will return either true or false, but not what we want: Yeah, very thanks for pointing that out. > > static inline unsigned long free_vmemmap_pages_size_per_hpage(struct hstate *h) > { > return (unsigned long)free_vmemmap_pages_per_hpage(h) << PAGE_SHIFT; > } > > the above will compute to 4096, which is wrong for obvious reasons. You are right. It is my mistake. Thanks Oscar. > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FBBDC4361B for ; Thu, 17 Dec 2020 10:42:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C6F672389A for ; Thu, 17 Dec 2020 10:42:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6F672389A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B891C6B0068; Thu, 17 Dec 2020 05:42:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B11D36B006C; Thu, 17 Dec 2020 05:42:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A02BD6B006E; Thu, 17 Dec 2020 05:42:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 882286B0068 for ; Thu, 17 Dec 2020 05:42:41 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3A404181AEF1D for ; Thu, 17 Dec 2020 10:42:41 +0000 (UTC) X-FDA: 77602435722.16.nose05_08137c427434 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 12D60100E690B for ; Thu, 17 Dec 2020 10:42:41 +0000 (UTC) X-HE-Tag: nose05_08137c427434 X-Filterd-Recvd-Size: 4513 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Dec 2020 10:42:40 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id d2so18779436pfq.5 for ; Thu, 17 Dec 2020 02:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1ISaOxv2M3y6rzTF7V0ZUu/XvyKLY1Lh8tc0RjKV/bE=; b=JdIliH6SeXTydvTW28vuoACmBG9WQrqrb7eKRimd1Cl9Rh8HMO0wnx7XJRZaA7s0sN dgXttyNW31CGIl4D9+NBOs8ygxpG55qZVW0OepUVtuNnw3MCLFVAP8MXJfyAaEmEMArH ud1l8hYWYRDL5TTsIuEMt8tTHpvlXlQG80iRvj6OkWGBKjMjpHnHEcRqFIr6t4P4hGRg 92iWo0ce2iAyOZv/ULkYH33m4ThMTdyKMzWezF9P85dqlZkW/btdOv1Jfr18pK85a3JX DuIGt2ihK02S2meZ+b1yNUwpJafxowwwPbj1PT3Hc/3fWv9yv5zlIYE8AG2IVjjmPq/N XxFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1ISaOxv2M3y6rzTF7V0ZUu/XvyKLY1Lh8tc0RjKV/bE=; b=IHiIl1DHcV51z2OAKe5qc2mjfcqa8r3J+ru657Epkb/gl5N96rX4s0ZolPNurGIHb5 Hj/gHhSo9IoMdLzyw50soqgbvi6ijYRl4HFGmP7MMGdtgevX8e4+dQjkqlpmAc+jh+sx navqL7uWuJJnNCMWKeXlDOmtvVkND/o6IxcsqK2TZtlj3dCD4sY8qI7JYlfW4Vy6PkOC /DQmycDtqLkjOmcnYzm3F1CqsZep2Si0WaFSqs1DKXWUtPi4ebkr/ch1tJk3kMoyq+Bz KmzKUR3NCPZv8j8L2Y8e7ia6HL2VZEYtpzSXR6n3jlgQEC0sQcWkDAqK1r5PePZtvme8 MWeQ== X-Gm-Message-State: AOAM530Hk68tWXqKXj8TVkFY84mg1TKpd5zbZWF4Dvdoo+9uCxI4n9BL 9yL5RTOJl8gSZs09gZAjua+JDvOCXABN/ukQgP4M0Q== X-Google-Smtp-Source: ABdhPJyQqONmSuuKMNSnMEKXcxXk9UVbNjaPbYGZ8ABrFQ0kIzVpoir8YmisZWEI9RBFKOOPGshygmfRmOp3NTZUEXA= X-Received: by 2002:a63:50a:: with SMTP id 10mr9159315pgf.273.1608201758996; Thu, 17 Dec 2020 02:42:38 -0800 (PST) MIME-Version: 1.0 References: <20201213154534.54826-1-songmuchun@bytedance.com> <20201213154534.54826-12-songmuchun@bytedance.com> <20201217103154.GA8481@linux> In-Reply-To: <20201217103154.GA8481@linux> From: Muchun Song Date: Thu, 17 Dec 2020 18:42:02 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v9 11/11] mm/hugetlb: Optimize the code with the help of the compiler To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 17, 2020 at 6:32 PM Oscar Salvador wrote: > > On Sun, Dec 13, 2020 at 11:45:34PM +0800, Muchun Song wrote: > > static inline unsigned int free_vmemmap_pages_per_hpage(struct hstate *h) > > { > > - return h->nr_free_vmemmap_pages; > > + return h->nr_free_vmemmap_pages && is_power_of_2(sizeof(struct page)); > > This is wrong as it will return either true or false, but not what we want: Yeah, very thanks for pointing that out. > > static inline unsigned long free_vmemmap_pages_size_per_hpage(struct hstate *h) > { > return (unsigned long)free_vmemmap_pages_per_hpage(h) << PAGE_SHIFT; > } > > the above will compute to 4096, which is wrong for obvious reasons. You are right. It is my mistake. Thanks Oscar. > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun