From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62DEDC433DB for ; Fri, 12 Mar 2021 05:03:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E59B64FA0 for ; Fri, 12 Mar 2021 05:03:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbhCLFCj (ORCPT ); Fri, 12 Mar 2021 00:02:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbhCLFCi (ORCPT ); Fri, 12 Mar 2021 00:02:38 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F37C3C061574 for ; Thu, 11 Mar 2021 21:02:37 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id 30so6801487ple.4 for ; Thu, 11 Mar 2021 21:02:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m1loYoW2oUetw20mL24ntlr+RIYjd3r3UQ144d0uEqQ=; b=rovTU+A4fTJNpdqJKB/Tz583wGYLyFwPc9Y+0eOiSdygr05TqsbRkQdMkmhPaMvTMU 3V0br0mgm+aBXtbiSaxDW77c4He4QYBwAaxVChwqsR1CW11meCrayvhdlF8+kfQXyr5H 1BFtML5NqxKmeP9b20WzAqVoMJ3F4H2yBEU/UzjzBrZmtushAk25654eixm+jmf9ewfT oIhDtZYJv3fXd7A2Z9BsaGFEmjw9nhWk0lpCrll+LCQFrzp8mLxoIBtUzixpp+rvXwHF cY1lqKaS06x617hf/WhLeTh5jkQxC+RQEF7iimWEv5qo9HquCUBym/ANeyGa+W0HGn04 6xgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m1loYoW2oUetw20mL24ntlr+RIYjd3r3UQ144d0uEqQ=; b=OOSpm713EmzmauuGHGw+0osRbOYW1OocXRtMIdAYQ/ntDJ9ly4qeO7EjpkQ1FdJmoG 4ck88QTChREaSvrmW9JAEW6IKU1u06CKxWPWXnq974hOPGwkBuM2ygeMor2NwXtqGkWQ Befhb0iT58HUWSPU1dlnysK0n6PMvF5ZSIcLY12YjdnVzo18+v25dWh02SpNQ7SUMWxO eWzN598TDtoH26/OAnCmk/ejjZoAhOYamvDq339iXVu+rF0O22tNm+qXN8xTXdNPpYk0 KIk+ozog2Tvb7CO9jKFyEHcrW1ww6lyTvKKiRTa2rZlv3PzOKIQ0hW1nyiQhr4sqTDJF 0s4g== X-Gm-Message-State: AOAM530j12sZ44fEixsvl0WqBpIm/P4d16Xdg7N6A3EIjAde8XhtcLD+ Ct6/BSj3qtqkHjcEo/ggloxve+P8hiSiQyGDqIlBeQ== X-Google-Smtp-Source: ABdhPJwkzc0qelaMsCRdu7v61s9g15WGPYFSSfV+tnQr1AgHSoLp9VF9P1HivDEUzwx1SqQOhdStievyMaXm0sa4xW4= X-Received: by 2002:a17:902:8d86:b029:e6:45a0:b16e with SMTP id v6-20020a1709028d86b02900e645a0b16emr11510146plo.34.1615525357475; Thu, 11 Mar 2021 21:02:37 -0800 (PST) MIME-Version: 1.0 References: <20210309100717.253-1-songmuchun@bytedance.com> <20210309100717.253-3-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Fri, 12 Mar 2021 13:02:01 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v3 2/4] mm: memcontrol: make page_memcg{_rcu} only applicable for non-kmem page To: Shakeel Butt Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 12, 2021 at 11:22 AM Shakeel Butt wrote: > > On Tue, Mar 9, 2021 at 2:09 AM Muchun Song wrote: > > > > We want to reuse the obj_cgroup APIs to charge the kmem pages. > > If we do that, we should store an object cgroup pointer to > > page->memcg_data for the kmem pages. > > > > Finally, page->memcg_data can have 3 different meanings. > > replace 'can' with 'will' Will do. Thanks. > > Other than that I think Roman and Johannes have already given very > good feedback. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911C0C433E0 for ; Fri, 12 Mar 2021 05:02:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D11FA64F9A for ; Fri, 12 Mar 2021 05:02:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D11FA64F9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 52F3E8D0327; Fri, 12 Mar 2021 00:02:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E0148D0317; Fri, 12 Mar 2021 00:02:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 380DA8D0327; Fri, 12 Mar 2021 00:02:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 13D178D0317 for ; Fri, 12 Mar 2021 00:02:42 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B7FD01817C769 for ; Fri, 12 Mar 2021 05:02:41 +0000 (UTC) X-FDA: 77910026922.23.429C525 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf11.hostedemail.com (Postfix) with ESMTP id ADAFC2000385 for ; Fri, 12 Mar 2021 05:02:32 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id w8so4572499pjf.4 for ; Thu, 11 Mar 2021 21:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m1loYoW2oUetw20mL24ntlr+RIYjd3r3UQ144d0uEqQ=; b=rovTU+A4fTJNpdqJKB/Tz583wGYLyFwPc9Y+0eOiSdygr05TqsbRkQdMkmhPaMvTMU 3V0br0mgm+aBXtbiSaxDW77c4He4QYBwAaxVChwqsR1CW11meCrayvhdlF8+kfQXyr5H 1BFtML5NqxKmeP9b20WzAqVoMJ3F4H2yBEU/UzjzBrZmtushAk25654eixm+jmf9ewfT oIhDtZYJv3fXd7A2Z9BsaGFEmjw9nhWk0lpCrll+LCQFrzp8mLxoIBtUzixpp+rvXwHF cY1lqKaS06x617hf/WhLeTh5jkQxC+RQEF7iimWEv5qo9HquCUBym/ANeyGa+W0HGn04 6xgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m1loYoW2oUetw20mL24ntlr+RIYjd3r3UQ144d0uEqQ=; b=D25b+Kil5uvCW3tGSPsb+SCGUOHyfIkc9D43OcrbHX4t1PYLpw6HPOqw9TztNHKfsj yTo0ibm5lRFcFi0KSzP+JYpwPZ1gWDmjse7UZZgCxmKfkJvUCpDH42qHCZIFq5Jgj9xb Cx6efNooWWGv6eGuzdoacuhsr6uZFXfJTTIgQmAS/dSOouK2wNAMwZbomraAzTim34Q3 qrzXeRLUv6Kl3L5KLu74uLPF8oMENRVp6jOUBgoCXvTrQLA37uNt5UxOpAIenAPbuRaz vwIvD3MXPWYTjODI9kC0uF81UA0IBQI9bdnQle3ALIPHnva3qd2AQ2gD8RWa5R/tDWwF cD8Q== X-Gm-Message-State: AOAM531Kng9hYOx6l66LFIU/Ty7MYBGYQBB221nSraSHyNWefGo95II3 47SET+K4G4HcGfiB1aTnypOLCHsq/jROj2t/+KpMpw== X-Google-Smtp-Source: ABdhPJwkzc0qelaMsCRdu7v61s9g15WGPYFSSfV+tnQr1AgHSoLp9VF9P1HivDEUzwx1SqQOhdStievyMaXm0sa4xW4= X-Received: by 2002:a17:902:8d86:b029:e6:45a0:b16e with SMTP id v6-20020a1709028d86b02900e645a0b16emr11510146plo.34.1615525357475; Thu, 11 Mar 2021 21:02:37 -0800 (PST) MIME-Version: 1.0 References: <20210309100717.253-1-songmuchun@bytedance.com> <20210309100717.253-3-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Fri, 12 Mar 2021 13:02:01 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v3 2/4] mm: memcontrol: make page_memcg{_rcu} only applicable for non-kmem page To: Shakeel Butt Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 3srk7bmy1fo49hihyrc5qhkp8syxb4p5 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: ADAFC2000385 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail-pj1-f51.google.com; client-ip=209.85.216.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615525352-687967 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 12, 2021 at 11:22 AM Shakeel Butt wrote: > > On Tue, Mar 9, 2021 at 2:09 AM Muchun Song wrote: > > > > We want to reuse the obj_cgroup APIs to charge the kmem pages. > > If we do that, we should store an object cgroup pointer to > > page->memcg_data for the kmem pages. > > > > Finally, page->memcg_data can have 3 different meanings. > > replace 'can' with 'will' Will do. Thanks. > > Other than that I think Roman and Johannes have already given very > good feedback.