From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC2BC43217 for ; Wed, 23 Dec 2020 02:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85BAF2256F for ; Wed, 23 Dec 2020 02:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731067AbgLWCs0 (ORCPT ); Tue, 22 Dec 2020 21:48:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730062AbgLWCsS (ORCPT ); Tue, 22 Dec 2020 21:48:18 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B2F5C061793 for ; Tue, 22 Dec 2020 18:47:38 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id x1so4087665pgh.12 for ; Tue, 22 Dec 2020 18:47:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2RxImZ5WYRvc5MqAscnk3rOKSiD33zPjRspOINuFOmk=; b=ZSofn4JpoLY62LuOFvyMLW+ht/GEoFFtWL44njivDzeC44346+fsAkf51YIrkwCt2u e2mpu3QIlWALgYyhUPkEOBqOTgcw9ONcKGAKeMFjoYsw+0+c/myum8tIRTLkx6Uovt3x vefkC30tlRJr9xGylZUk2ekApJbfFrL/zqxqYpbCV3u9e2tU4xB1l7JGNsLzUCzx8gKc aiD3IUH6WV7BuQgcmFP+vCAkkEilhHnrKQvlrcr0BMLsT8Fqai4rFo0sXus8YL16+hky ybNCa/sVjeKRTu9uF98dXi4tZ/Aw7wqr/1HzihhnIwwX8eYMX6FebuTri8TMrS3u/JhC CK6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2RxImZ5WYRvc5MqAscnk3rOKSiD33zPjRspOINuFOmk=; b=WgHqkeKqOxyaFGJxo7w8+tyKyOe75yGTpf1rX3x/gWUJp+mW2kGaSZIXRBdI60iE0x zYSopVcfDJFrRG8OVL/IRREqrud4uDPs0UUIEUVvQe2NHTB26nb+pWS/tDb1H27nLelO yQR0MXFTKGVCt73YU8b7U8aF5Gp8i0622FraYkr1oVe0aJFZAFW5yf/on/THiXlXRIxD H57bttz+LDs+RygXyixq1urLmNsHUxBA2/aUedEPZJnWjheCWHYnzrfMbW2Ly7PfS2ji /GWFe3r33PsioCmUcwYFKRAM2jgaoxU89SCbm93xWGs49KMdZkV3wxl16yAJ0Rz8McW6 hGBg== X-Gm-Message-State: AOAM5304w/cB6iI2V3FTIEVZ2PGhrWS6MLlmRZ5TuG1mEhoCwWuGpNXR bxzNZMj6EkiggnlztlG9tzjNX1jA+6Kia4DmKPyMTQ== X-Google-Smtp-Source: ABdhPJy8EmvuJ4kATkeRW6z5LeXrJXJXVcrcQ/jIwvne3ldCQrTuBWBNVQlwzNU1j2RO4aEF/9ZHp8TsxaRao9smtm0= X-Received: by 2002:a63:50a:: with SMTP id 10mr22501568pgf.273.1608691657419; Tue, 22 Dec 2020 18:47:37 -0800 (PST) MIME-Version: 1.0 References: <20201222142440.28930-1-songmuchun@bytedance.com> <20201222142440.28930-11-songmuchun@bytedance.com> <20201222162948.GA31385@linux> In-Reply-To: <20201222162948.GA31385@linux> From: Muchun Song Date: Wed, 23 Dec 2020 10:46:58 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v11 10/11] mm/hugetlb: Gather discrete indexes of tail page To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , naoya.horiguchi@nec.com, Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2020 at 12:30 AM Oscar Salvador wrote: > > On Tue, Dec 22, 2020 at 10:24:39PM +0800, Muchun Song wrote: > > +#else > > +static inline void hwpoison_subpage_deliver(struct hstate *h, struct page *head) > > +{ > > +} > > + > > +static inline void hwpoison_subpage_set(struct hstate *h, struct page *head, > > + struct page *page) > > +{ > > + if (PageHWPoison(head) && page != head) { > > + /* > > + * Move PageHWPoison flag from head page to the raw error page, > > + * which makes any subpages rather than the error page reusable. > > + */ > > + SetPageHWPoison(page); > > + ClearPageHWPoison(head); > > + } > > +} > > +#endif > > Sorry, I guess I should have made a more clear statement. > This patch should really be about changing the numeric index to its symbolic > names, so the #ifdef handling of hwpoison_subpage_* should have been gone into > patch#6. Because patch#6 is also compatible with !CONFIG_HUGETLB_PAGE_FREE_VMEMMAP. So I add the #ifdef handling in this patch. But moving it to patch#6 also makes sense to me. Thanks. > > I will have a closer look later on though. Thanks. > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 478CEC433DB for ; Wed, 23 Dec 2020 02:47:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C3C88225AB for ; Wed, 23 Dec 2020 02:47:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3C88225AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AD34C8D000D; Tue, 22 Dec 2020 21:47:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A83F28D0009; Tue, 22 Dec 2020 21:47:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 923918D000D; Tue, 22 Dec 2020 21:47:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 7844C8D0009 for ; Tue, 22 Dec 2020 21:47:39 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 476DA8249980 for ; Wed, 23 Dec 2020 02:47:39 +0000 (UTC) X-FDA: 77623011438.04.joke46_0917c0e27465 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 2DFC5800EFBF for ; Wed, 23 Dec 2020 02:47:39 +0000 (UTC) X-HE-Tag: joke46_0917c0e27465 X-Filterd-Recvd-Size: 4998 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Dec 2020 02:47:38 +0000 (UTC) Received: by mail-pg1-f173.google.com with SMTP id n7so9679326pgg.2 for ; Tue, 22 Dec 2020 18:47:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2RxImZ5WYRvc5MqAscnk3rOKSiD33zPjRspOINuFOmk=; b=ZSofn4JpoLY62LuOFvyMLW+ht/GEoFFtWL44njivDzeC44346+fsAkf51YIrkwCt2u e2mpu3QIlWALgYyhUPkEOBqOTgcw9ONcKGAKeMFjoYsw+0+c/myum8tIRTLkx6Uovt3x vefkC30tlRJr9xGylZUk2ekApJbfFrL/zqxqYpbCV3u9e2tU4xB1l7JGNsLzUCzx8gKc aiD3IUH6WV7BuQgcmFP+vCAkkEilhHnrKQvlrcr0BMLsT8Fqai4rFo0sXus8YL16+hky ybNCa/sVjeKRTu9uF98dXi4tZ/Aw7wqr/1HzihhnIwwX8eYMX6FebuTri8TMrS3u/JhC CK6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2RxImZ5WYRvc5MqAscnk3rOKSiD33zPjRspOINuFOmk=; b=e9jM5RVhk8yrrv+OpbDYhmdzBubILonml3BcvGF60lVosbIFKr9vcI+DQlFaoTuzdN F0NBdUwXcVVfR8eq58zCe1ziNIrpFPKZiikdVZtxLQxUxosLMfR5qscAbgT8q07ds+XN DEeruqeEbyRBtKoP7/DSAu6StXD9HgXggVrODBmHCrfKzRtLpo7o9wy4D1sVle73erLN yrbNh4Ved+Y723JaZwKseXbe/Td7TUfcPDmSLj443Xg3b12lIvWBu0iOv6857ZHjL+sv KtuYnwaRJbUQjz/fXsLJrzQ2ms6/fjg9tQet936+xJ7Q9pQdSxin7eOKVlSix/ReI7bW E0/A== X-Gm-Message-State: AOAM530wEc0eLxIaEST/F1HrLnb8uFTIpfYSoe/ctwaM8OQhwaz2mLIO LBOn3+w3DMqGYtYodd37jeEy3HCea/7uLz1OwuWPug== X-Google-Smtp-Source: ABdhPJy8EmvuJ4kATkeRW6z5LeXrJXJXVcrcQ/jIwvne3ldCQrTuBWBNVQlwzNU1j2RO4aEF/9ZHp8TsxaRao9smtm0= X-Received: by 2002:a63:50a:: with SMTP id 10mr22501568pgf.273.1608691657419; Tue, 22 Dec 2020 18:47:37 -0800 (PST) MIME-Version: 1.0 References: <20201222142440.28930-1-songmuchun@bytedance.com> <20201222142440.28930-11-songmuchun@bytedance.com> <20201222162948.GA31385@linux> In-Reply-To: <20201222162948.GA31385@linux> From: Muchun Song Date: Wed, 23 Dec 2020 10:46:58 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v11 10/11] mm/hugetlb: Gather discrete indexes of tail page To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , naoya.horiguchi@nec.com, Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 23, 2020 at 12:30 AM Oscar Salvador wrote: > > On Tue, Dec 22, 2020 at 10:24:39PM +0800, Muchun Song wrote: > > +#else > > +static inline void hwpoison_subpage_deliver(struct hstate *h, struct page *head) > > +{ > > +} > > + > > +static inline void hwpoison_subpage_set(struct hstate *h, struct page *head, > > + struct page *page) > > +{ > > + if (PageHWPoison(head) && page != head) { > > + /* > > + * Move PageHWPoison flag from head page to the raw error page, > > + * which makes any subpages rather than the error page reusable. > > + */ > > + SetPageHWPoison(page); > > + ClearPageHWPoison(head); > > + } > > +} > > +#endif > > Sorry, I guess I should have made a more clear statement. > This patch should really be about changing the numeric index to its symbolic > names, so the #ifdef handling of hwpoison_subpage_* should have been gone into > patch#6. Because patch#6 is also compatible with !CONFIG_HUGETLB_PAGE_FREE_VMEMMAP. So I add the #ifdef handling in this patch. But moving it to patch#6 also makes sense to me. Thanks. > > I will have a closer look later on though. Thanks. > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun