From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE601C433E2 for ; Mon, 14 Sep 2020 03:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58EA1208E4 for ; Mon, 14 Sep 2020 03:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="qSowdt5P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726016AbgIND2w (ORCPT ); Sun, 13 Sep 2020 23:28:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbgIND2r (ORCPT ); Sun, 13 Sep 2020 23:28:47 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD8E5C061788 for ; Sun, 13 Sep 2020 20:28:45 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id f18so11392016pfa.10 for ; Sun, 13 Sep 2020 20:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4kHmejXTIo1BBSLRENZgyqFfGzb/ylHsGPtQU3ORsGY=; b=qSowdt5PMPNIuUtYyjjVxXOB007fAprML0D9RLG01hggiBoUvwOyNQT+CB+AUUb69C Pc6o7Mnk2vhKMTjLgNpanvxjhxy12n3MbsrZ/gqVlxBp2pO+LF73GR00DawWKvKDEQsv INJmnpgtznXFsTnRJ8tPl4m3KAttaAVb/5EBaSasg3mXATRb/qHyV5IFUeU2QrDAOVbu QZNs8r67pQqpSQsotruFc6agNZUIRsmSIkmzxe1hrZWD8YD0gAfCg7B+Hp3gnZqSNQg8 1wR3DvI5i/2fNqtA75uiMcFkcXEoRE0qzVYmtLhPvo7zAXgkliZi0O7BUNBe2LhOOGEn U0lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4kHmejXTIo1BBSLRENZgyqFfGzb/ylHsGPtQU3ORsGY=; b=ZmQP6xzWLIap/poEyjdpcl8awhfV2EzOGp2OGpx9pCRjZ27k9FaDlXupIoc07tzSB5 /emS5gq7BNmdHeTiVyaiCteUe6SJpMB+sOPGUl62HpriTCPp0CDdZ6n9Ag4BJr04pEMW Y0QMtbB4/vlJwc0GkE+hIe41KUrp3bAyowuEhKK840qoOENUVH5Wm0Zx2/xVWqvEoKRW OKukgRAKwdDl1cPoT4but9eQm2B/yT8lqlNXnp6n45mqJ3Dk36sl31osIZU/e3TxjTKU A59UNEBWs+w5cQqE8ZLbiqJQlv901aaycd9yBDwYZ4sKg1dxevN2CdldXVckkwbT/yIP ECkA== X-Gm-Message-State: AOAM530yWXAvUPOcF0yWH4StZTTBrEQ+cpbfixlwpwyOZ66ga9jd5QBe JNwU9C1g7dHNk1AOw6y28boiVx1iecqb/IaQIlOjhQ== X-Google-Smtp-Source: ABdhPJyYRwniJbcpH5xKTfN/gYBasufM4x3VEAlZv0zuWL45LjZLH0gCwfNtbKPcwb9oAoUfGRtNjqlf+aJkB1XhvT8= X-Received: by 2002:a63:5515:: with SMTP id j21mr9223604pgb.31.1600054125347; Sun, 13 Sep 2020 20:28:45 -0700 (PDT) MIME-Version: 1.0 References: <20200913070010.44053-1-songmuchun@bytedance.com> <20200913170913.GB2239582@chrisdown.name> <91184891-6a12-87a2-5a82-099a637b072f@huawei.com> In-Reply-To: <91184891-6a12-87a2-5a82-099a637b072f@huawei.com> From: Muchun Song Date: Mon, 14 Sep 2020 11:28:09 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 To: Zefan Li Cc: Chris Down , tj@kernel.org, Johannes Weiner , corbet@lwn.net, Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Cgroups , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , kernel test robot Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2020 at 11:19 AM Zefan Li wrote: > > On 2020/9/14 11:10, Muchun Song wrote: > > On Mon, Sep 14, 2020 at 1:09 AM Chris Down wrote: > >> > >> Muchun Song writes: > >>> In the cgroup v1, we have a numa_stat interface. This is useful for > >>> providing visibility into the numa locality information within an > >>> memcg since the pages are allowed to be allocated from any physical > >>> node. One of the use cases is evaluating application performance by > >>> combining this information with the application's CPU allocation. > >>> But the cgroup v2 does not. So this patch adds the missing information. > >>> > >>> Signed-off-by: Muchun Song > >>> Suggested-by: Shakeel Butt > >>> Reported-by: kernel test robot > >> > >> This is a feature patch, why does this have LKP's Reported-by? > > > > In the v2 version, the kernel test robot reported a compiler error > > on the powerpc architecture. So I added that. Thanks. > > > > You should remove this reported-by, and then add v2->v3 changelog: Got it. I see Andrew has done it for me, thank him very much for his work. He also added this patch to the -mm tree. > > ...original changelog... > > v3: > - fixed something reported by test rebot I already added that in the changelog. Thanks. -- Yours, Muchun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muchun Song Subject: Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 Date: Mon, 14 Sep 2020 11:28:09 +0800 Message-ID: References: <20200913070010.44053-1-songmuchun@bytedance.com> <20200913170913.GB2239582@chrisdown.name> <91184891-6a12-87a2-5a82-099a637b072f@huawei.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4kHmejXTIo1BBSLRENZgyqFfGzb/ylHsGPtQU3ORsGY=; b=qSowdt5PMPNIuUtYyjjVxXOB007fAprML0D9RLG01hggiBoUvwOyNQT+CB+AUUb69C Pc6o7Mnk2vhKMTjLgNpanvxjhxy12n3MbsrZ/gqVlxBp2pO+LF73GR00DawWKvKDEQsv INJmnpgtznXFsTnRJ8tPl4m3KAttaAVb/5EBaSasg3mXATRb/qHyV5IFUeU2QrDAOVbu QZNs8r67pQqpSQsotruFc6agNZUIRsmSIkmzxe1hrZWD8YD0gAfCg7B+Hp3gnZqSNQg8 1wR3DvI5i/2fNqtA75uiMcFkcXEoRE0qzVYmtLhPvo7zAXgkliZi0O7BUNBe2LhOOGEn U0lQ== In-Reply-To: <91184891-6a12-87a2-5a82-099a637b072f@huawei.com> Sender: linux-doc-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Zefan Li Cc: Chris Down , tj@kernel.org, Johannes Weiner , corbet@lwn.net, Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Cgroups , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , kernel test robot On Mon, Sep 14, 2020 at 11:19 AM Zefan Li wrote: > > On 2020/9/14 11:10, Muchun Song wrote: > > On Mon, Sep 14, 2020 at 1:09 AM Chris Down wrote: > >> > >> Muchun Song writes: > >>> In the cgroup v1, we have a numa_stat interface. This is useful for > >>> providing visibility into the numa locality information within an > >>> memcg since the pages are allowed to be allocated from any physical > >>> node. One of the use cases is evaluating application performance by > >>> combining this information with the application's CPU allocation. > >>> But the cgroup v2 does not. So this patch adds the missing information. > >>> > >>> Signed-off-by: Muchun Song > >>> Suggested-by: Shakeel Butt > >>> Reported-by: kernel test robot > >> > >> This is a feature patch, why does this have LKP's Reported-by? > > > > In the v2 version, the kernel test robot reported a compiler error > > on the powerpc architecture. So I added that. Thanks. > > > > You should remove this reported-by, and then add v2->v3 changelog: Got it. I see Andrew has done it for me, thank him very much for his work. He also added this patch to the -mm tree. > > ...original changelog... > > v3: > - fixed something reported by test rebot I already added that in the changelog. Thanks. -- Yours, Muchun