From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D750FC4338F for ; Fri, 30 Jul 2021 02:38:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5F916103A for ; Fri, 30 Jul 2021 02:38:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235849AbhG3Cim (ORCPT ); Thu, 29 Jul 2021 22:38:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbhG3Cik (ORCPT ); Thu, 29 Jul 2021 22:38:40 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8BC4C061765 for ; Thu, 29 Jul 2021 19:38:35 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id n10so9300208plf.4 for ; Thu, 29 Jul 2021 19:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x4WMMn3KZL/hzwCkedZqe/lll/VsdM4TyQkWpwv+pB0=; b=Ekx4RmWXZPFJE+OMq795Ky7l5Qiiu10/BdprEfuK7DG+c7bB5LrAOoxCfOq4LcZdVB yBREPZM20pqfvFU85pDqfCUKfxMy2RQvQJA1Oo9WdmQS1E3QhJLqVvKHd2W1lsTmaYFV IubFHVyVEUe+rkf/seQ+ZGzYLjQhZ8PdSvS2mB6lwN3aTJMTGelWDOqxJilxvC10Hyl3 1pmNQgU/21cplXyhA7jnHCWRUeOai5mmHHhP6If+azneudn4hpuE3f5ZfN0ULd+XhatO PeLdmEC8sMTSch8HjtrbtNCKYJuDQ+p5Qhiwxn3ofBQmXx4KzMLaoFZSAZoDFOMBH4jD y7Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x4WMMn3KZL/hzwCkedZqe/lll/VsdM4TyQkWpwv+pB0=; b=Fm4dulyOgshDyDeWLrN6hwbXuoDwanD1I4euf09XLwLxcOFXrRiZWZMO6BARrqiITG jkcYQrDnnHenG84ahPBkGLIyP0OVUhkWsK/uQj27pqqYvKhk7pqBskXpnaj+5SIMyzN6 gFeLkgWoH1FgeqebCkh2H1iXl+tXx1MWrc4drhedWn0Bb5H90V/pPfS+TbwXcvIfMzSP gNxnEsdKYHQ5Q9xJeuxfRFFklZX094VXbeBc8rNr8Q6S8Vzb/Ri0phFSIDeeANpwRSaa nooqLSw256QPQwVHTsY3U1l80wAWV1S1WXZejNu0lXPL4Ruh5P92I0GU05l7R/svm1JZ L6Qg== X-Gm-Message-State: AOAM532W1VVNDbWfPmfwIvd/1mz1Y5ch5h602oBuRFaayAauUZiGHGR4 xmM6TrsBjre61YUgPeKkSDaJy5s9yHem/vNW+qiTOQ== X-Google-Smtp-Source: ABdhPJxBGjZRIrUbp4ZwPJ7kfW59bEBib6O3i3OsKd96uN491iSaTFmmzpTqpEUp9/J7M5p5eVbNep3OV61b7VZBVFQ= X-Received: by 2002:a63:550c:: with SMTP id j12mr203751pgb.31.1627612715592; Thu, 29 Jul 2021 19:38:35 -0700 (PDT) MIME-Version: 1.0 References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-4-linmiaohe@huawei.com> In-Reply-To: <20210729125755.16871-4-linmiaohe@huawei.com> From: Muchun Song Date: Fri, 30 Jul 2021 10:37:55 +0800 Message-ID: Subject: Re: [PATCH 3/5] mm, memcg: save some atomic ops when flush is already true To: Miaohe Lin Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Matthew Wilcox , Alex Shi , Wei Yang , Linux Memory Management List , LKML , Cgroups Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 8:57 PM Miaohe Lin wrote: > > Add 'else' to save some atomic ops in obj_stock_flush_required() when > flush is already true. No functional change intended here. > > Signed-off-by: Miaohe Lin Reviewed-by: Muchun Song From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5875DC4320A for ; Fri, 30 Jul 2021 02:38:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9116260F4A for ; Fri, 30 Jul 2021 02:38:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9116260F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8B5106B0036; Thu, 29 Jul 2021 22:38:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 865DB8D0001; Thu, 29 Jul 2021 22:38:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 754926B006C; Thu, 29 Jul 2021 22:38:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id 57F0B6B0036 for ; Thu, 29 Jul 2021 22:38:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0004926DD9 for ; Fri, 30 Jul 2021 02:38:37 +0000 (UTC) X-FDA: 78417695916.03.D0FF907 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf05.hostedemail.com (Postfix) with ESMTP id 80DBD502B230 for ; Fri, 30 Jul 2021 02:38:36 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id e21so9294897pla.5 for ; Thu, 29 Jul 2021 19:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x4WMMn3KZL/hzwCkedZqe/lll/VsdM4TyQkWpwv+pB0=; b=Ekx4RmWXZPFJE+OMq795Ky7l5Qiiu10/BdprEfuK7DG+c7bB5LrAOoxCfOq4LcZdVB yBREPZM20pqfvFU85pDqfCUKfxMy2RQvQJA1Oo9WdmQS1E3QhJLqVvKHd2W1lsTmaYFV IubFHVyVEUe+rkf/seQ+ZGzYLjQhZ8PdSvS2mB6lwN3aTJMTGelWDOqxJilxvC10Hyl3 1pmNQgU/21cplXyhA7jnHCWRUeOai5mmHHhP6If+azneudn4hpuE3f5ZfN0ULd+XhatO PeLdmEC8sMTSch8HjtrbtNCKYJuDQ+p5Qhiwxn3ofBQmXx4KzMLaoFZSAZoDFOMBH4jD y7Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x4WMMn3KZL/hzwCkedZqe/lll/VsdM4TyQkWpwv+pB0=; b=elmgUEY423tPxQfaghZROJ/Hgh65TksOEcwKsTDn4SGcRwuJ5ik7Fqva0suOcFURru M0MCy+pWwMoQis6leloika1whe5rLtKYmSUAOlQ7LTwOiA2DpXEt9Acl3XPZ5FJt8zst c4g8RysiNs37HTGfZMaBLKAY67uAXrZr7PRwuSs0vKFPKif/lFTTXMdW10G0eL5f2p7V PNgKE+VenUf6QYLLOUSDimq9B7WnxnEN/4nL4GEReYs7w8ZriIwG7yAuhXUMAYwmo66+ a0H69tgrYz5av6tqpW9oW//cx+SPxJyfmcr5Zk8zij6kMCxRMoAdqzslrmz7ckVzAZaH 6eeQ== X-Gm-Message-State: AOAM53219qzDUNJkWa5Y+NwK+++q7w8ZPGoud3WH1Rvf5MKrBVOkUnV/ 3hflZ3DddQJVFzlUTWjV6q+QW2o8A8pFaRGzlCJTaw== X-Google-Smtp-Source: ABdhPJxBGjZRIrUbp4ZwPJ7kfW59bEBib6O3i3OsKd96uN491iSaTFmmzpTqpEUp9/J7M5p5eVbNep3OV61b7VZBVFQ= X-Received: by 2002:a63:550c:: with SMTP id j12mr203751pgb.31.1627612715592; Thu, 29 Jul 2021 19:38:35 -0700 (PDT) MIME-Version: 1.0 References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-4-linmiaohe@huawei.com> In-Reply-To: <20210729125755.16871-4-linmiaohe@huawei.com> From: Muchun Song Date: Fri, 30 Jul 2021 10:37:55 +0800 Message-ID: Subject: Re: [PATCH 3/5] mm, memcg: save some atomic ops when flush is already true To: Miaohe Lin Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Matthew Wilcox , Alex Shi , Wei Yang , Linux Memory Management List , LKML , Cgroups Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 80DBD502B230 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=Ekx4RmWX; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: d7zuei6gukfm4koom97qbcy8m8tghnyn X-HE-Tag: 1627612716-158508 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 29, 2021 at 8:57 PM Miaohe Lin wrote: > > Add 'else' to save some atomic ops in obj_stock_flush_required() when > flush is already true. No functional change intended here. > > Signed-off-by: Miaohe Lin Reviewed-by: Muchun Song From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muchun Song Subject: Re: [PATCH 3/5] mm, memcg: save some atomic ops when flush is already true Date: Fri, 30 Jul 2021 10:37:55 +0800 Message-ID: References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-4-linmiaohe@huawei.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x4WMMn3KZL/hzwCkedZqe/lll/VsdM4TyQkWpwv+pB0=; b=Ekx4RmWXZPFJE+OMq795Ky7l5Qiiu10/BdprEfuK7DG+c7bB5LrAOoxCfOq4LcZdVB yBREPZM20pqfvFU85pDqfCUKfxMy2RQvQJA1Oo9WdmQS1E3QhJLqVvKHd2W1lsTmaYFV IubFHVyVEUe+rkf/seQ+ZGzYLjQhZ8PdSvS2mB6lwN3aTJMTGelWDOqxJilxvC10Hyl3 1pmNQgU/21cplXyhA7jnHCWRUeOai5mmHHhP6If+azneudn4hpuE3f5ZfN0ULd+XhatO PeLdmEC8sMTSch8HjtrbtNCKYJuDQ+p5Qhiwxn3ofBQmXx4KzMLaoFZSAZoDFOMBH4jD y7Mg== In-Reply-To: <20210729125755.16871-4-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Miaohe Lin Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Matthew Wilcox , Alex Shi , Wei Yang , Linux Memory Management List , LKML , Cgroups On Thu, Jul 29, 2021 at 8:57 PM Miaohe Lin wrote: > > Add 'else' to save some atomic ops in obj_stock_flush_required() when > flush is already true. No functional change intended here. > > Signed-off-by: Miaohe Lin Reviewed-by: Muchun Song