From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0127FC43460 for ; Sat, 17 Apr 2021 02:55:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFB74610C8 for ; Sat, 17 Apr 2021 02:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235369AbhDQCxQ (ORCPT ); Fri, 16 Apr 2021 22:53:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231997AbhDQCxP (ORCPT ); Fri, 16 Apr 2021 22:53:15 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5CC2C061574 for ; Fri, 16 Apr 2021 19:52:49 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id ot17-20020a17090b3b51b0290109c9ac3c34so17385726pjb.4 for ; Fri, 16 Apr 2021 19:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3y4uMJwxdfxzyakbODD1x0NzAbS7Yk2HNyccYDXmfCI=; b=uhJmRC/aYBTjuTZ2C05qdctiZJlM6K2Ig6e358l38mvItPTVNPJ3EWIJ7wdzpJB7vT 3e/HSVZWbU+nI4+hXfwZckvT6bb14TlDq9eunjskYgGcNQ1qH4Lcw09LFddKDgYbhYCF RAOWUn/MKlyD2nDbuEgMCLz4IBdvq5dQAtGJg+vcH9orrFRqHSnDSZ+Zua/A6i1cRvb2 FcflbOWw39G+FaGYnam0OICqLbAjA5ZhXpG+ww35/rmNZNbMX5nV+vLf06Xa8c5z/ieU zWfQY8oUDJH8N+5qWpAaO3fXbn6JGwVhRqcQh7Lvf9jdfZlLG7FIIE8XMl3w5lJkMq5c ukDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3y4uMJwxdfxzyakbODD1x0NzAbS7Yk2HNyccYDXmfCI=; b=ph35MCZinilgfZRH02ZDPeTekGxqQe93i5PMwl62QbORnUkaPGyVo2ALOLaBdTtNrv 64cywE/Ws3jRlD1N01olZbbcOXk/nmgmTnU8eoNIkjTcKYyL8IdZRnL6CcErMW5klr8n GFwVROyzTBuPA6/rwZBlBggT8GIFl2ifSsz838Vyw9UQtuu4NA9HjWYU+BUEOzdrR/GV RPWFusT4mpgaGSGJKjJebIGco0xpBLE6Kzz4/ime0Cb4deSlnuWXjxzJZ1Txu9cddL0T A60zDR/n2edkDcUp5cD+k8B+eY3OC5CAtu4LIcsqRywn4sClpiCPPhTcLlUIauOfZqtB r2lw== X-Gm-Message-State: AOAM533kImL3QE8SZn5d+4MK7Yktj2fJQZ1iQ8TnfQZyjCVU2Q7fPyUT PFhydtxl6QMTKV2ZQDHvmBDX13xgks//oV9Fi0GBcQ== X-Google-Smtp-Source: ABdhPJw/MdTLGomUJTFifNOlyECCO5Kfd1e6fcMYTr7DRYck2137jMjE8g4Kt+HVeQXO4eht//z+fqK0V19E4upYe6Q= X-Received: by 2002:a17:90a:a895:: with SMTP id h21mr12995333pjq.13.1618627969184; Fri, 16 Apr 2021 19:52:49 -0700 (PDT) MIME-Version: 1.0 References: <20210416051407.54878-1-songmuchun@bytedance.com> <20210416051407.54878-6-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Sat, 17 Apr 2021 10:52:12 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v2 5/8] mm: memcontrol: rename lruvec_holds_page_lru_lock to page_matches_lruvec To: Johannes Weiner Cc: Roman Gushchin , Michal Hocko , Andrew Morton , Shakeel Butt , Vladimir Davydov , LKML , Linux Memory Management List , Xiongchun duan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 11:20 PM Johannes Weiner wrote: > > On Fri, Apr 16, 2021 at 01:14:04PM +0800, Muchun Song wrote: > > lruvec_holds_page_lru_lock() doesn't check anything about locking and is > > used to check whether the page belongs to the lruvec. So rename it to > > page_matches_lruvec(). > > > > Signed-off-by: Muchun Song > > The rename makes sense, since the previous name was defined by a > specific use case rather than what it does. That said, it did imply a > lock context that makes the test result stable. Without that the > function could use a short comment, IMO. How about: > > /* Test requires a stable page->memcg binding, see page_memcg() */ Make sense. I will add this comment. > > With that, > Acked-by: Johannes Weiner Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A29AC433B4 for ; Sat, 17 Apr 2021 02:52:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9E200610A6 for ; Sat, 17 Apr 2021 02:52:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E200610A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3037A6B006C; Fri, 16 Apr 2021 22:52:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B3D36B006E; Fri, 16 Apr 2021 22:52:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12DC26B0070; Fri, 16 Apr 2021 22:52:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id E90A26B006C for ; Fri, 16 Apr 2021 22:52:51 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 95F66180AD83B for ; Sat, 17 Apr 2021 02:52:51 +0000 (UTC) X-FDA: 78040336542.29.3055700 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf27.hostedemail.com (Postfix) with ESMTP id 0660F80192C7 for ; Sat, 17 Apr 2021 02:52:36 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id h20so14935076plr.4 for ; Fri, 16 Apr 2021 19:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3y4uMJwxdfxzyakbODD1x0NzAbS7Yk2HNyccYDXmfCI=; b=uhJmRC/aYBTjuTZ2C05qdctiZJlM6K2Ig6e358l38mvItPTVNPJ3EWIJ7wdzpJB7vT 3e/HSVZWbU+nI4+hXfwZckvT6bb14TlDq9eunjskYgGcNQ1qH4Lcw09LFddKDgYbhYCF RAOWUn/MKlyD2nDbuEgMCLz4IBdvq5dQAtGJg+vcH9orrFRqHSnDSZ+Zua/A6i1cRvb2 FcflbOWw39G+FaGYnam0OICqLbAjA5ZhXpG+ww35/rmNZNbMX5nV+vLf06Xa8c5z/ieU zWfQY8oUDJH8N+5qWpAaO3fXbn6JGwVhRqcQh7Lvf9jdfZlLG7FIIE8XMl3w5lJkMq5c ukDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3y4uMJwxdfxzyakbODD1x0NzAbS7Yk2HNyccYDXmfCI=; b=ZBxm0R+v+MOQVo9J4oKrA7xNBfK6/Iw6EBFl9KLGm8/+CoSCYs8zSyw6R2ULZGgZXN seoNhsySeUzRNeE0nyx81JhnU1h8UWNDUVPvJ/mHLv4w50y1nX6BVtrJ6Pv2/QkSek8i zcJTQgx75E9903hxnD7WRq/tPrxPG6Y+fPi8SMYD4h6HYsG/YAie0WxxRymg4TVBeAaj 2cw/BhR00TAZGmOHcoZ7zNHVkheTsLqnS2lEt6wLYyKdesTHZpsj/Acexe/nK24zANZ4 vJingPUa1zSDpKKMaZ+X7eHvGhJYdghkBykoLkYTUmdkUmYaV6gDXV8L0AOUtS69wt1i hwrA== X-Gm-Message-State: AOAM530zc7kfVmX7FKKPMBaPVEERKzUP4kC0KRj69Zqk6HBR0hlSquot FCiAcpD54tDk0fvaK/FPFWtgWbSVAU73xjDsaNeH/w== X-Google-Smtp-Source: ABdhPJw/MdTLGomUJTFifNOlyECCO5Kfd1e6fcMYTr7DRYck2137jMjE8g4Kt+HVeQXO4eht//z+fqK0V19E4upYe6Q= X-Received: by 2002:a17:90a:a895:: with SMTP id h21mr12995333pjq.13.1618627969184; Fri, 16 Apr 2021 19:52:49 -0700 (PDT) MIME-Version: 1.0 References: <20210416051407.54878-1-songmuchun@bytedance.com> <20210416051407.54878-6-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Sat, 17 Apr 2021 10:52:12 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v2 5/8] mm: memcontrol: rename lruvec_holds_page_lru_lock to page_matches_lruvec To: Johannes Weiner Cc: Roman Gushchin , Michal Hocko , Andrew Morton , Shakeel Butt , Vladimir Davydov , LKML , Linux Memory Management List , Xiongchun duan Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0660F80192C7 X-Stat-Signature: 9545iabsk31s35jaqrrpo6k93nfzon3c Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mail-pl1-f176.google.com; client-ip=209.85.214.176 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618627956-548400 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 16, 2021 at 11:20 PM Johannes Weiner wrote: > > On Fri, Apr 16, 2021 at 01:14:04PM +0800, Muchun Song wrote: > > lruvec_holds_page_lru_lock() doesn't check anything about locking and is > > used to check whether the page belongs to the lruvec. So rename it to > > page_matches_lruvec(). > > > > Signed-off-by: Muchun Song > > The rename makes sense, since the previous name was defined by a > specific use case rather than what it does. That said, it did imply a > lock context that makes the test result stable. Without that the > function could use a short comment, IMO. How about: > > /* Test requires a stable page->memcg binding, see page_memcg() */ Make sense. I will add this comment. > > With that, > Acked-by: Johannes Weiner Thanks.