From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 881AEC43460 for ; Fri, 2 Apr 2021 03:15:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56782610CE for ; Fri, 2 Apr 2021 03:15:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234346AbhDBDPH (ORCPT ); Thu, 1 Apr 2021 23:15:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234314AbhDBDPE (ORCPT ); Thu, 1 Apr 2021 23:15:04 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A38DC0613E6 for ; Thu, 1 Apr 2021 20:15:02 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id q5so2781062pfh.10 for ; Thu, 01 Apr 2021 20:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SRRgjqZ34MTVBuBEV7ju4Pgz+uX9gggPAvm+h647JYY=; b=WpiIjAFAa3LDUSlegmsWYXaJG3Lxq8FnfJDhFAUa85YVy6u2c6LSRBhrYOYeSsrVCF IQHD3TSclXT/gOIDAxyTHmP8FjI6ahotRY+OcekK6gn5i/SpVsReSQApGguzpjfIkTbk fY6mDvLRcdvTE3tLNfJ7tx6nM9MrOskCPfxYfW1siddrR/tI/szYM72WFHCu5yw4pWnb NeKY99YBgNYIKUkXS7UUNlvw6i+cScau0KtRPoNJoWsQKwuqB76YRpcFQw+SXf7HrzFG Hz6PKdu+SOae/I0oRF+PZCdR5klqKOXXBwlJ+7WAvcQL7qdmhsn+uS2ycAY2r0ZF7Fl0 5eVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SRRgjqZ34MTVBuBEV7ju4Pgz+uX9gggPAvm+h647JYY=; b=L/XeS8at4iutrOVQPD5vV1N6oduFJuaqKs2fu2To1S0Ji1T+L9vSaFuzRxh9aduVgI Ref3gAD+45Ve3gFyygKGO30BPuKmq4CWtQUMhG1Jj6pewh9KCt8vQ5Tp6txwMurDsww1 pIB4De0bolsz30ltMhq7HFpYvE8Rpz5m+D4kZgky6E9a5y3j5rQiTc+LexIx7n/vkqat o+TZqupPAhJ9dhGTWGQp+emfSjRsyfbBAZzm/c8qUMP1akF1XOUg+NcZczYp1TYc9x7h WT31IBvOs2IgdtF7CndREYqQyk2HSYNmiYMwYBo2mshCQ1g0FfnxGcFDrXN41wZhL9+g 7+tg== X-Gm-Message-State: AOAM532np4xGQ74yZ8WbduU13JOYKTqFt/uQy4V/aI4hpmYfcIoICxtQ +0BBHGTufSavBZZxxlB2TCArBtnSHZAWNaz2BE3QxQ== X-Google-Smtp-Source: ABdhPJwUSy91Vwe8jJkU7IgBm5OUh9KKtZUxJ0Dpr43MIzjX77rXi40U2hmN1yMab/PFdcSre+4AJeMslM+E25chegw= X-Received: by 2002:aa7:9e5b:0:b029:1f1:5ba4:57a2 with SMTP id z27-20020aa79e5b0000b02901f15ba457a2mr10220791pfq.59.1617333302040; Thu, 01 Apr 2021 20:15:02 -0700 (PDT) MIME-Version: 1.0 References: <20210330101531.82752-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Fri, 2 Apr 2021 11:14:23 +0800 Message-ID: Subject: Re: [External] Re: [RFC PATCH 00/15] Use obj_cgroup APIs to charge the LRU pages To: Shakeel Butt Cc: Johannes Weiner , Roman Gushchin , Greg Thelen , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 2, 2021 at 1:15 AM Shakeel Butt wrote: > > On Thu, Apr 1, 2021 at 9:08 AM Muchun Song wrote: > > > [...] > > > The zombie issue is a pretty urgent concern that has caused several > > > production emergencies now. It needs a fix sooner rather than later. > > > > Thank you very much for clarifying the problem for me. I do agree > > with you. This issue should be fixed ASAP. Using objcg is a good > > choice. Dying objcg should not be a problem. Because the size of > > objcg is so small compared to memcg. > > > > Just wanted to say out loud that yes this patchset will reduce the > memcg zombie issue but this is not the final destination. We should > continue the discussions on sharing/reusing scenarios. Yeah. Reducing the zombie memcg is not the final destination. But it is an optimization. OK. The discussions about sharing/reusing is also welcome. > > Muchun, can you please also CC Hugh Dickins and Alex Shi in the next > version of your patchset? No problem. I will cc Alex Shi in the next version. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F90C433B4 for ; Fri, 2 Apr 2021 03:15:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 839C160FDC for ; Fri, 2 Apr 2021 03:15:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 839C160FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E34D96B0071; Thu, 1 Apr 2021 23:15:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE4CC6B0072; Thu, 1 Apr 2021 23:15:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5EB66B0073; Thu, 1 Apr 2021 23:15:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id AA71C6B0071 for ; Thu, 1 Apr 2021 23:15:04 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5F546EFE5 for ; Fri, 2 Apr 2021 03:15:04 +0000 (UTC) X-FDA: 77985960528.22.0CC1A2B Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf08.hostedemail.com (Postfix) with ESMTP id C268B80192DA for ; Fri, 2 Apr 2021 03:15:00 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id 11so1090496pfn.9 for ; Thu, 01 Apr 2021 20:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SRRgjqZ34MTVBuBEV7ju4Pgz+uX9gggPAvm+h647JYY=; b=WpiIjAFAa3LDUSlegmsWYXaJG3Lxq8FnfJDhFAUa85YVy6u2c6LSRBhrYOYeSsrVCF IQHD3TSclXT/gOIDAxyTHmP8FjI6ahotRY+OcekK6gn5i/SpVsReSQApGguzpjfIkTbk fY6mDvLRcdvTE3tLNfJ7tx6nM9MrOskCPfxYfW1siddrR/tI/szYM72WFHCu5yw4pWnb NeKY99YBgNYIKUkXS7UUNlvw6i+cScau0KtRPoNJoWsQKwuqB76YRpcFQw+SXf7HrzFG Hz6PKdu+SOae/I0oRF+PZCdR5klqKOXXBwlJ+7WAvcQL7qdmhsn+uS2ycAY2r0ZF7Fl0 5eVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SRRgjqZ34MTVBuBEV7ju4Pgz+uX9gggPAvm+h647JYY=; b=rBPFRYl6Cay2cnxTTsvzMgqvQ3hfPzqUi74lfcPlbHoBGiIC3aEqABeGjBMeyQi9EA 63cyINKis7MV+Qs4KXFkVLdsKS/4tgbyvriW7orjj9I0EqCsAobnK8fFyCovoiDUfmF6 fpTQygkyOELHKV/F/oZbZybdGyTR0otxiwjiwiwmv9r87JtqtJpocBMog8aVHMEpKDhy ehcmaJKszXtZ9ga7tLiAeBcyDh7pDOQzYL9d3EU9JnNdcajdXmQaXyKCI4u1BY2XSE51 Ia0tDPrVsmNpMfWM8NzFw0n0zqdUuWBE+Aj7SFOUDDd5QxCW1ydNcfkxZBoUWht5fPcy +Ikw== X-Gm-Message-State: AOAM533xUL7oMOikzwcFDrh7SZmUev5+U/yOvgZpeAn7K+rFKKkDdzdx FYqxUgtnAv4gB3H6AeA244Y/Z8a77ifKU4B408/d0Q== X-Google-Smtp-Source: ABdhPJwUSy91Vwe8jJkU7IgBm5OUh9KKtZUxJ0Dpr43MIzjX77rXi40U2hmN1yMab/PFdcSre+4AJeMslM+E25chegw= X-Received: by 2002:aa7:9e5b:0:b029:1f1:5ba4:57a2 with SMTP id z27-20020aa79e5b0000b02901f15ba457a2mr10220791pfq.59.1617333302040; Thu, 01 Apr 2021 20:15:02 -0700 (PDT) MIME-Version: 1.0 References: <20210330101531.82752-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Fri, 2 Apr 2021 11:14:23 +0800 Message-ID: Subject: Re: [External] Re: [RFC PATCH 00/15] Use obj_cgroup APIs to charge the LRU pages To: Shakeel Butt Cc: Johannes Weiner , Roman Gushchin , Greg Thelen , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C268B80192DA X-Stat-Signature: ayj5dgh91w55ft3p7d7rj73apzri3atd X-Rspamd-Server: rspam02 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail-pf1-f179.google.com; client-ip=209.85.210.179 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617333300-784251 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 2, 2021 at 1:15 AM Shakeel Butt wrote: > > On Thu, Apr 1, 2021 at 9:08 AM Muchun Song wrote: > > > [...] > > > The zombie issue is a pretty urgent concern that has caused several > > > production emergencies now. It needs a fix sooner rather than later. > > > > Thank you very much for clarifying the problem for me. I do agree > > with you. This issue should be fixed ASAP. Using objcg is a good > > choice. Dying objcg should not be a problem. Because the size of > > objcg is so small compared to memcg. > > > > Just wanted to say out loud that yes this patchset will reduce the > memcg zombie issue but this is not the final destination. We should > continue the discussions on sharing/reusing scenarios. Yeah. Reducing the zombie memcg is not the final destination. But it is an optimization. OK. The discussions about sharing/reusing is also welcome. > > Muchun, can you please also CC Hugh Dickins and Alex Shi in the next > version of your patchset? No problem. I will cc Alex Shi in the next version.