From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98598C4363A for ; Thu, 29 Oct 2020 13:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26267207BC for ; Thu, 29 Oct 2020 13:35:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="bHBQYcj8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbgJ2NfE (ORCPT ); Thu, 29 Oct 2020 09:35:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725300AbgJ2NfD (ORCPT ); Thu, 29 Oct 2020 09:35:03 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4146C0613D2 for ; Thu, 29 Oct 2020 06:35:01 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id n15so2822629wrq.2 for ; Thu, 29 Oct 2020 06:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KpTzlVayUqmIgARPOMPHIPf+pVQBXZ57u27MnCRyRl4=; b=bHBQYcj8neeWwxu6NrAHcOkwrOtEZGmaAjWKrh8jI1JhyZORzyCnXt3On6YqLd0N6p tErqMaeHRpKVhnOsWX3ipgXBeAanJDaLg2D8M4OQev81G0DQIHUklusbFlwpETgl05pA 9uzcGGNCaO4+1Zg9YIBIK8jKoXD+ErnUL7DN3jIGsEqoYlvUdmyR609Qw/hR5IczuWjV VOAARd7lzT6kY3GvtELMpY3LsYW8LByBImUhKXyPeXliSUfxfhqOAPaLA5/E3P/6e0Cw EAEc+4wV66ab4E6oPsOs9CQKokMSZ7Skmwwz6q3RzYKcpQ3sF5XwenicLyIEirLdcuLc LAJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KpTzlVayUqmIgARPOMPHIPf+pVQBXZ57u27MnCRyRl4=; b=O2mXsjOZ1EpovZRgyvwAusZsi31anqziDu7O5Ds5GXs8bPjdd9SGBiPkWKP0QluXjF 8F77gg2G5cB+3n+RSta5rDPNWaqDjEf4fhjE9Y/zoLmUd86n2LEPR3BnTSEk3zV4Blmr 9sejLitJmQqXCsN3HkgSDrX4Rv9D4dNJLyKb4LLcSjUN588JSI0vRRx75Cr3/UalLIWc pqVKSE3w3IxPDGxyhGTuQ104UT6Ii5FXN9qi6ejWF8IIfgI81o2giWI/ZXIfAoRiUoij hQvSo91Bl/+pCVb5An8ToN+a1PCZ8s9VRyz9kbRQ9yYucyROz4gO8hiq3iLzPWqIeMtv DgRA== X-Gm-Message-State: AOAM531Qp0B0v8QOJnIORJoRAFIdBkpzGYOjk8Jl2YLU7a8GFsOsxMA+ lAqMIzvwWB73wE6QCmK9ObdJO8X8HYD3b/otayn6Iw== X-Google-Smtp-Source: ABdhPJzoa2kj33P5RHtMoZgDs5yNcjZnapoviF7YdfZYL3bAMykZSBtyBQnjKWARVTGdeTQXxtRcORTM2XC5tC0dDY8= X-Received: by 2002:a5d:69d1:: with SMTP id s17mr5830591wrw.398.1603978500435; Thu, 29 Oct 2020 06:35:00 -0700 (PDT) MIME-Version: 1.0 References: <20201026145114.59424-1-songmuchun@bytedance.com> <20201026145114.59424-4-songmuchun@bytedance.com> <20201029102913.GA31881@linux> In-Reply-To: <20201029102913.GA31881@linux> From: Muchun Song Date: Thu, 29 Oct 2020 21:34:22 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v2 03/19] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 6:29 PM Oscar Salvador wrote: > > On Mon, Oct 26, 2020 at 10:50:58PM +0800, Muchun Song wrote: > > The purpose of introducing HUGETLB_PAGE_FREE_VMEMMAP is to configure > > whether to enable the feature of freeing unused vmemmap associated > > with HugeTLB pages. Now only support x86. > > Why this needs to be a config thing? > If this space-memory-optimization does not come with a trade-off, > why does the user have to set this instead of coming by default? Now we only support x86_64. If we want to support other archs. We need some arch special code to support this feature. In the future, if this patch series is merged to mainline, I will implement this optimization for other archs. At that time we can remove the HUGETLB_PAGE_FREE_VMEMMAP. Thanks. > > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 098E3C2D0A3 for ; Thu, 29 Oct 2020 13:35:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45CAB2075E for ; Thu, 29 Oct 2020 13:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="bHBQYcj8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45CAB2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AEC566B0073; Thu, 29 Oct 2020 09:35:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A753B6B0074; Thu, 29 Oct 2020 09:35:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 852116B0075; Thu, 29 Oct 2020 09:35:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 4CE866B0073 for ; Thu, 29 Oct 2020 09:35:03 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CBC1A180AD80F for ; Thu, 29 Oct 2020 13:35:02 +0000 (UTC) X-FDA: 77425058844.30.spot76_1e0137b2728d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 9AB40180B3C85 for ; Thu, 29 Oct 2020 13:35:02 +0000 (UTC) X-HE-Tag: spot76_1e0137b2728d X-Filterd-Recvd-Size: 4387 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 13:35:01 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id t9so2761742wrq.11 for ; Thu, 29 Oct 2020 06:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KpTzlVayUqmIgARPOMPHIPf+pVQBXZ57u27MnCRyRl4=; b=bHBQYcj8neeWwxu6NrAHcOkwrOtEZGmaAjWKrh8jI1JhyZORzyCnXt3On6YqLd0N6p tErqMaeHRpKVhnOsWX3ipgXBeAanJDaLg2D8M4OQev81G0DQIHUklusbFlwpETgl05pA 9uzcGGNCaO4+1Zg9YIBIK8jKoXD+ErnUL7DN3jIGsEqoYlvUdmyR609Qw/hR5IczuWjV VOAARd7lzT6kY3GvtELMpY3LsYW8LByBImUhKXyPeXliSUfxfhqOAPaLA5/E3P/6e0Cw EAEc+4wV66ab4E6oPsOs9CQKokMSZ7Skmwwz6q3RzYKcpQ3sF5XwenicLyIEirLdcuLc LAJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KpTzlVayUqmIgARPOMPHIPf+pVQBXZ57u27MnCRyRl4=; b=Ws4PegOtjC/kHp0BGmHMHm/nsc4jdjgR/AazSPAqljQB+V26TsO/d0OukjdxvRYUa+ 2q5Lny/s6F97Se37RY5E2g/mN+4qB6sH8Y90YErtMhFdv6yEE8ajrH05XdmgpKU5zAj3 fr1D5094TFNH+09IKGguM9KaEfiL2IfWlk8xcgnIVOf8oHOrhzHyD4bIE392eV38fs35 p/Y2yxR8cxncw0IsW692R7LZUa/X4aN7U7q3VX3r1nT6s7IvjyDVwhHvH1G4EIs4oMCL AI6FFfxO4qcXO8vZM8VoBbSIoeorGmYtkDgJWh1XuudXjD+QPlUED7HgabWyjMdHUdk1 f13Q== X-Gm-Message-State: AOAM532HTMad3I5CHtJFFOzpLt38LaXCC9Ru666qzNYTTFRM7lLHCmQm A35gNJnKPBpVBs8PMwrwhah1q5IhTCXyKQdQVXclag== X-Google-Smtp-Source: ABdhPJzoa2kj33P5RHtMoZgDs5yNcjZnapoviF7YdfZYL3bAMykZSBtyBQnjKWARVTGdeTQXxtRcORTM2XC5tC0dDY8= X-Received: by 2002:a5d:69d1:: with SMTP id s17mr5830591wrw.398.1603978500435; Thu, 29 Oct 2020 06:35:00 -0700 (PDT) MIME-Version: 1.0 References: <20201026145114.59424-1-songmuchun@bytedance.com> <20201026145114.59424-4-songmuchun@bytedance.com> <20201029102913.GA31881@linux> In-Reply-To: <20201029102913.GA31881@linux> From: Muchun Song Date: Thu, 29 Oct 2020 21:34:22 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v2 03/19] mm/hugetlb: Introduce a new config HUGETLB_PAGE_FREE_VMEMMAP To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 6:29 PM Oscar Salvador wrote: > > On Mon, Oct 26, 2020 at 10:50:58PM +0800, Muchun Song wrote: > > The purpose of introducing HUGETLB_PAGE_FREE_VMEMMAP is to configure > > whether to enable the feature of freeing unused vmemmap associated > > with HugeTLB pages. Now only support x86. > > Why this needs to be a config thing? > If this space-memory-optimization does not come with a trade-off, > why does the user have to set this instead of coming by default? Now we only support x86_64. If we want to support other archs. We need some arch special code to support this feature. In the future, if this patch series is merged to mainline, I will implement this optimization for other archs. At that time we can remove the HUGETLB_PAGE_FREE_VMEMMAP. Thanks. > > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun