From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE3AC468BF for ; Mon, 10 May 2021 10:56:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8CC86194A for ; Mon, 10 May 2021 10:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234251AbhEJK4F (ORCPT ); Mon, 10 May 2021 06:56:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232880AbhEJKop (ORCPT ); Mon, 10 May 2021 06:44:45 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 113A4C061345 for ; Mon, 10 May 2021 03:34:16 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id u25so2393187pgl.9 for ; Mon, 10 May 2021 03:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GbEg5B1XI9iNST/E/f70TSfKy/dyLBSsJanb6FiDxic=; b=f59ner0D/1qo5HyqTZPlnjeQGdv7ehb8TdlVTo883tA/MXBcSAIscvH2kflRetliLC 2ldbA4AOnMUr/99l1qryK6AOVgMBHunKzEHL/8Dh1NDK9SueoJw/qeG8RdHl2Op/gzox L5wdoQkSdijVZGPr49AJgJ7z3J1DewJWUEkdLff0xSkZZwvITSznBNxdWJFuwOygvU5Y J2dLOxY4NbqekqowGzzndqj7IrRuz4/t+O3heK9u1Xzeb2rJBWbSG9sTkueoQ+GzrKWl dN7rmghZQrBAgGrUeDTAIEJ1MJjXNtmUAmttQKTKQH1rrqCmJdnTbJGYurasAK/zkqwo ykIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GbEg5B1XI9iNST/E/f70TSfKy/dyLBSsJanb6FiDxic=; b=t+0tGxC/tV1W8J+YETFc4evFELI0OpcO6Ph+IsO6773t+yxl+7+apI71ThBVP4YmxB GjI4O2E9qEpi4YsO3ETSBEf1A6ICy4SkZNCyTizZEOB8G1/Y6Cjdazs4hb4L5ASbSYF4 oonIXi/09a/3dEQ13bq8aLUY6QMQ33V7MrjAkmo9tvxqLbF97zO5NLhmp7Cp4IbFItYq bb0JlN+TQ0NepPBzPq1G9UqTUMzb0E22SU/LwwB+ru2QsYYPAJtvxPYgFpR9RUWcUFHG XzPsXCeImasCWAUdGyY74yKyTB6bSMuAmljosOVC0/g1XLuJEbxkRgy5vyuiyog6TCqf Wi/Q== X-Gm-Message-State: AOAM531mYIDSxT4h11HxVnizWTSPLoHFhE15Hckg54ND4B5/p+Lp9/qT JC14NwZSKikLjxmvE2ucllwwqF0D+sgxd+AW3+Ut8Q== X-Google-Smtp-Source: ABdhPJyHUEien5qCpH7v1ah8orxYfkawudbsyoFQsZ5IuBkIgJ3pV0ZZhlDNcBUrx9QSpxHHGhQ+bS4LMxBGt3jpl1s= X-Received: by 2002:a63:b206:: with SMTP id x6mr11623323pge.341.1620642855648; Mon, 10 May 2021 03:34:15 -0700 (PDT) MIME-Version: 1.0 References: <20210510030027.56044-1-songmuchun@bytedance.com> <20210510030027.56044-9-songmuchun@bytedance.com> <20210510100809.GA22664@linux> In-Reply-To: <20210510100809.GA22664@linux> From: Muchun Song Date: Mon, 10 May 2021 18:33:38 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v23 8/9] mm: memory_hotplug: disable memmap_on_memory when hugetlb_free_vmemmap enabled To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , Ingo Molnar , bp@alien8.de, X86 ML , hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , Alexander Viro , Andrew Morton , paulmck@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Joao Martins , Xiongchun duan , fam.zheng@bytedance.com, zhengqi.arch@bytedance.com, linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 10, 2021 at 6:08 PM Oscar Salvador wrote: > > On Mon, May 10, 2021 at 11:00:26AM +0800, Muchun Song wrote: > > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > > index 8cc195c4c861..0d7f595ee441 100644 > > --- a/drivers/acpi/acpi_memhotplug.c > > +++ b/drivers/acpi/acpi_memhotplug.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "internal.h" > > Uhm, I am confused. > Why do we need this here? AFAICS, we do not. > > The function is in memory_hotplug.c, and that alrady has that include. > What am I missing? You are right. That include is redundant. I will remove it from acpi_memhotplug.c. Thanks Oscar. > > > -- > Oscar Salvador > SUSE L3