From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17489C433DF for ; Wed, 29 Jul 2020 07:39:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1AC92076E for ; Wed, 29 Jul 2020 07:38:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="qvu8pBA3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726996AbgG2Hi6 (ORCPT ); Wed, 29 Jul 2020 03:38:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbgG2Hi5 (ORCPT ); Wed, 29 Jul 2020 03:38:57 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71B71C0619D2 for ; Wed, 29 Jul 2020 00:38:57 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id lx9so1641116pjb.2 for ; Wed, 29 Jul 2020 00:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Hf50u6h9wnLFy96WAeaaud4OkMwukdvpfoIh17caQSk=; b=qvu8pBA35juXB5IAuj3EOdEUiIafCwux4Zh/tDRiwecjZ4h5ljtUkch7bU9dNi7BEn zDV1HWeXxyCHZ+z2tecTWyTytdwhCEd+DESLLScaS3yfoPMOqFliEXQd8TV0hQYlTJtq KbivU5pLK8l1ZRq1qGCXjh0QZyOLgi3XhExE07HdtbzYUitJ5N17urMNFvkQLT+boa/3 k5+plqHvx2y0rTUOJgJEmfCPNHFoKVZvQWvR3/xJ9pYJ0/Me2W8JrPQtu6RHmwTL08Tz Ykq8YBWIbvNFayGGaRBCwOFl+137kCp0rtNEZYG3EIZvf5Dg0Ef7VahEMkXnpQf7V2e9 0Nkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Hf50u6h9wnLFy96WAeaaud4OkMwukdvpfoIh17caQSk=; b=MBAV0C6UgOH8Xx1vfV6AbvYhQtdvHXopHSwVfIxX3ySLJDGUCyes5uV/JMRXLp7F1Q FXT3qgmnghG1dutBVLJioHq6VO89pqbj6PhToqtTWEqoEGa3O3URNBkVYK4lfSLg5Bgg tcOVkw5+NX0jX+V6ZmU1Rv/dLx7KCdDZWihc+UZPfgFElOLXykkJ8nN2pXXVYLsySIa1 DjGPWQ0zje4mNX9+6j+hzjsUdjjNddw+UaaZLXDXrv85rY/Qvg7j1UbSBOMzMOnbepCs ZmZJUvFnFj9DOSxLlfWPWbr3NoSfVlQxKiLdEpoqpwxTLO9Di6I1Q9hQ+EL2OZ6xGkNW ExTQ== X-Gm-Message-State: AOAM532doCwNgcHrZuJ277mpy+jPmBjn6h0jzEUoTnH1Cgwo7uLXLKjn iWFEdTRI7Bz+vswYvwiAtRcTcND06ieuyoCtp34yvA== X-Google-Smtp-Source: ABdhPJz3p/RdzMtYa5b161gOYMyR9V5zWuKnydulgpgc6pQ29hu00H5qrHoahniLRmzse010xwGrjzFF810Pxzvlfuk= X-Received: by 2002:a17:90a:fa8c:: with SMTP id cu12mr8694751pjb.229.1596008336834; Wed, 29 Jul 2020 00:38:56 -0700 (PDT) MIME-Version: 1.0 References: <20200721101647.42653-1-hexin.op@bytedance.com> In-Reply-To: <20200721101647.42653-1-hexin.op@bytedance.com> From: Muchun Song Date: Wed, 29 Jul 2020 15:38:21 +0800 Message-ID: Subject: Re: [PATCH v3] drm/virtio: fix missing dma_fence_put() in virtio_gpu_execbuffer_ioctl() To: Xin He , daniel@ffwll.ch, airlied@linux.ie, kraxel@redhat.com, sumit.semwal@linaro.org, LKML , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Cc: linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Qi Liu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 6:17 PM Xin He wrote: > > From: Qi Liu > > We should put the reference count of the fence after calling > virtio_gpu_cmd_submit(). So add the missing dma_fence_put(). > > Fixes: 2cd7b6f08bc4 ("drm/virtio: add in/out fence support for explicit s= ynchronization") > Co-developed-by: Xin He > Signed-off-by: Xin He > Signed-off-by: Qi Liu > Reviewed-by: Muchun Song > --- > > changelog in v3: > 1) Change the subject from "drm/virtio: fixed memory leak in virtio_gpu_e= xecbuffer_ioctl()" to > "drm/virtio: fix missing dma_fence_put() in virtio_gpu_execbuffer_ioct= l()" > 2) Rework the commit log > > changelog in v2: > 1) Add a change description > > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/vir= tio/virtgpu_ioctl.c > index 5df722072ba0..19c5bc01eb79 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c > +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > @@ -179,6 +179,7 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_dev= ice *dev, void *data, > > virtio_gpu_cmd_submit(vgdev, buf, exbuf->size, > vfpriv->ctx_id, buflist, out_fence); > + dma_fence_put(&out_fence->f); > virtio_gpu_notify(vgdev); > return 0; > > -- > 2.21.1 (Apple Git-122.3) > Ping guys. Any comments or suggestions=EF=BC=9F --=20 Yours, Muchun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A709FC433E0 for ; Thu, 30 Jul 2020 07:18:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 401BB207F5 for ; Thu, 30 Jul 2020 07:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="qvu8pBA3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 401BB207F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 77DFF6E88F; Thu, 30 Jul 2020 07:18:36 +0000 (UTC) Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60CD06E466 for ; Wed, 29 Jul 2020 07:38:57 +0000 (UTC) Received: by mail-pj1-x1042.google.com with SMTP id c10so87650pjn.1 for ; Wed, 29 Jul 2020 00:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Hf50u6h9wnLFy96WAeaaud4OkMwukdvpfoIh17caQSk=; b=qvu8pBA35juXB5IAuj3EOdEUiIafCwux4Zh/tDRiwecjZ4h5ljtUkch7bU9dNi7BEn zDV1HWeXxyCHZ+z2tecTWyTytdwhCEd+DESLLScaS3yfoPMOqFliEXQd8TV0hQYlTJtq KbivU5pLK8l1ZRq1qGCXjh0QZyOLgi3XhExE07HdtbzYUitJ5N17urMNFvkQLT+boa/3 k5+plqHvx2y0rTUOJgJEmfCPNHFoKVZvQWvR3/xJ9pYJ0/Me2W8JrPQtu6RHmwTL08Tz Ykq8YBWIbvNFayGGaRBCwOFl+137kCp0rtNEZYG3EIZvf5Dg0Ef7VahEMkXnpQf7V2e9 0Nkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Hf50u6h9wnLFy96WAeaaud4OkMwukdvpfoIh17caQSk=; b=RS3YBLf2P0SS+9Ra0hXEYpTNTsjg9r/oZ7DHAnANY831K28EprLbUon+h4G/B6unb3 nW+XVCCB4vcYVxO1CBcFdZo2cdSqN8HJCWxwGCWjeP/iTbUYXzol92QvVrS1nnzou9LK F9weHleCATcAI0m0S3o6JMO2KRWbNbeiBeZB9aXcbf/4T/af4Y32S6NK17GcDDep1vqe JoyIoGGa9NN7B0rda7fTamtd8OeK28XNCBrcs9CBrDgZZ82qymOjZqc7nSg0JGHYqmiu GNnKJpxHD27CScITiJn7sIhfNO0q4t8XDKjR61mBUpxHPtJ5P8oA9V6nAmwxuOkNvxu/ RwnQ== X-Gm-Message-State: AOAM533JGXxYTFSHCQOQo/ddGt3WWOku7kVvUhJWl8wlONZNn+/lt+Fx Q9FU0dNJcRcLy6DdVYExX2Th8pZXW4D1l6FbtGTdlw== X-Google-Smtp-Source: ABdhPJz3p/RdzMtYa5b161gOYMyR9V5zWuKnydulgpgc6pQ29hu00H5qrHoahniLRmzse010xwGrjzFF810Pxzvlfuk= X-Received: by 2002:a17:90a:fa8c:: with SMTP id cu12mr8694751pjb.229.1596008336834; Wed, 29 Jul 2020 00:38:56 -0700 (PDT) MIME-Version: 1.0 References: <20200721101647.42653-1-hexin.op@bytedance.com> In-Reply-To: <20200721101647.42653-1-hexin.op@bytedance.com> From: Muchun Song Date: Wed, 29 Jul 2020 15:38:21 +0800 Message-ID: Subject: Re: [PATCH v3] drm/virtio: fix missing dma_fence_put() in virtio_gpu_execbuffer_ioctl() To: Xin He , daniel@ffwll.ch, airlied@linux.ie, kraxel@redhat.com, sumit.semwal@linaro.org, LKML , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org X-Mailman-Approved-At: Thu, 30 Jul 2020 07:16:49 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linaro-mm-sig@lists.linaro.org, Qi Liu , linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBKdWwgMjEsIDIwMjAgYXQgNjoxNyBQTSBYaW4gSGUgPGhleGluLm9wQGJ5dGVkYW5j ZS5jb20+IHdyb3RlOgo+Cj4gRnJvbTogUWkgTGl1IDxsaXVxaS4xNkBieXRlZGFuY2UuY29tPgo+ Cj4gV2Ugc2hvdWxkIHB1dCB0aGUgcmVmZXJlbmNlIGNvdW50IG9mIHRoZSBmZW5jZSBhZnRlciBj YWxsaW5nCj4gdmlydGlvX2dwdV9jbWRfc3VibWl0KCkuIFNvIGFkZCB0aGUgbWlzc2luZyBkbWFf ZmVuY2VfcHV0KCkuCj4KPiBGaXhlczogMmNkN2I2ZjA4YmM0ICgiZHJtL3ZpcnRpbzogYWRkIGlu L291dCBmZW5jZSBzdXBwb3J0IGZvciBleHBsaWNpdCBzeW5jaHJvbml6YXRpb24iKQo+IENvLWRl dmVsb3BlZC1ieTogWGluIEhlIDxoZXhpbi5vcEBieXRlZGFuY2UuY29tPgo+IFNpZ25lZC1vZmYt Ynk6IFhpbiBIZSA8aGV4aW4ub3BAYnl0ZWRhbmNlLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBRaSBM aXUgPGxpdXFpLjE2QGJ5dGVkYW5jZS5jb20+Cj4gUmV2aWV3ZWQtYnk6IE11Y2h1biBTb25nIDxz b25nbXVjaHVuQGJ5dGVkYW5jZS5jb20+Cj4gLS0tCj4KPiBjaGFuZ2Vsb2cgaW4gdjM6Cj4gMSkg Q2hhbmdlIHRoZSBzdWJqZWN0IGZyb20gImRybS92aXJ0aW86IGZpeGVkIG1lbW9yeSBsZWFrIGlu IHZpcnRpb19ncHVfZXhlY2J1ZmZlcl9pb2N0bCgpIiB0bwo+ICAgICJkcm0vdmlydGlvOiBmaXgg bWlzc2luZyBkbWFfZmVuY2VfcHV0KCkgaW4gdmlydGlvX2dwdV9leGVjYnVmZmVyX2lvY3RsKCki Cj4gMikgUmV3b3JrIHRoZSBjb21taXQgbG9nCj4KPiBjaGFuZ2Vsb2cgaW4gdjI6Cj4gMSkgQWRk IGEgY2hhbmdlIGRlc2NyaXB0aW9uCj4KPiAgZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1 X2lvY3RsLmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X2lvY3RsLmMgYi9kcml2ZXJz L2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfaW9jdGwuYwo+IGluZGV4IDVkZjcyMjA3MmJhMC4uMTlj NWJjMDFlYjc5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdwdV9p b2N0bC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZpcnRpby92aXJ0Z3B1X2lvY3RsLmMKPiBA QCAtMTc5LDYgKzE3OSw3IEBAIHN0YXRpYyBpbnQgdmlydGlvX2dwdV9leGVjYnVmZmVyX2lvY3Rs KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4KPiAgICAgICAgIHZpcnRpb19n cHVfY21kX3N1Ym1pdCh2Z2RldiwgYnVmLCBleGJ1Zi0+c2l6ZSwKPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB2ZnByaXYtPmN0eF9pZCwgYnVmbGlzdCwgb3V0X2ZlbmNlKTsKPiArICAg ICAgIGRtYV9mZW5jZV9wdXQoJm91dF9mZW5jZS0+Zik7Cj4gICAgICAgICB2aXJ0aW9fZ3B1X25v dGlmeSh2Z2Rldik7Cj4gICAgICAgICByZXR1cm4gMDsKPgo+IC0tCj4gMi4yMS4xIChBcHBsZSBH aXQtMTIyLjMpCj4KClBpbmcgZ3V5cy4gQW55IGNvbW1lbnRzIG9yIHN1Z2dlc3Rpb25z77yfCgot LSAKWW91cnMsCk11Y2h1bgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK