From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3AA2C4361B for ; Sat, 5 Dec 2020 18:45:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8674C22B37 for ; Sat, 5 Dec 2020 18:45:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726206AbgLESo1 (ORCPT ); Sat, 5 Dec 2020 13:44:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726943AbgLEQtg (ORCPT ); Sat, 5 Dec 2020 11:49:36 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75D70C02B8F5 for ; Sat, 5 Dec 2020 07:40:01 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id w16so5449170pga.9 for ; Sat, 05 Dec 2020 07:40:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/IX944X6oZl2Mzi0wZiZDHD4FwyqaIDsig5F+iiEk9k=; b=opakRlC7cQn4ZWwCZOV7BpaskunmVBhmP/y6bDVxwQnEDw1HsXsTmG7UqEkeEanTg7 4yFQRNbstV/rae16oZ8vMyaC/8FhDJVXsSrhYShQimL2K7yAKNUxfy/V5FTqN4k8WFDC HKSOX5OcgbHSM/Vy8sTi8tPSzCzCURVaS1dkTfItKp5ZblNX6yRd3ajWqemrx/OUiPww jWOgbzl8EX/PJP/RUCYMYZQkuKqdQLRPeO49D6iT6kmEEVhHDm8XFwA9PhfZfQqZ+eQT nylPadt5IjBaQkx5n0qHVvuB5FfBdP/8dyJOMeY84V9ekjWUn02WrC0cCQ3aXLas8gvC DItQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/IX944X6oZl2Mzi0wZiZDHD4FwyqaIDsig5F+iiEk9k=; b=O5d1IF1g3gfc+Y9epTAKsEpBoITifCc7Z0Dpr9Q2hB4RwVtH0Lds1D2UKM74olxEb2 5IYaoHg29WSCK9gv+5yWtd1EQJ6PLyuoIGhrFMuQC+4pbs0Aa054Ehp0bTEZny06mnXp aswis6mMTaIvb3EcH0CwcBlMiuVBKyCMO1YgiTI6N7C6qs4lJ7WGV6fgzePDEI4prVsq aWKCUDKrY3ZU2QaTETF4b/1RwrKI+ZxqB2uXgR9OLSZyj2kAMVRCtstBIGY29FhA0GS0 VfNWgsLGOv8oFI/vHzVf6gxY5CYKZ6kQ/buURsCPpIiyhAJyMWYXxAVPaw3LNrXr/aAS gv6w== X-Gm-Message-State: AOAM532pG8iw8JAodmlyzrgT3o5IuZcYOkqN4qnQ7eUsznY8LeWtwULn qazvMvl1lc7y+Y6Us06Z8oIrnHjzsG23U3cGWswFMA== X-Google-Smtp-Source: ABdhPJxMajBcqLFmL9fRt9cb50qxiMQn7k0izPFnayPR+eOm8xMxHvwAqxpRKw2wMjyEt2Q40p/KwQd88huMo0W4kJA= X-Received: by 2002:aa7:8105:0:b029:18e:c8d9:2c24 with SMTP id b5-20020aa781050000b029018ec8d92c24mr8740020pfi.49.1607182800915; Sat, 05 Dec 2020 07:40:00 -0800 (PST) MIME-Version: 1.0 References: <20201205130224.81607-1-songmuchun@bytedance.com> <20201205130224.81607-6-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Sat, 5 Dec 2020 23:39:24 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 5/9] mm: memcontrol: convert NR_FILE_THPS account to pages To: Greg KH Cc: rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Will Deacon , Roman Gushchin , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 5, 2020 at 11:32 PM Greg KH wrote: > > On Sat, Dec 05, 2020 at 11:29:26PM +0800, Muchun Song wrote: > > On Sat, Dec 5, 2020 at 10:09 PM Greg KH wrote: > > > > > > On Sat, Dec 05, 2020 at 09:02:20PM +0800, Muchun Song wrote: > > > > Converrt NR_FILE_THPS account to pages. > > > > > > > > Signed-off-by: Muchun Song > > > > --- > > > > drivers/base/node.c | 3 +-- > > > > fs/proc/meminfo.c | 2 +- > > > > mm/filemap.c | 2 +- > > > > mm/huge_memory.c | 3 ++- > > > > mm/khugepaged.c | 2 +- > > > > mm/memcontrol.c | 5 ++--- > > > > 6 files changed, 8 insertions(+), 9 deletions(-) > > > > > > > > diff --git a/drivers/base/node.c b/drivers/base/node.c > > > > index 05c369e93e16..f6a9521bbcf8 100644 > > > > --- a/drivers/base/node.c > > > > +++ b/drivers/base/node.c > > > > @@ -466,8 +466,7 @@ static ssize_t node_read_meminfo(struct device *dev, > > > > HPAGE_PMD_NR), > > > > nid, K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) * > > > > HPAGE_PMD_NR), > > > > - nid, K(node_page_state(pgdat, NR_FILE_THPS) * > > > > - HPAGE_PMD_NR), > > > > + nid, K(node_page_state(pgdat, NR_FILE_THPS)), > > > > > > Again, is this changing a user-visable value? > > > > > > > Of course not. > > > > In the previous, the NR_FILE_THPS account is like below: > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, 1); > > > > With this patch, it is: > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, HPAGE_PMD_NR); > > > > So the result is not changed from the view of user space. > > So you "broke" it on the previous patch and "fixed" it on this one? Why > not just do it all in one patch? Sorry for the confusion. I mean that the "previous" is without all of this patch series. So this series is aimed to convert the unit of all different THP vmstat counters from HPAGE_PMD_NR to pages. Thanks. > > Confused, > > greg k-h -- Yours, Muchun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7A2C433FE for ; Sat, 5 Dec 2020 15:40:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0DE4922C7E for ; Sat, 5 Dec 2020 15:40:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DE4922C7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8CAA46B0036; Sat, 5 Dec 2020 10:40:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 853836B005D; Sat, 5 Dec 2020 10:40:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71AB96B006C; Sat, 5 Dec 2020 10:40:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 58A656B0036 for ; Sat, 5 Dec 2020 10:40:03 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1F2E0180AD807 for ; Sat, 5 Dec 2020 15:40:03 +0000 (UTC) X-FDA: 77559639486.03.cord11_4300d94273ce Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id F1DAC28A4E8 for ; Sat, 5 Dec 2020 15:40:02 +0000 (UTC) X-HE-Tag: cord11_4300d94273ce X-Filterd-Recvd-Size: 5780 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Sat, 5 Dec 2020 15:40:02 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id 131so5914686pfb.9 for ; Sat, 05 Dec 2020 07:40:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/IX944X6oZl2Mzi0wZiZDHD4FwyqaIDsig5F+iiEk9k=; b=opakRlC7cQn4ZWwCZOV7BpaskunmVBhmP/y6bDVxwQnEDw1HsXsTmG7UqEkeEanTg7 4yFQRNbstV/rae16oZ8vMyaC/8FhDJVXsSrhYShQimL2K7yAKNUxfy/V5FTqN4k8WFDC HKSOX5OcgbHSM/Vy8sTi8tPSzCzCURVaS1dkTfItKp5ZblNX6yRd3ajWqemrx/OUiPww jWOgbzl8EX/PJP/RUCYMYZQkuKqdQLRPeO49D6iT6kmEEVhHDm8XFwA9PhfZfQqZ+eQT nylPadt5IjBaQkx5n0qHVvuB5FfBdP/8dyJOMeY84V9ekjWUn02WrC0cCQ3aXLas8gvC DItQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/IX944X6oZl2Mzi0wZiZDHD4FwyqaIDsig5F+iiEk9k=; b=JEM8f4GqfoglBPJOirPQZ8+rpM5ejDU2VsLFO/FQuwBqcdE4ZyJc0AQGD/ukE7pJ7V dKqcjF7m6cthCUbU+0exI8G+5IcQYjcqRQAJ/IiON3F0rWN85PyalN3wor+Pa7ws4rHa VrRElooGQHFwtVEvFEGzQDQtN+Y5zwNTfz8uQjjKL7FxtbyIHhIahumQmg8ZPkvnFTxe SDzkIXiCer13dMmiXnWH1dhsr4TieRtJcbKyhcnrISbN3sfM6U0F32pkhN9bZ4ZmXWK7 5Sr8UWDZc4dVdAigC/f77cEATwc48oIKuSdOu9S9K1DchcS3e8LB8mLivBO73ixG9Mnk D08g== X-Gm-Message-State: AOAM530wcNB4KHmI9xP/qPBJoV5Rrxr1+nFfLhFMOeVGxhzCGuvxNr8g D8jkVMe/M1vuJOjRXb6EWlTYz4/ooNMUAWEFucbBOQ== X-Google-Smtp-Source: ABdhPJxMajBcqLFmL9fRt9cb50qxiMQn7k0izPFnayPR+eOm8xMxHvwAqxpRKw2wMjyEt2Q40p/KwQd88huMo0W4kJA= X-Received: by 2002:aa7:8105:0:b029:18e:c8d9:2c24 with SMTP id b5-20020aa781050000b029018ec8d92c24mr8740020pfi.49.1607182800915; Sat, 05 Dec 2020 07:40:00 -0800 (PST) MIME-Version: 1.0 References: <20201205130224.81607-1-songmuchun@bytedance.com> <20201205130224.81607-6-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Sat, 5 Dec 2020 23:39:24 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 5/9] mm: memcontrol: convert NR_FILE_THPS account to pages To: Greg KH Cc: rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Will Deacon , Roman Gushchin , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 5, 2020 at 11:32 PM Greg KH wrote: > > On Sat, Dec 05, 2020 at 11:29:26PM +0800, Muchun Song wrote: > > On Sat, Dec 5, 2020 at 10:09 PM Greg KH wrote: > > > > > > On Sat, Dec 05, 2020 at 09:02:20PM +0800, Muchun Song wrote: > > > > Converrt NR_FILE_THPS account to pages. > > > > > > > > Signed-off-by: Muchun Song > > > > --- > > > > drivers/base/node.c | 3 +-- > > > > fs/proc/meminfo.c | 2 +- > > > > mm/filemap.c | 2 +- > > > > mm/huge_memory.c | 3 ++- > > > > mm/khugepaged.c | 2 +- > > > > mm/memcontrol.c | 5 ++--- > > > > 6 files changed, 8 insertions(+), 9 deletions(-) > > > > > > > > diff --git a/drivers/base/node.c b/drivers/base/node.c > > > > index 05c369e93e16..f6a9521bbcf8 100644 > > > > --- a/drivers/base/node.c > > > > +++ b/drivers/base/node.c > > > > @@ -466,8 +466,7 @@ static ssize_t node_read_meminfo(struct device *dev, > > > > HPAGE_PMD_NR), > > > > nid, K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) * > > > > HPAGE_PMD_NR), > > > > - nid, K(node_page_state(pgdat, NR_FILE_THPS) * > > > > - HPAGE_PMD_NR), > > > > + nid, K(node_page_state(pgdat, NR_FILE_THPS)), > > > > > > Again, is this changing a user-visable value? > > > > > > > Of course not. > > > > In the previous, the NR_FILE_THPS account is like below: > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, 1); > > > > With this patch, it is: > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, HPAGE_PMD_NR); > > > > So the result is not changed from the view of user space. > > So you "broke" it on the previous patch and "fixed" it on this one? Why > not just do it all in one patch? Sorry for the confusion. I mean that the "previous" is without all of this patch series. So this series is aimed to convert the unit of all different THP vmstat counters from HPAGE_PMD_NR to pages. Thanks. > > Confused, > > greg k-h -- Yours, Muchun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muchun Song Subject: Re: [External] Re: [PATCH 5/9] mm: memcontrol: convert NR_FILE_THPS account to pages Date: Sat, 5 Dec 2020 23:39:24 +0800 Message-ID: References: <20201205130224.81607-1-songmuchun@bytedance.com> <20201205130224.81607-6-songmuchun@bytedance.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/IX944X6oZl2Mzi0wZiZDHD4FwyqaIDsig5F+iiEk9k=; b=opakRlC7cQn4ZWwCZOV7BpaskunmVBhmP/y6bDVxwQnEDw1HsXsTmG7UqEkeEanTg7 4yFQRNbstV/rae16oZ8vMyaC/8FhDJVXsSrhYShQimL2K7yAKNUxfy/V5FTqN4k8WFDC HKSOX5OcgbHSM/Vy8sTi8tPSzCzCURVaS1dkTfItKp5ZblNX6yRd3ajWqemrx/OUiPww jWOgbzl8EX/PJP/RUCYMYZQkuKqdQLRPeO49D6iT6kmEEVhHDm8XFwA9PhfZfQqZ+eQT nylPadt5IjBaQkx5n0qHVvuB5FfBdP/8dyJOMeY84V9ekjWUn02WrC0cCQ3aXLas8gvC DItQ== In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg KH Cc: rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Will Deacon , Roman Gushchin , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups On Sat, Dec 5, 2020 at 11:32 PM Greg KH wrote: > > On Sat, Dec 05, 2020 at 11:29:26PM +0800, Muchun Song wrote: > > On Sat, Dec 5, 2020 at 10:09 PM Greg KH wrote: > > > > > > On Sat, Dec 05, 2020 at 09:02:20PM +0800, Muchun Song wrote: > > > > Converrt NR_FILE_THPS account to pages. > > > > > > > > Signed-off-by: Muchun Song > > > > --- > > > > drivers/base/node.c | 3 +-- > > > > fs/proc/meminfo.c | 2 +- > > > > mm/filemap.c | 2 +- > > > > mm/huge_memory.c | 3 ++- > > > > mm/khugepaged.c | 2 +- > > > > mm/memcontrol.c | 5 ++--- > > > > 6 files changed, 8 insertions(+), 9 deletions(-) > > > > > > > > diff --git a/drivers/base/node.c b/drivers/base/node.c > > > > index 05c369e93e16..f6a9521bbcf8 100644 > > > > --- a/drivers/base/node.c > > > > +++ b/drivers/base/node.c > > > > @@ -466,8 +466,7 @@ static ssize_t node_read_meminfo(struct device *dev, > > > > HPAGE_PMD_NR), > > > > nid, K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) * > > > > HPAGE_PMD_NR), > > > > - nid, K(node_page_state(pgdat, NR_FILE_THPS) * > > > > - HPAGE_PMD_NR), > > > > + nid, K(node_page_state(pgdat, NR_FILE_THPS)), > > > > > > Again, is this changing a user-visable value? > > > > > > > Of course not. > > > > In the previous, the NR_FILE_THPS account is like below: > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, 1); > > > > With this patch, it is: > > > > __mod_lruvec_page_state(page, NR_FILE_THPS, HPAGE_PMD_NR); > > > > So the result is not changed from the view of user space. > > So you "broke" it on the previous patch and "fixed" it on this one? Why > not just do it all in one patch? Sorry for the confusion. I mean that the "previous" is without all of this patch series. So this series is aimed to convert the unit of all different THP vmstat counters from HPAGE_PMD_NR to pages. Thanks. > > Confused, > > greg k-h -- Yours, Muchun