From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32373C4332F for ; Wed, 15 Sep 2021 07:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B16761212 for ; Wed, 15 Sep 2021 07:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236673AbhIOHcK (ORCPT ); Wed, 15 Sep 2021 03:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232034AbhIOHcJ (ORCPT ); Wed, 15 Sep 2021 03:32:09 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB0BBC061574 for ; Wed, 15 Sep 2021 00:30:50 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id g184so1837047pgc.6 for ; Wed, 15 Sep 2021 00:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ansDI2ALwiWUvo/BHMzSUNbG1zi7g1Z2RW2yT9Z/nQU=; b=ORu8quCr4ulyj8peI8bv8LIWYdxUyRLHamjFT4YgcAyCXXSJdSEDIA5RUxfAmRN09J tY/7T5bYctY95S7e+fwttxX+NNE5jGnbTpmByrsUudiTX9yWUMLlenKQBt/TixdSRPsZ LrlLHUqNy1XM3U3BySYeH/YSkyih1AlxBf3CpwC7vZvdDR4Blb2RYh6a1Bq9HCVhkR1+ E0XG1SnRFmOSibxEc1rd4fVF8VCvFA6y+XiaAfVwVYGGx/EljBv00XVcINk3zbgbFI37 Na9ZrjmuFHRhntxtlqxBJbwI9WZHCcDwJ5mTZqO8dkI54BjWnhGuTajMW1ZdHWDAO0jc U2mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ansDI2ALwiWUvo/BHMzSUNbG1zi7g1Z2RW2yT9Z/nQU=; b=oRQedRyhgdJZ7EFNyRjN01adTM3EbS8mDpqO7P/N9Y59L6Hq1bITNrcrR5Kc4Gj+nE oV/QRvDZ4NFXqqLJ1aNqoVb+JV3y0rrIdRtJdyGUykng7+DZoJ8ZfzanXEFCirXuBGJm aIAmyAFL1ndt8M3TRCoz6jO3KYyrLa6XWEkUxhZpKiyQ5fVqQW3G+/QaeVjS5/VTr2YZ 6gbiDzr33GGp9LwD4yITFYeK0yodrFCscpM8Q9UQKqeK5yZvIv/vcwpUwuzZlHCtFOLc kDbTzFjSAlOmTBVHITB5oMPsGAsacjYobYPz6sQMtF2/AWHyBDZ94vN0LPDbGRarR3Hv RlDw== X-Gm-Message-State: AOAM531eEj2eigDDIp4xlzX9TwL6M4nsW4U+Y3dg6s7IH1sUCR6n/T/4 fjHxRgU5rmigAJNarwP8k1elmyjXbavDNrEAvRzLqA== X-Google-Smtp-Source: ABdhPJyPhEr+fuMcqTX6W8kA2CYRATLI7X4XWaSCGHZXRVAs1Jug54iwzt8yUmfw+4OuE3ywJoZ1ZLM++dY2ReITCo4= X-Received: by 2002:aa7:9e8d:0:b0:406:be8:2413 with SMTP id p13-20020aa79e8d000000b004060be82413mr9157759pfq.66.1631691049890; Wed, 15 Sep 2021 00:30:49 -0700 (PDT) MIME-Version: 1.0 References: <20210914072938.6440-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Wed, 15 Sep 2021 15:30:12 +0800 Message-ID: Subject: Re: [PATCH v3 00/76] Optimize list lru memory consumption To: "Theodore Ts'o" Cc: Matthew Wilcox , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Shakeel Butt , Roman Gushchin , Yang Shi , Alex Shi , Wei Yang , Dave Chinner , trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, linux-fsdevel , LKML , Linux Memory Management List , linux-nfs@vger.kernel.org, Qi Zheng , Xiongchun duan , fam.zheng@bytedance.com, Muchun Song Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 15, 2021 at 4:23 AM Theodore Ts'o wrote: > > On Tue, Sep 14, 2021 at 03:28:22PM +0800, Muchun Song wrote: > > So we have to convert to new API for all filesystems, which is done in > > one patch. Some filesystems are easy to convert (just replace > > kmem_cache_alloc() to alloc_inode_sb()), while other filesystems need to > > do more work. > > From what I can tell, three are 54 file systems for which it was a > trivial one-line change, and two (f2fs and nfs42) that were a tad bit > more complex. Definitely right. Thanks for your clarification. > > > In order to make it easy for maintainers of different > > filesystems to review their own maintained part, I split the patch into > > patches which are per-filesystem in this version. I am not sure if this > > is a good idea, because there is going to be more commits. > > What I'd actually suggest is that you combine all of the trivial file > system changes into a single commit, and keep the two more complex > changes for f2fs and nfs42 in separate commits. Got it. Will do in the next version. > > Acked-by: Theodore Ts'o Thanks. > > ... for the ext4 related change. > > - Ted > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C3CC433EF for ; Wed, 15 Sep 2021 08:50:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D89560527 for ; Wed, 15 Sep 2021 08:50:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D89560527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4ED8E6B0073; Wed, 15 Sep 2021 04:50:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4742E6B0074; Wed, 15 Sep 2021 04:50:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EE7F900002; Wed, 15 Sep 2021 04:50:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 007C56B0074 for ; Wed, 15 Sep 2021 04:50:03 -0400 (EDT) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve05.hostedemail.com (Postfix) with ESMTP id 7C7AE1817905F for ; Wed, 15 Sep 2021 07:31:03 +0000 (UTC) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5219829E11 for ; Wed, 15 Sep 2021 07:30:53 +0000 (UTC) X-FDA: 78588985986.40.DF90D9F Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf12.hostedemail.com (Postfix) with ESMTP id 2EC6410000A3 for ; Wed, 15 Sep 2021 07:30:52 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id b7so1830498pfo.11 for ; Wed, 15 Sep 2021 00:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ansDI2ALwiWUvo/BHMzSUNbG1zi7g1Z2RW2yT9Z/nQU=; b=ORu8quCr4ulyj8peI8bv8LIWYdxUyRLHamjFT4YgcAyCXXSJdSEDIA5RUxfAmRN09J tY/7T5bYctY95S7e+fwttxX+NNE5jGnbTpmByrsUudiTX9yWUMLlenKQBt/TixdSRPsZ LrlLHUqNy1XM3U3BySYeH/YSkyih1AlxBf3CpwC7vZvdDR4Blb2RYh6a1Bq9HCVhkR1+ E0XG1SnRFmOSibxEc1rd4fVF8VCvFA6y+XiaAfVwVYGGx/EljBv00XVcINk3zbgbFI37 Na9ZrjmuFHRhntxtlqxBJbwI9WZHCcDwJ5mTZqO8dkI54BjWnhGuTajMW1ZdHWDAO0jc U2mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ansDI2ALwiWUvo/BHMzSUNbG1zi7g1Z2RW2yT9Z/nQU=; b=yYjhxVBRLJNwpyxWByMFdhGuaUJHswntxsuLGEsFXGhiW7PWztfGtkz4aIRfP5R6J6 s+fsXmmmbfl3+58LLEMuATvdFbggXXjKnPaVeUeGliLcfoHfUtpDEJeZ44KP1nL57MpX BpbQtzxdCNt0JveTHek7Xd3jvwdkqTf5u4rh6T0xLhGy1Yjg1cv7gMgFhq73ZDzMtUlD DNdWtDxxuZskujJs/IAlAiUb6jrYlaJnNHe1C8m61MCNAGtfZEoUFKJg2k19CO3djkCZ ZerHzv6P1o4tHYcd9WeoYjmiGal5diRJZFX5TtQy7vE4ySQlGvsUr2Sa6r3HuyiwsCSG 5AUg== X-Gm-Message-State: AOAM530NqK11scJGEixt+53RrG+YUNksA294eFFpZlVFPdjz6AuKmMua exkz4DDi2IcI4c92AgtCjH4UGJs53/WDjvVxwfOWeA== X-Google-Smtp-Source: ABdhPJyPhEr+fuMcqTX6W8kA2CYRATLI7X4XWaSCGHZXRVAs1Jug54iwzt8yUmfw+4OuE3ywJoZ1ZLM++dY2ReITCo4= X-Received: by 2002:aa7:9e8d:0:b0:406:be8:2413 with SMTP id p13-20020aa79e8d000000b004060be82413mr9157759pfq.66.1631691049890; Wed, 15 Sep 2021 00:30:49 -0700 (PDT) MIME-Version: 1.0 References: <20210914072938.6440-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Wed, 15 Sep 2021 15:30:12 +0800 Message-ID: Subject: Re: [PATCH v3 00/76] Optimize list lru memory consumption To: "Theodore Ts'o" Cc: Matthew Wilcox , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Shakeel Butt , Roman Gushchin , Yang Shi , Alex Shi , Wei Yang , Dave Chinner , trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, linux-fsdevel , LKML , Linux Memory Management List , linux-nfs@vger.kernel.org, Qi Zheng , Xiongchun duan , fam.zheng@bytedance.com, Muchun Song Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2EC6410000A3 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=ORu8quCr; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf12.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: hkz37n9q7i48wp4smqgbdzjujt1qzs94 X-HE-Tag: 1631691052-351772 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 15, 2021 at 4:23 AM Theodore Ts'o wrote: > > On Tue, Sep 14, 2021 at 03:28:22PM +0800, Muchun Song wrote: > > So we have to convert to new API for all filesystems, which is done in > > one patch. Some filesystems are easy to convert (just replace > > kmem_cache_alloc() to alloc_inode_sb()), while other filesystems need to > > do more work. > > From what I can tell, three are 54 file systems for which it was a > trivial one-line change, and two (f2fs and nfs42) that were a tad bit > more complex. Definitely right. Thanks for your clarification. > > > In order to make it easy for maintainers of different > > filesystems to review their own maintained part, I split the patch into > > patches which are per-filesystem in this version. I am not sure if this > > is a good idea, because there is going to be more commits. > > What I'd actually suggest is that you combine all of the trivial file > system changes into a single commit, and keep the two more complex > changes for f2fs and nfs42 in separate commits. Got it. Will do in the next version. > > Acked-by: Theodore Ts'o Thanks. > > ... for the ext4 related change. > > - Ted >