From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E42C433ED for ; Mon, 26 Apr 2021 07:57:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B66C36105A for ; Mon, 26 Apr 2021 07:57:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234115AbhDZH6T (ORCPT ); Mon, 26 Apr 2021 03:58:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236421AbhDZHzc (ORCPT ); Mon, 26 Apr 2021 03:55:32 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 815E4C06137C for ; Mon, 26 Apr 2021 00:50:23 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id w20so644056pge.13 for ; Mon, 26 Apr 2021 00:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RSEb31wWGXReNK5o1Di9EAbb2yv22MfNR6i10yaB7II=; b=PQxAdZTfhtse3v51/fpEXILWWJLtz6AG6B2+uB8ETdn/kSfgtv4lDD8RvF8GiMMbUH NHwRDvFWJbTxPb9Psw37146jJrm8C6XqUkXbW8okYLqwhAUfZNuVeAzSKSDro2CsmUDL QYERjj6jR/qZw3SCnrPrWOSJMjbqvpbb8TpM9z1SKsrThc2f8rHQKZqBuJlOIaN/EC2B OF0pXfqL+Z+dAp0bFlscJgkLWyN4L3gK7pZSFEkR5WncRVeW18u/Z+xoiWzOJ9roqj8j KvPKvzNTncI1ApZIB49Z6umz1KLUj1DXhAmVS2RdkmQY9vx6tKn45bImHjczbARZexaz +2gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RSEb31wWGXReNK5o1Di9EAbb2yv22MfNR6i10yaB7II=; b=lr6gJjxCHoALUIA4TiVPk3l1uY6vNNEFwFkPkRSy8YktCdLJXj5ut7ys7d+6zfCw2j GEuD/MBf9Q2yngiI9DJsUtRtg9au+gNI4WGaj6ZPFXWCHp+tZv4JVaF2oRuHEwXPNKe2 Mc+hIiH2clsSh/86iRyH0mxQW1hCOJ8ABF7gJd6TCzrvU2gQ6sAWenLOQx8cLtBY3+JU WH8UujEDz3IOVKmJbH1euynCFGTRyBdQEzcMOnyK2Ph0HIRh/23Q7o2KY7CE6E+Aj2op rn4QOmjGRS7ol1vUI3oZwEPvmoUagwfr8sAakTQqJ66imveduuNTPcabo2TTVTjNK/7v bW3w== X-Gm-Message-State: AOAM533TyTKfdHAVhdNhhm3tk0ZVWuzuPybwAnybzOdL1ocisVW6qQYa dv8K520oS6ouhNKWouzRVK/pgVZc8Ee2jbClG6Evow== X-Google-Smtp-Source: ABdhPJyUTsrpL/aAnkNFZ4s16Wdt/xjloo9acRdtHc7o2IokHZP3Sz/w5/RveaSLf7PObJIL3QGraE1I2lb5GKtIfEk= X-Received: by 2002:a63:f07:: with SMTP id e7mr16003525pgl.341.1619423423083; Mon, 26 Apr 2021 00:50:23 -0700 (PDT) MIME-Version: 1.0 References: <20210417043538.9793-1-songmuchun@bytedance.com> In-Reply-To: <20210417043538.9793-1-songmuchun@bytedance.com> From: Muchun Song Date: Mon, 26 Apr 2021 15:49:47 +0800 Message-ID: Subject: Re: [PATCH v3 0/8] memcontrol code cleanup and simplification To: Andrew Morton Cc: LKML , Shakeel Butt , Vladimir Davydov , Johannes Weiner , Linux Memory Management List , Xiongchun duan , Michal Hocko , Roman Gushchin Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 17, 2021 at 12:37 PM Muchun Song wrote: > > This patch series is part of [1] patch series. Because those patches are > code cleanup or simplification. I gather those patches into a separate > series to make it easier to review. > > [1] https://lore.kernel.org/linux-mm/20210409122959.82264-1-songmuchun@bytedance.com/ > Hi Andrew, Since all the patches in this series have at least three Acked-by/Reviewed-by tags, I think that it is ready to merge this to mm-tree. Maybe you forgot this. So this is a reminder. :-) Thanks. > Changlogs in v3: > 1. Collect Acked-by and Review-by tags. > 2. Add a comment to patch 5 (suggested by Johannes). > > Thanks to Johannes, Shakeel and Michal's review. > > Changlogs in v2: > 1. Collect Acked-by and Review-by tags. > 2. Add a new patch to rename lruvec_holds_page_lru_lock to page_matches_lruvec. > 3. Add a comment to patch 2. > > Thanks to Roman, Johannes, Shakeel and Michal's review. > > Muchun Song (8): > mm: memcontrol: fix page charging in page replacement > mm: memcontrol: bail out early when !mm in get_mem_cgroup_from_mm > mm: memcontrol: remove the pgdata parameter of mem_cgroup_page_lruvec > mm: memcontrol: simplify lruvec_holds_page_lru_lock > mm: memcontrol: rename lruvec_holds_page_lru_lock to > page_matches_lruvec > mm: memcontrol: simplify the logic of objcg pinning memcg > mm: memcontrol: move obj_cgroup_uncharge_pages() out of css_set_lock > mm: vmscan: remove noinline_for_stack > > include/linux/memcontrol.h | 43 ++++++++++-------------------- > mm/compaction.c | 2 +- > mm/memcontrol.c | 65 +++++++++++++++++++++------------------------- > mm/swap.c | 2 +- > mm/vmscan.c | 8 +++--- > mm/workingset.c | 2 +- > 6 files changed, 50 insertions(+), 72 deletions(-) > > -- > 2.11.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123CDC433B4 for ; Mon, 26 Apr 2021 07:50:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 594D26023B for ; Mon, 26 Apr 2021 07:50:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 594D26023B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E1CD6B006C; Mon, 26 Apr 2021 03:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9928C6B006E; Mon, 26 Apr 2021 03:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80C006B0070; Mon, 26 Apr 2021 03:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 6135A6B006C for ; Mon, 26 Apr 2021 03:50:26 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0F690824999B for ; Mon, 26 Apr 2021 07:50:26 +0000 (UTC) X-FDA: 78073745652.05.72FEB8B Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 7C6B040002D9 for ; Mon, 26 Apr 2021 07:49:55 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id m12so18802794pgr.9 for ; Mon, 26 Apr 2021 00:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RSEb31wWGXReNK5o1Di9EAbb2yv22MfNR6i10yaB7II=; b=PQxAdZTfhtse3v51/fpEXILWWJLtz6AG6B2+uB8ETdn/kSfgtv4lDD8RvF8GiMMbUH NHwRDvFWJbTxPb9Psw37146jJrm8C6XqUkXbW8okYLqwhAUfZNuVeAzSKSDro2CsmUDL QYERjj6jR/qZw3SCnrPrWOSJMjbqvpbb8TpM9z1SKsrThc2f8rHQKZqBuJlOIaN/EC2B OF0pXfqL+Z+dAp0bFlscJgkLWyN4L3gK7pZSFEkR5WncRVeW18u/Z+xoiWzOJ9roqj8j KvPKvzNTncI1ApZIB49Z6umz1KLUj1DXhAmVS2RdkmQY9vx6tKn45bImHjczbARZexaz +2gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RSEb31wWGXReNK5o1Di9EAbb2yv22MfNR6i10yaB7II=; b=dAM+JklZ9Uy/av2GLmvqH0vNiHz6vY07SNpqFgTFLx1sQ3MNPW+3Vuk+MkmBA0UVLr tGCpFMKsKxAyK9vkWDWEy89vzTVxQiQCQUo1aKRtjHr3NsiSMR6YT84ZTLhGfD+qAm6u eBu8D/0x+O/oz/SrwVGQ1YJhW3OWvnaDvm1BHJj5cx1+N0SKAlwEoaIoUIpgNIc1c/F9 qS8hwCF/vI4DIgYkJazdZ3nt8+8Lddto/p15pBCKAw5dv4POmwujW+mLOwbKFxwn+I39 6ch9h9VS1kWdciVfKf9cpPSN30LepW9J97GqPnBUfrDRt1poaNELbYOH+EWK5CBGzofM HpeA== X-Gm-Message-State: AOAM5301hH7bllPVj3BIq1YOpqPrQLmeK3hs+vNtc7HDRp9U7zNAXeMW qEaOtKFb9nWAAiYpXKFCGK0UBKUfI+xuRdiQF2BHgw== X-Google-Smtp-Source: ABdhPJyUTsrpL/aAnkNFZ4s16Wdt/xjloo9acRdtHc7o2IokHZP3Sz/w5/RveaSLf7PObJIL3QGraE1I2lb5GKtIfEk= X-Received: by 2002:a63:f07:: with SMTP id e7mr16003525pgl.341.1619423423083; Mon, 26 Apr 2021 00:50:23 -0700 (PDT) MIME-Version: 1.0 References: <20210417043538.9793-1-songmuchun@bytedance.com> In-Reply-To: <20210417043538.9793-1-songmuchun@bytedance.com> From: Muchun Song Date: Mon, 26 Apr 2021 15:49:47 +0800 Message-ID: Subject: Re: [PATCH v3 0/8] memcontrol code cleanup and simplification To: Andrew Morton Cc: LKML , Shakeel Butt , Vladimir Davydov , Johannes Weiner , Linux Memory Management List , Xiongchun duan , Michal Hocko , Roman Gushchin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7C6B040002D9 X-Stat-Signature: 5t45ypm1hg5r73kx9c6yds7oru1mt7mw Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mail-pg1-f172.google.com; client-ip=209.85.215.172 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619423395-246796 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 17, 2021 at 12:37 PM Muchun Song wrote: > > This patch series is part of [1] patch series. Because those patches are > code cleanup or simplification. I gather those patches into a separate > series to make it easier to review. > > [1] https://lore.kernel.org/linux-mm/20210409122959.82264-1-songmuchun@bytedance.com/ > Hi Andrew, Since all the patches in this series have at least three Acked-by/Reviewed-by tags, I think that it is ready to merge this to mm-tree. Maybe you forgot this. So this is a reminder. :-) Thanks. > Changlogs in v3: > 1. Collect Acked-by and Review-by tags. > 2. Add a comment to patch 5 (suggested by Johannes). > > Thanks to Johannes, Shakeel and Michal's review. > > Changlogs in v2: > 1. Collect Acked-by and Review-by tags. > 2. Add a new patch to rename lruvec_holds_page_lru_lock to page_matches_lruvec. > 3. Add a comment to patch 2. > > Thanks to Roman, Johannes, Shakeel and Michal's review. > > Muchun Song (8): > mm: memcontrol: fix page charging in page replacement > mm: memcontrol: bail out early when !mm in get_mem_cgroup_from_mm > mm: memcontrol: remove the pgdata parameter of mem_cgroup_page_lruvec > mm: memcontrol: simplify lruvec_holds_page_lru_lock > mm: memcontrol: rename lruvec_holds_page_lru_lock to > page_matches_lruvec > mm: memcontrol: simplify the logic of objcg pinning memcg > mm: memcontrol: move obj_cgroup_uncharge_pages() out of css_set_lock > mm: vmscan: remove noinline_for_stack > > include/linux/memcontrol.h | 43 ++++++++++-------------------- > mm/compaction.c | 2 +- > mm/memcontrol.c | 65 +++++++++++++++++++++------------------------- > mm/swap.c | 2 +- > mm/vmscan.c | 8 +++--- > mm/workingset.c | 2 +- > 6 files changed, 50 insertions(+), 72 deletions(-) > > -- > 2.11.0 >