All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Yuchung Cheng <ycheng@google.com>,
	Neal Cardwell <ncardwell@google.com>
Subject: Re: [Patch net-next 0/3] tcp: decouple TLP timer from RTO timer
Date: Mon, 28 Oct 2019 13:13:06 -0700	[thread overview]
Message-ID: <CAM_iQpU1oG8J9Nf-nZoZDf3wO9c4dHAaa0=HK0X-QMeHMtmrCQ@mail.gmail.com> (raw)
In-Reply-To: <CANn89iKeB9+6xAyjQUZvtX3ioLNs3sBwCDq0QxmYEy5X_nF+LA@mail.gmail.com>

On Mon, Oct 28, 2019 at 11:34 AM Eric Dumazet <edumazet@google.com> wrote:
>
> On Mon, Oct 28, 2019 at 11:29 AM David Miller <davem@davemloft.net> wrote:
> >
> > From: Cong Wang <xiyou.wangcong@gmail.com>
> > Date: Tue, 22 Oct 2019 16:10:48 -0700
> >
> > > This patchset contains 3 patches: patch 1 is a cleanup,
> > > patch 2 is a small change preparing for patch 3, patch 3 is the
> > > one does the actual change. Please find details in each of them.
> >
> > Eric, have you had a chance to test this on a system with
> > suitable CPU arity?
>
> Yes, and I confirm I could not repro the issues at all.
>
> I got a 100Gbit NIC, trying to increase the pressure a bit, and
> driving this NIC at line rate was only using 2% of my 96 cpus host,
> no spinlock contention of any sort.

Please let me know if there is anything else I can provide to help
you to make the decision.

All I can say so far is this only happens on our hosts with 128
AMD CPU's. I don't see anything here related to AMD, so I think
only the number of CPU's (vs. number of TX queues?) matters.

Thanks.

  reply	other threads:[~2019-10-28 20:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22 23:10 [Patch net-next 0/3] tcp: decouple TLP timer from RTO timer Cong Wang
2019-10-22 23:10 ` [Patch net-next 1/3] tcp: get rid of ICSK_TIME_EARLY_RETRANS Cong Wang
2019-10-22 23:10 ` [Patch net-next 2/3] tcp: make tcp_send_loss_probe() boolean Cong Wang
2019-10-22 23:10 ` [Patch net-next 3/3] tcp: decouple TLP timer from RTO timer Cong Wang
2019-10-22 23:24   ` Eric Dumazet
2019-10-23  1:10     ` Cong Wang
2019-10-23  2:15       ` Eric Dumazet
2019-10-23 17:40         ` Cong Wang
2019-10-23 18:14           ` Eric Dumazet
2019-10-23 18:30             ` Cong Wang
2019-10-23 18:55               ` Eric Dumazet
2019-10-28 18:29 ` [Patch net-next 0/3] " David Miller
2019-10-28 18:34   ` Eric Dumazet
2019-10-28 20:13     ` Cong Wang [this message]
2019-10-28 20:31       ` Eric Dumazet
2019-10-29  0:49         ` Cong Wang
2019-10-30 21:56 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpU1oG8J9Nf-nZoZDf3wO9c4dHAaa0=HK0X-QMeHMtmrCQ@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.