From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B657C282C0 for ; Wed, 23 Jan 2019 06:58:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D977920870 for ; Wed, 23 Jan 2019 06:58:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QbTLEXcZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726175AbfAWG61 (ORCPT ); Wed, 23 Jan 2019 01:58:27 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:44520 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfAWG61 (ORCPT ); Wed, 23 Jan 2019 01:58:27 -0500 Received: by mail-pf1-f195.google.com with SMTP id u6so682504pfh.11 for ; Tue, 22 Jan 2019 22:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e7d30iL/TLhpZgnINPJDnT2LP8ZwPrCIDUiiHyi1AwE=; b=QbTLEXcZy1nxxiX8gj0f8WO6fkqvQN3wyL5hmJOjBvjjeota3m6rrT8llYlEclMg7u CGpu4nBikIhX4B2XxnhOwJzorRkIHxRjJDsm2WOhxmq3xTDLeWnt81ivsfWkh2v2ncy9 L+KIe/BsYOTuJJ+SjWCS1VXuDuynQTaZlN3X7Z39JP0vZh1l9l481XfZEpHH5P8jZTXY AEL7kLAgyA7jpqsPxkom15lrVyn6hAu3zLuE1ag1HlWBY01wV/k1EY/QtGRdQm8mqyON +mbrvALSkZAWPblcWSKJWfz/4hA/9VRJTP8pu9Y828Zag5O0uu6+6ekLYcomkFBKs++H iuiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e7d30iL/TLhpZgnINPJDnT2LP8ZwPrCIDUiiHyi1AwE=; b=A2ln8fpr3C4bt941vv9COxM2QrBszhn9wtChh5au6fRYMPA4PvAiVpd2+dkKvw6+Nn AQV9jEBu4QwPzKJQ2UGK3cKNdJkznXxMg2NdvdaeW00BZ2CgIuSHe6zaGUUteSyPhBmN 5mzSUnoOm9b2GhUhf4lHqnWBKRnVvT7nIoqOuxp6bxMQvNi7ER3PX7ctTsqXo3RSVyLF NRjM+JmYpZtpBBuXT+pwPWbTV61koniTQvELV4Qm4PUl27MjSFF9KYkzjCUbO6Fu5pic SS7HnUkbCrd2jTiVlh5NbNB17UbnT01TkNwtZ+46OLFIo+qVxemEhH7+ca9vldtWdAdE LKkg== X-Gm-Message-State: AJcUukdpf+ZSOM4QZrIiXXIsZJaXJ4LXaeCnLee3NKVZp3Pc+zRKmbkv a+ne6342kXNlioZz0kzzCqi5+LkKKzhfwWdBJSA= X-Google-Smtp-Source: ALg8bN7VBh+HorHK5XkWqW5WcgX0h476DmV1Cry4HPvH3uTS4kS1CLaL/LzHaFUFj2pD/HH0nLl8XpvBnBBSUnP6ueM= X-Received: by 2002:a65:4381:: with SMTP id m1mr971294pgp.358.1548226706510; Tue, 22 Jan 2019 22:58:26 -0800 (PST) MIME-Version: 1.0 References: <20190117081847.7791-1-yupeng0921@gmail.com> In-Reply-To: From: Cong Wang Date: Tue, 22 Jan 2019 22:58:13 -0800 Message-ID: Subject: Re: [PATCH net-next] remove TWKilled counter To: peng yu Cc: Linux Kernel Network Developers , David Miller , Alexey Kuznetsov , Hideaki YOSHIFUJI Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 21, 2019 at 3:14 PM peng yu wrote: > > Hello, I think the snmp.h didn't try to keep user-space compatibility, > so we could delete LINUX_MIB_TIMEWAITKILLED counter. Do I > misunderstand anything? I don't know. Maybe user-space doesn't need these definitions at all, as like nstat can figure out the values from /proc/net/netstat. It looks like we either could just kill snmp.h or we have to keep it for backward compatibility.