From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch iproute2] u32: add terminal parameter Date: Fri, 11 Apr 2014 18:15:19 -0700 Message-ID: References: <1396631826-15188-1-git-send-email-xiyou.wangcong@gmail.com> <20140411140446.6412e9dc@nehalam.linuxnetplumber.net> <20140411175800.08e9ffe3@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Linux Kernel Network Developers , David Miller To: Stephen Hemminger Return-path: Received: from mail-oa0-f48.google.com ([209.85.219.48]:64476 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755343AbaDLBPU (ORCPT ); Fri, 11 Apr 2014 21:15:20 -0400 Received: by mail-oa0-f48.google.com with SMTP id m1so6925954oag.7 for ; Fri, 11 Apr 2014 18:15:19 -0700 (PDT) In-Reply-To: <20140411175800.08e9ffe3@nehalam.linuxnetplumber.net> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Apr 11, 2014 at 5:58 PM, Stephen Hemminger wrote: > On Fri, 11 Apr 2014 17:45:53 -0700 > Cong Wang wrote: >> It's already there: >> >> } else if (sel && sel->flags&TC_U32_TERMINAL) { >> fprintf(f, "terminal flowid ??? "); >> } > > But it printing it like an error, not an known good option. > The ??? implies that somebody did something wrong. I don't know why ??? is displayed together with terminal, but nothing seems wrong here, check the output after I add a mirred action: filter protocol ip pref 49152 u32 filter protocol ip pref 49152 u32 fh 800: ht divisor 1 filter protocol ip pref 49152 u32 fh 800::800 order 2048 key ht 800 bkt 0 terminal flowid ??? match 01020304/ffffffff at 16 action order 1: mirred (Egress Mirror to device virbr0) pipe index 1 ref 1 bind 1