All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>
Subject: Re: [Patch net] mlx5: fixup checksum for ethernet padding
Date: Tue, 27 Nov 2018 17:38:32 -0800	[thread overview]
Message-ID: <CAM_iQpULYbELBO+81WWM7_HR=tqLzd9V161q5p0y68MCp0vqYg@mail.gmail.com> (raw)
In-Reply-To: <0d9c022b4b00c2ed0e0af9bdb14ad7e53703872f.camel@mellanox.com>

On Tue, Nov 27, 2018 at 5:11 PM Saeed Mahameed <saeedm@mellanox.com> wrote:
>
> On Tue, 2018-11-27 at 16:07 -0800, Cong Wang wrote:
> > On Tue, Nov 27, 2018 at 3:48 PM Eric Dumazet <eric.dumazet@gmail.com>
> > wrote:
> > > The bug here is that mlx5 csum only includes the data in IP frame.
> > >
> > > I would simply force skb->ip_summed to CHECKSUM_NONE if any padding
> > > is detected.
> > >
>
> Totally agree, let's just skip csum completes for very small packets
> ( < ETH_ZLEN ).

That is my first idea in my mind, but you know we still have to parse IP header
to detect packets < ETH_ZLEN. Essentially same work, only saves a few adds
in csum_add(). ;)

  reply	other threads:[~2018-11-28 12:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27 23:21 [Patch net] mlx5: fixup checksum for ethernet padding Cong Wang
2018-11-27 23:23 ` Cong Wang
2018-11-27 23:48 ` Eric Dumazet
2018-11-28  0:07   ` Cong Wang
2018-11-28  1:11     ` Saeed Mahameed
2018-11-28  1:38       ` Cong Wang [this message]
2018-11-28  1:25     ` Eric Dumazet
2018-11-28  1:42       ` Cong Wang
2018-11-28  1:48         ` Eric Dumazet
2018-11-28  1:52           ` Cong Wang
2018-11-29 21:51 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpULYbELBO+81WWM7_HR=tqLzd9V161q5p0y68MCp0vqYg@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.