All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Davide Caratti <dcaratti@redhat.com>,
	Hangbin Liu <liuhangbin@gmail.com>, Jiri Pirko <jiri@resnulli.us>,
	Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH net 1/2] net: sched: drop ct for the packets toward ingress only in act_mirred
Date: Tue, 21 Sep 2021 20:43:18 -0700	[thread overview]
Message-ID: <CAM_iQpULkRxRjMBWKn+7V51PZXLWW17iQBLr1N5vdJmFVZtJ4A@mail.gmail.com> (raw)
In-Reply-To: <CADvbK_dSw=H-pVK26tMwpdfkjd3dKGcCrATaRvXqzRwJFoKoyg@mail.gmail.com>

On Tue, Sep 21, 2021 at 12:02 AM Xin Long <lucien.xin@gmail.com> wrote:
>
> On Tue, Sep 21, 2021 at 2:31 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
> > On Mon, Sep 20, 2021 at 7:12 AM Xin Long <lucien.xin@gmail.com> wrote:
> > >
> > > nf_reset_ct() called in tcf_mirred_act() is supposed to drop ct for
> > > those packets that are mirred or redirected to only ingress, not
> > > ingress and egress.
> >
> > Any reason behind this? I think we at least need to reset it when
> > redirecting from ingress to egress as well? That is, when changing
> > directions?
> For the reason why ct should be reset, it's said in
> d09c548dbf3b ("net: sched: act_mirred: Reset ct info when mirror").
> The user case is OVS HWOL using TC to do NAT and then redirecting
> the NATed skb back to the ingress of one local dev, it's ingress only, this
> patch is more like to minimize the side effect of d09c548dbf3b IF there is.

What is the side effect here? Or what is wrong with resetting CT on
egress side?

>
> Not sure if it's too much to do for that from ingress to egress.
> What I was thinking is this should happen on rx path(ingress), like it
> does in internal_dev_recv() in the OVS kernel module. But IF there is
> any user case needing doing this for ingress to egress, I would add it.

If that is the case, then this patch is completely unnecessary. So
instead of going back and forth, please elaborate on why resetting
CT for egress is a problem here.

Thanks.

  reply	other threads:[~2021-09-22  3:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 10:19 [PATCH net 0/2] net: sched: drop ct and dst for the packets toward ingress in act_mirred Xin Long
2021-09-20 10:19 ` [PATCH net 1/2] net: sched: drop ct for the packets toward ingress only " Xin Long
2021-09-20 18:31   ` Cong Wang
2021-09-21  7:01     ` Xin Long
2021-09-22  3:43       ` Cong Wang [this message]
2021-09-22  5:17         ` Xin Long
2021-09-24 23:04           ` mleitner
2021-09-20 10:19 ` [PATCH net 2/2] net: sched: also drop dst for the packets toward ingress " Xin Long
2021-09-20 18:34   ` Cong Wang
2021-09-21  7:01     ` Xin Long
2021-09-22  3:52       ` Cong Wang
2021-09-22  5:29         ` Xin Long
2021-09-23 16:06         ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpULkRxRjMBWKn+7V51PZXLWW17iQBLr1N5vdJmFVZtJ4A@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.