From: Cong Wang <xiyou.wangcong@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Chas Williams <3chas3@gmail.com>,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [Patch net] atm: remove an unnecessary loop
Date: Fri, 13 Jan 2017 16:41:53 -0800 [thread overview]
Message-ID: <CAM_iQpUY4cQePzdvQ9QWUc5AyGxXsaJS1P+UNyEoARY97kKKRA@mail.gmail.com> (raw)
In-Reply-To: <20170114001519.GB6874@electric-eye.fr.zoreil.com>
On Fri, Jan 13, 2017 at 4:15 PM, Francois Romieu <romieu@fr.zoreil.com> wrote:
> Cong Wang <xiyou.wangcong@gmail.com> :
>> On Fri, Jan 13, 2017 at 5:23 AM, Francois Romieu <romieu@fr.zoreil.com> wrote:
> [...]
>> > alloc_skb() does not need to be in the "while" loop.
>>
>> This is exactly what I describe in my changelog, don't know
>> why you want to repeat it...
>
> Because it is still hidden in a while loop.
>
> You turned the alloc from a two level deep "while" loop to a one level
> one. I want it at zero level. alloc_skb(..., GFP_KERNEL) fails ?
> So let it be done (see patch in other message).
>
Why I didn't remove all the loops is already stated in the later patch,
you said you read it? I doubt. ;)
> [...]
>> Please don't expect me to fix many things in one patch, let's
>> fix each of them separately, agreed?
>
> I am not convinced that several patches are needed to get the whole
> picture right.
>
My guideline for stable fixes is one patch fixes one problem, maybe
not suitable to you I think. Let's agree to disagree. ;)
next prev parent reply other threads:[~2017-01-14 0:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 5:02 [Patch net] atm: remove an unnecessary loop Cong Wang
2017-01-12 5:02 ` [Patch net] atm: switch to the new wait API for vcc_sendmsg() Cong Wang
2017-01-12 8:43 ` [Patch net] atm: remove an unnecessary loop Michal Hocko
2017-01-13 0:07 ` Francois Romieu
2017-01-13 0:14 ` Cong Wang
2017-01-13 13:23 ` Francois Romieu
2017-01-13 18:18 ` Cong Wang
2017-01-14 0:15 ` Francois Romieu
2017-01-14 0:41 ` Cong Wang [this message]
2017-01-13 17:10 ` David Miller
2017-01-13 18:20 ` Cong Wang
2017-01-13 23:54 ` Chas Williams
2017-01-14 0:30 ` Cong Wang
2017-01-14 11:34 ` Chas Williams
2017-01-14 0:14 ` Francois Romieu
2017-01-14 0:24 ` Francois Romieu
2017-01-14 0:36 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpUY4cQePzdvQ9QWUc5AyGxXsaJS1P+UNyEoARY97kKKRA@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=3chas3@gmail.com \
--cc=andreyknvl@google.com \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.