All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Ben Hutchings <ben.hutchings@codethink.co.uk>
Subject: Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device
Date: Tue, 9 Jan 2018 15:06:43 -0800	[thread overview]
Message-ID: <CAM_iQpUhXYcZYvndvmumdctWxtOQEiYG0XcmLv4Lfa2OHQWDeg@mail.gmail.com> (raw)
In-Reply-To: <73df52fd-0025-5cf3-bcb8-5ed8bd6438d3@cumulusnetworks.com>

On Tue, Jan 9, 2018 at 2:53 PM, Nikolay Aleksandrov
<nikolay@cumulusnetworks.com> wrote:
> On 01/10/2018 12:47 AM, Cong Wang wrote:
>> On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov
>> <nikolay@cumulusnetworks.com> wrote:
>>>
>>> Just for reference - this is identical to the first part of:
>>> https://patchwork.ozlabs.org/patch/252891/
>>>
>>> I knew this looked familiar. :-)
>>>
>>
>> Yeah, except bonding is not even involved. Unless I misread,
>> DaveM rejected it because of bond, which I never touch here.
>>
>> The refcnt is paired in vlan_vid_{add,del}, and the calls are
>> paired in register/unreigster and NETDEV_UP/NETDEV_DOWN
>> after this patch.
>>
>
> You should read all of my replies to Dave, specifically the last one where I
> describe exactly a memory leak, and IIRC the rejection was not because of the
> bonding part but exactly because of this change - the removal of the vlan_id
> conditional.

Quote:
"If you have the 8021q module available, and you bring a device up, it gets
VLAN 0 by default, and if necessary programmed into the HW filters of the
device."

This is exactly a complain about your bonding check added for NETDEVUP,
which is clearly not here.

> I'm not arguing about this patch now, I've said what I had to say back then,
> I just gave it as a reference in case there's still relevant information in
> there.

Me neither, I just want to point it out memory leak is real
and not even related to bond.

  reply	other threads:[~2018-01-09 23:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 21:40 [Patch net] 8021q: fix a memory leak for VLAN 0 device Cong Wang
2018-01-09 22:30 ` Nikolay Aleksandrov
2018-01-09 22:47   ` Cong Wang
2018-01-09 22:53     ` Nikolay Aleksandrov
2018-01-09 23:06       ` Cong Wang [this message]
2018-01-09 23:13         ` Nikolay Aleksandrov
2018-01-10 20:31 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpUhXYcZYvndvmumdctWxtOQEiYG0XcmLv4Lfa2OHQWDeg@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=ben.hutchings@codethink.co.uk \
    --cc=dvyukov@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.