From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [PATCH net-next v3 4/5] net/tc: introduce TC_ACT_REINJECT. Date: Wed, 25 Jul 2018 09:48:16 -0700 Message-ID: References: <3c20787be0fd5d64728ffed46ae0a7dff10d7e05.1532437050.git.pabeni@redhat.com> <6a9fd3c8f861c203c7e12a2a2e477796c5e093d5.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Paolo Abeni , Linux Kernel Network Developers , Jiri Pirko , Daniel Borkmann , Marcelo Ricardo Leitner , Eyal Birger , David Miller To: Jamal Hadi Salim Return-path: Received: from mail-pg1-f194.google.com ([209.85.215.194]:35994 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728644AbeGYR6s (ORCPT ); Wed, 25 Jul 2018 13:58:48 -0400 Received: by mail-pg1-f194.google.com with SMTP id s7-v6so5686903pgv.3 for ; Wed, 25 Jul 2018 09:46:19 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jul 25, 2018 at 5:27 AM Jamal Hadi Salim wrote: > > Those changes were there from the beginning (above patch did > not introduce them). > IIRC, the reason was to distinguish between policy intended > drops and drops because of errors. There must be a limit for "overlimit" to make sense. There is no limit in mirred action's context, probably there is only such a limit in act_police. So, all rest should not touch overlimit.