From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753860AbcGUQ67 (ORCPT ); Thu, 21 Jul 2016 12:58:59 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33554 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753365AbcGUQ6z (ORCPT ); Thu, 21 Jul 2016 12:58:55 -0400 MIME-Version: 1.0 In-Reply-To: <20160721164219.26723-1-vivien.didelot@savoirfairelinux.com> References: <20160721164219.26723-1-vivien.didelot@savoirfairelinux.com> From: Cong Wang Date: Thu, 21 Jul 2016 09:58:35 -0700 Message-ID: Subject: Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t To: Vivien Didelot Cc: Linux Kernel Network Developers , LKML , kernel@savoirfairelinux.com, "David S. Miller" , Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2016 at 9:42 AM, Vivien Didelot wrote: > Change the ageing_time type in br_set_ageing_time() from u32 to what it > is expected to be, i.e. a clock_t. You also need to change struct switchdev_attr: struct switchdev_attr { struct net_device *orig_dev; enum switchdev_attr_id id; u32 flags; void *complete_priv; void (*complete)(struct net_device *dev, int err, void *priv); union { struct netdev_phys_item_id ppid; /* PORT_PARENT_ID */ u8 stp_state; /* PORT_STP_STATE */ unsigned long brport_flags; /* PORT_BRIDGE_FLAGS */ u32 ageing_time; /* BRIDGE_AGEING_TIME */ bool vlan_filtering; /* BRIDGE_VLAN_FILTERING */ } u; };