All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: David Miller <davem@davemloft.net>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH net-next 1/1] Introduce skbmod action
Date: Sun, 17 Jul 2016 09:32:09 -0700	[thread overview]
Message-ID: <CAM_iQpV45uJw-dZs6rpyD8qdE1uoZGwPDWzbZ+3CbkNQE1VOLQ@mail.gmail.com> (raw)
In-Reply-To: <578A4498.9030307@mojatatu.com>

On Sat, Jul 16, 2016 at 7:28 AM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> On 16-07-12 01:10 PM, Cong Wang wrote:
>>
>> On Mon, Jul 11, 2016 at 5:12 AM, Jamal Hadi Salim <jhs@mojatatu.com>
>> wrote:
>>>
>>> From: Jamal Hadi Salim <jhs@mojatatu.com>
>>>
>>> This action is intended to be an upgrade from a usability perspective
>>> from pedit. Compare this:
>>>
>>
>> Definitely agree we need a more user-friendly interface.
>>
>>>
>>> pedit is a good starting point - but once you start going to a large
>>> number of policies then from a programmability, ops and usability point
>>> of view you need something with more succint params.
>>>
>>
>> But it is still unclear why we can't just build something on top of
>> pedit? Since pedit accepts keys like u32, user-space is free to
>> introduce any wrapper on top of it.
>>
>
>
> That hasnt served us well so far for reasons i described earlier
> especially in the dump case.
> It hasnt served u32 as a classifier well either (yes, those dump
> wrappers exist on the tc user code); i am almost willing to bet
> you didnt even know such a feature existed ;->

But this still sounds like it is solvable, just not yet solved, right?
And we don't have to change kernel space unless we can't
fix user-space.

      reply	other threads:[~2016-07-17 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 12:12 [RFC PATCH net-next 1/1] Introduce skbmod action Jamal Hadi Salim
2016-07-12 17:10 ` Cong Wang
2016-07-16 14:28   ` Jamal Hadi Salim
2016-07-17 16:32     ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpV45uJw-dZs6rpyD8qdE1uoZGwPDWzbZ+3CbkNQE1VOLQ@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.