All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] netlink: Deal with ESRCH error in nlmsg_notify()
Date: Mon, 19 Jul 2021 21:29:51 -0700	[thread overview]
Message-ID: <CAM_iQpV56fJjHotOuOsk=FavTqt9goDbfv4tv5J0nuoU-LKkWw@mail.gmail.com> (raw)
In-Reply-To: <20210719051816.11762-1-yajun.deng@linux.dev>

On Sun, Jul 18, 2021 at 10:19 PM Yajun Deng <yajun.deng@linux.dev> wrote:
> The failure seems due to the commit
>     cfdf0d9ae75b ("rtnetlink: use nlmsg_notify() in rtnetlink_send()")
>
> Deal with ESRCH error in nlmsg_notify() even the report variable is zero.

Looks like the tc-testing failure I saw is also due to this...

Why not just revert the above commit which does not have
much value? It at most saves some instructions.

Thanks.

  parent reply	other threads:[~2021-07-20  4:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  5:18 [PATCH] netlink: Deal with ESRCH error in nlmsg_notify() Yajun Deng
2021-07-19 14:47 ` Yonghong Song
2021-07-20  2:47 ` yajun.deng
2021-07-20  4:29 ` Cong Wang [this message]
2021-07-20 10:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpV56fJjHotOuOsk=FavTqt9goDbfv4tv5J0nuoU-LKkWw@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=davem@davemloft.net \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yajun.deng@linux.dev \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.