From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter
Date: Tue, 15 Jan 2019 09:52:08 -0800
Message-ID: <CAM_iQpVDay1SHwuXFZN0kS=RJ6_2inT+4NujLL4bBgj4M6xjdA@mail.gmail.com>
References: <20190112025542.397-1-xiyou.wangcong@gmail.com>
 <b7c845f1-be54-79a2-694d-f9db78bcad69@mojatatu.com> <2c84f3cc-b1ad-5316-4813-e7e433bf9f5e@mojatatu.com>
 <CAM_iQpW2mHvyBRmjomMZN7b-vizOFVTOkJKL3Aq3fmukfbc5tA@mail.gmail.com> <53f2ac1d-ea4c-b779-c4a7-6268758f87bf@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Martin Olsson <martin.olsson+netdev@sentorsecurity.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Lucas Bates <lucasb@mojatatu.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f196.google.com ([209.85.210.196]:42311 "EHLO
        mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729410AbfAORwV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 15 Jan 2019 12:52:21 -0500
Received: by mail-pf1-f196.google.com with SMTP id 64so1645837pfr.9
        for <netdev@vger.kernel.org>; Tue, 15 Jan 2019 09:52:20 -0800 (PST)
In-Reply-To: <53f2ac1d-ea4c-b779-c4a7-6268758f87bf@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Jan 15, 2019 at 7:59 AM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>
> On 2019-01-13 4:08 p.m., Cong Wang wrote:
> > On Sat, Jan 12, 2019 at 7:41 AM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> >>
> >> On 2019-01-12 7:23 a.m., Jamal Hadi Salim wrote:
> >>
> >>> Do we have a test case for a setup like this in tdc?
> >>> i.e incoming tagged and then vlan popped by action?
> >>> Otherwise a test with IFE which resets the ethertype
> >>> would be sufficient i.e just something that will messup
> >>> with skb->protocol.
> >>
> >> And here is a slightly complex test with IFE.
> >> Wanted to show both reclassify and continue in play
> >> as well as something that change skb->protocol.
> >>
> >
> > I don't know why you need a complex one, Martin's
> > test case is pretty simple (as I already sent to you).
> >
>
> Martin example had a "reclassify" with the vlan pop.
> Your example was showing a "continue"
> Note: "Reclassify" is typical how we have explained
> to users to deal with skb->protocol changes.


You have to re-read Martin's example, he clearly showed
"reclassify" works but not "continue". This is exactly why
I have "continue" in my script, as I need to test what I fix.


> Lets have Lucas give this a run and we can move
> forward.

Sure.

Thanks.