All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v2 2/6] net_sched: act: use standard struct list_head
Date: Fri, 13 Dec 2013 10:46:28 -0800	[thread overview]
Message-ID: <CAM_iQpVL-dwiwTdVbvM3FPZfaJhSN_pRuB0-nm7sxrFtrSH-2A@mail.gmail.com> (raw)
In-Reply-To: <CABa6K_H_f_9sS4pH2gE2YD_KUHOVMGRwpy1x8Q-i3mFDEmQXjA@mail.gmail.com>

On Thu, Dec 12, 2013 at 10:32 PM, Changli Gao <xiaosuo@gmail.com> wrote:
> On Fri, Dec 13, 2013 at 12:56 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>
>> @@ -85,12 +86,18 @@ static inline int
>>  tcf_exts_is_predicative(struct tcf_exts *exts)
>>  {
>>  #ifdef CONFIG_NET_CLS_ACT
>> -       return !!exts->action;
>> +       return list_empty(&exts->head);
>>  #else
>>         return 0;
>>  #endif
>>  }
>>
>
> You missed a "!".
>


Fixed.

Thanks.

  reply	other threads:[~2013-12-13 18:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13  4:56 [PATCH net-next v2 0/6] net_sched: some cleanup and improvments Cong Wang
2013-12-13  4:56 ` [PATCH net-next v2 1/6] net_sched: remove get_stats from tc_action_ops Cong Wang
2013-12-13  4:56 ` [PATCH net-next v2 2/6] net_sched: act: use standard struct list_head Cong Wang
2013-12-13  6:32   ` Changli Gao
2013-12-13 18:46     ` Cong Wang [this message]
2013-12-13  4:56 ` [PATCH net-next v2 3/6] net_sched: mirred: remove action when the target device is gone Cong Wang
2013-12-13  4:56 ` [PATCH net-next v2 4/6] net_sched: cls: refactor out struct tcf_ext_map Cong Wang
2013-12-13  4:56 ` [PATCH net-next v2 5/6] net_sched: init struct tcf_hashinfo at register time Cong Wang
2013-12-13  4:56 ` [PATCH net-next v2 6/6] net_sched: convert tcf_hashinfo to hlist and use rcu Cong Wang
2013-12-13  5:18   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpVL-dwiwTdVbvM3FPZfaJhSN_pRuB0-nm7sxrFtrSH-2A@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.