All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: wenxu <wenxu@ucloud.cn>, Jakub Kicinski <kuba@kernel.org>,
	Vlad Buslov <vladbu@nvidia.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.
Date: Mon, 16 Nov 2020 10:57:58 -0800	[thread overview]
Message-ID: <CAM_iQpVQM3rdGk91oaSMUSf48CgPcMFB+bYETQsuOnkx8pEfUw@mail.gmail.com> (raw)
In-Reply-To: <20201114224617.GK3913@localhost.localdomain>

On Sat, Nov 14, 2020 at 2:46 PM Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> Davide had shared similar concerns with regards of the new module too.
> The main idea behind the new module was to keep it as
> isolated/contained as possible, and only so. So thumbs up from my
> side.
>
> To be clear, you're only talking about the module itself, right? It
> would still need to have the Kconfig to enable this feature, or not?

Both. The code itself doesn't look like a module, and it doesn't
look like an optional feature for act_ct either, does it? If not, there is
no need to have a user visible Kconfig, we just select it, or no Kconfig
at all.

Thanks.

  reply	other threads:[~2020-11-16 18:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12  3:24 [PATCH v10 net-next 0/3] net/sched: fix over mtu packet of defrag in wenxu
2020-11-12  3:24 ` [PATCH v10 net-next 1/3] net/sched: fix miss init the mru in qdisc_skb_cb wenxu
2020-11-12  3:24 ` [PATCH v10 net-next 2/3] net/sched: act_mirred: refactor the handle of xmit wenxu
2020-11-12  3:24 ` [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support wenxu
2020-11-12 22:20   ` Jakub Kicinski
2020-11-13  2:25     ` Marcelo Ricardo Leitner
2020-11-13 17:04       ` Jakub Kicinski
2020-11-14 18:05   ` Cong Wang
2020-11-14 22:46     ` Marcelo Ricardo Leitner
2020-11-16 18:57       ` Cong Wang [this message]
2020-11-15 13:05     ` wenxu
2020-11-15 16:26       ` Jamal Hadi Salim
2020-11-16  1:09         ` wenxu
2020-11-16 19:01       ` Cong Wang
2020-11-17  4:01         ` wenxu
2020-11-17 22:43           ` Cong Wang
2020-11-17 23:21             ` wenxu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpVQM3rdGk91oaSMUSf48CgPcMFB+bYETQsuOnkx8pEfUw@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=kuba@kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vladbu@nvidia.com \
    --cc=wenxu@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.