From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [net-next,RFC PATCH] Introduce TC Range classifier
Date: Fri, 14 Sep 2018 14:09:48 -0700
Message-ID: <CAM_iQpVf-iPRZNipWo9VJrK5H5A44ti1zbXyfVCtd_mQeJZQWw@mail.gmail.com>
References: <153687160312.43503.11156697286063840163.stgit@anamhost.jf.intel.com>
 <20180914094932.GK25110@nanopsycho>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: amritha.nambiar@intel.com,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Alexander Duyck <alexander.h.duyck@intel.com>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        sridhar.samudrala@intel.com, Jamal Hadi Salim <jhs@mojatatu.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f193.google.com ([209.85.215.193]:43585 "EHLO
        mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728050AbeIOC0M (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 14 Sep 2018 22:26:12 -0400
Received: by mail-pg1-f193.google.com with SMTP id v66-v6so4932483pgb.10
        for <netdev@vger.kernel.org>; Fri, 14 Sep 2018 14:10:00 -0700 (PDT)
In-Reply-To: <20180914094932.GK25110@nanopsycho>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Sep 14, 2018 at 2:53 AM Jiri Pirko <jiri@resnulli.us> wrote:
>
> Thu, Sep 13, 2018 at 10:52:01PM CEST, amritha.nambiar@intel.com wrote:
> >This patch introduces a TC range classifier to support filtering based
> >on ranges. Only port-range filters are supported currently. This can
> >be combined with flower classifier to support filters that are a
> >combination of port-ranges and other parameters based on existing
> >fields supported by cls_flower. The 'goto chain' action can be used to
> >combine the flower and range filter.
> >The filter precedence is decided based on the 'prio' value.
>
> For example Spectrum ASIC supports mask-based and range-based matching
> in a single TCAM rule. No chains needed. Also, I don't really understand
> why is this a separate cls. I believe that this functionality should be
> put as an extension of existing cls_flower.

Exactly. u32 filters support range matching too with proper masks.