BUG: unable to handle kernel paging request in fl_dump_key

BUG: unable to handle kernel paging request in fl_dump_key

[syzbot]

Hello,

syzbot found the following crash on:

HEAD commit:    99addbe3 net: broadcom: Select BROADCOM_PHY for BCMGENET
git tree:       net
console output: https://syzkaller.appspot.com/x/log.txt?x=173e568c100000
kernel config:  https://syzkaller.appspot.com/x/.config?x=b0212dbee046bc1f
dashboard link: https://syzkaller.appspot.com/bug?extid=9c1be56e9317b795e874
compiler:       gcc (GCC) 9.0.0 20181231 (experimental)

Unfortunately, I don't have any reproducer for this crash yet.

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+9c1be56e9317b795e874@syzkaller.appspotmail.com

BUG: unable to handle page fault for address: fffffbfff4a9538a
#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page
PGD 21ffe5067 P4D 21ffe5067 PUD 21ffe4067 PMD 0 
Oops: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 5831 Comm: syz-executor.3 Not tainted 5.7.0-rc4-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:fl_dump_key+0x8c/0x1980 net/sched/cls_flower.c:2514
Code: 04 f2 04 f2 c7 40 0c 04 f3 f3 f3 65 48 8b 04 25 28 00 00 00 48 89 84 24 b0 00 00 00 31 c0 e8 3b 0d 20 fb 48 89 e8 48 c1 e8 03 <42> 0f b6 04 30 84 c0 74 08 3c 03 0f 8e 6f 17 00 00 44 8b 75 00 31
RSP: 0018:ffffc900019672d8 EFLAGS: 00010a03
RAX: 1ffffffff4a9538a RBX: ffffffffa54a9a8f RCX: ffffc9000f733000
RDX: 000000000000080f RSI: ffffffff86532275 RDI: ffff88808f68b800
RBP: ffffffffa54a9c57 R08: ffff888096266200 R09: ffff888097a5603c
R10: ffff888097a56036 R11: ffffed1012f4ac06 R12: ffff88808f68b800
R13: ffff88806780a100 R14: dffffc0000000000 R15: ffff88806780a100
FS:  00007f0a86395700(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: fffffbfff4a9538a CR3: 0000000099de6000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 fl_tmplt_dump+0xcf/0x250 net/sched/cls_flower.c:2784
 tc_chain_fill_node+0x48e/0x7c0 net/sched/cls_api.c:2707
 tc_chain_notify+0x189/0x2e0 net/sched/cls_api.c:2733
 tc_ctl_chain+0xb82/0x1080 net/sched/cls_api.c:2919
 rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5454
 netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2469
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6bf/0x7e0 net/socket.c:2362
 ___sys_sendmsg+0x100/0x170 net/socket.c:2416
 __sys_sendmsg+0xec/0x1b0 net/socket.c:2449
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x45c829
Code: 0d b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 db b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f0a86394c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000500d20 RCX: 000000000045c829
RDX: 0000000000000000 RSI: 00000000200001c0 RDI: 0000000000000003
RBP: 000000000078c040 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff
R13: 0000000000000a05 R14: 00000000004ccbdd R15: 00007f0a863956d4
Modules linked in:
CR2: fffffbfff4a9538a
---[ end trace da47bdc433f8d794 ]---
RIP: 0010:fl_dump_key+0x8c/0x1980 net/sched/cls_flower.c:2514
Code: 04 f2 04 f2 c7 40 0c 04 f3 f3 f3 65 48 8b 04 25 28 00 00 00 48 89 84 24 b0 00 00 00 31 c0 e8 3b 0d 20 fb 48 89 e8 48 c1 e8 03 <42> 0f b6 04 30 84 c0 74 08 3c 03 0f 8e 6f 17 00 00 44 8b 75 00 31
RSP: 0018:ffffc900019672d8 EFLAGS: 00010a03
RAX: 1ffffffff4a9538a RBX: ffffffffa54a9a8f RCX: ffffc9000f733000
RDX: 000000000000080f RSI: ffffffff86532275 RDI: ffff88808f68b800
RBP: ffffffffa54a9c57 R08: ffff888096266200 R09: ffff888097a5603c
R10: ffff888097a56036 R11: ffffed1012f4ac06 R12: ffff88808f68b800
R13: ffff88806780a100 R14: dffffc0000000000 R15: ffff88806780a100
FS:  00007f0a86395700(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: fffffbfff4a9538a CR3: 0000000099de6000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

Re: BUG: unable to handle kernel paging request in fl_dump_key

[Cong Wang]

On Fri, May 15, 2020 at 6:53 AM syzbot
<syzbot+9c1be56e9317b795e874@syzkaller.appspotmail.com> wrote:
>
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:    99addbe3 net: broadcom: Select BROADCOM_PHY for BCMGENET
> git tree:       net
> console output: https://syzkaller.appspot.com/x/log.txt?x=173e568c100000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=b0212dbee046bc1f
> dashboard link: https://syzkaller.appspot.com/bug?extid=9c1be56e9317b795e874
> compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
>
> Unfortunately, I don't have any reproducer for this crash yet.
>
> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+9c1be56e9317b795e874@syzkaller.appspotmail.com
>
> BUG: unable to handle page fault for address: fffffbfff4a9538a
> #PF: supervisor read access in kernel mode
> #PF: error_code(0x0000) - not-present page
> PGD 21ffe5067 P4D 21ffe5067 PUD 21ffe4067 PMD 0
> Oops: 0000 [#1] PREEMPT SMP KASAN
> CPU: 1 PID: 5831 Comm: syz-executor.3 Not tainted 5.7.0-rc4-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> RIP: 0010:fl_dump_key+0x8c/0x1980 net/sched/cls_flower.c:2514
> Code: 04 f2 04 f2 c7 40 0c 04 f3 f3 f3 65 48 8b 04 25 28 00 00 00 48 89 84 24 b0 00 00 00 31 c0 e8 3b 0d 20 fb 48 89 e8 48 c1 e8 03 <42> 0f b6 04 30 84 c0 74 08 3c 03 0f 8e 6f 17 00 00 44 8b 75 00 31
> RSP: 0018:ffffc900019672d8 EFLAGS: 00010a03
> RAX: 1ffffffff4a9538a RBX: ffffffffa54a9a8f RCX: ffffc9000f733000
> RDX: 000000000000080f RSI: ffffffff86532275 RDI: ffff88808f68b800
> RBP: ffffffffa54a9c57 R08: ffff888096266200 R09: ffff888097a5603c
> R10: ffff888097a56036 R11: ffffed1012f4ac06 R12: ffff88808f68b800
> R13: ffff88806780a100 R14: dffffc0000000000 R15: ffff88806780a100
> FS:  00007f0a86395700(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: fffffbfff4a9538a CR3: 0000000099de6000 CR4: 00000000001406e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
>  fl_tmplt_dump+0xcf/0x250 net/sched/cls_flower.c:2784
>  tc_chain_fill_node+0x48e/0x7c0 net/sched/cls_api.c:2707
>  tc_chain_notify+0x189/0x2e0 net/sched/cls_api.c:2733
>  tc_ctl_chain+0xb82/0x1080 net/sched/cls_api.c:2919

I guess the chain template name must be specified by user:

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 0a7ecc292bd3..bcacb7db70c6 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -2782,8 +2782,10 @@ static int tc_chain_tmplt_add(struct tcf_chain
*chain, struct net *net,
        void *tmplt_priv;

        /* If kind is not set, user did not specify template. */
-       if (!tca[TCA_KIND])
-               return 0;
+       if (!tca[TCA_KIND]) {
+               NL_SET_ERR_MSG(extack, "TC chain template name is not
specified");
+               return -EINVAL;
+       }

        if (tcf_proto_check_kind(tca[TCA_KIND], name)) {
                NL_SET_ERR_MSG(extack, "Specified TC chain template
name too long");

Re: BUG: unable to handle kernel paging request in fl_dump_key

[syzbot]

syzbot has found a reproducer for the following crash on:

HEAD commit:    1ca0fafd tcp: md5: allow changing MD5 keys in all socket s..
git tree:       net
console output: https://syzkaller.appspot.com/x/log.txt?x=15ec52b7100000
kernel config:  https://syzkaller.appspot.com/x/.config?x=bf3aec367b9ab569
dashboard link: https://syzkaller.appspot.com/bug?extid=9c1be56e9317b795e874
compiler:       gcc (GCC) 10.1.0-syz 20200507
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1062a40b100000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+9c1be56e9317b795e874@syzkaller.appspotmail.com

batman_adv: Cannot find parent device
BUG: unable to handle page fault for address: fffffbfffa2f173f
#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page
PGD 21ffe5067 P4D 21ffe5067 PUD 21ffe4067 PMD 0 
Oops: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 2591 Comm: syz-executor.2 Not tainted 5.8.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:fl_dump_key+0x8d/0x22a0 net/sched/cls_flower.c:2769
Code: 04 f2 04 f2 c7 40 0c 04 f3 f3 f3 65 48 8b 04 25 28 00 00 00 48 89 84 24 00 01 00 00 31 c0 e8 1a 32 0d fb 4c 89 f8 48 c1 e8 03 <42> 0f b6 04 28 84 c0 74 08 3c 03 0f 8e a8 1f 00 00 45 8b 2f 31 ff
RSP: 0018:ffffc900035e72c8 EFLAGS: 00010a06
RAX: 1ffffffffa2f173f RBX: ffffffffd178b819 RCX: ffffffffd178b9f9
RDX: ffff88806c8d2140 RSI: ffffffff86662036 RDI: ffff88809fa14800
RBP: ffff88809fa14800 R08: 0000000000000000 R09: ffff8880953a203c
R10: 0000000000000000 R11: 0000000000000000 R12: ffff888087ce0040
R13: dffffc0000000000 R14: ffff88809fa148b8 R15: ffffffffd178b9f9
FS:  00007f7df9322700(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: fffffbfffa2f173f CR3: 000000006c49a000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 fl_tmplt_dump+0xc9/0x250 net/sched/cls_flower.c:3081
 tc_chain_fill_node+0x48d/0x7c0 net/sched/cls_api.c:2679
 tc_chain_notify+0x187/0x2e0 net/sched/cls_api.c:2705
 tc_ctl_chain+0xb30/0x1000 net/sched/cls_api.c:2891
 rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5460
 netlink_rcv_skb+0x15a/0x430 net/netlink/af_netlink.c:2469
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2352
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2406
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2439
 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:359
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x45cb29
Code: Bad RIP value.
RSP: 002b:00007f7df9321c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000005027a0 RCX: 000000000045cb29
RDX: 0000000000000000 RSI: 00000000200001c0 RDI: 0000000000000009
RBP: 000000000078bf00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000ffffffff
R13: 0000000000000a44 R14: 00000000004cd2b2 R15: 00007f7df93226d4
Modules linked in:
CR2: fffffbfffa2f173f
---[ end trace aa31af5515bd8e77 ]---
RIP: 0010:fl_dump_key+0x8d/0x22a0 net/sched/cls_flower.c:2769
Code: 04 f2 04 f2 c7 40 0c 04 f3 f3 f3 65 48 8b 04 25 28 00 00 00 48 89 84 24 00 01 00 00 31 c0 e8 1a 32 0d fb 4c 89 f8 48 c1 e8 03 <42> 0f b6 04 28 84 c0 74 08 3c 03 0f 8e a8 1f 00 00 45 8b 2f 31 ff
RSP: 0018:ffffc900035e72c8 EFLAGS: 00010a06
RAX: 1ffffffffa2f173f RBX: ffffffffd178b819 RCX: ffffffffd178b9f9
RDX: ffff88806c8d2140 RSI: ffffffff86662036 RDI: ffff88809fa14800
RBP: ffff88809fa14800 R08: 0000000000000000 R09: ffff8880953a203c
R10: 0000000000000000 R11: 0000000000000000 R12: ffff888087ce0040
R13: dffffc0000000000 R14: ffff88809fa148b8 R15: ffffffffd178b9f9
FS:  00007f7df9322700(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: fffffbfffa2f173f CR3: 000000006c49a000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Re: BUG: unable to handle kernel paging request in fl_dump_key

[syzbot]

syzbot has bisected this issue to:

commit a51486266c3ba8e035a47fa96df67f274fe0c7d0
Author: Jiri Pirko <jiri@mellanox.com>
Date:   Sat Jun 15 09:03:49 2019 +0000

    net: sched: remove NET_CLS_IND config option

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x\x17463509900000
start commit:   1ca0fafd tcp: md5: allow changing MD5 keys in all socket s..
git tree:       net
final oops:     https://syzkaller.appspot.com/x/report.txt?x\x14c63509900000
console output: https://syzkaller.appspot.com/x/log.txt?x\x10c63509900000
kernel config:  https://syzkaller.appspot.com/x/.config?x¿3aec367b9ab569
dashboard link: https://syzkaller.appspot.com/bug?extidœ1be56e9317b795e874
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x\x1062a40b100000

Reported-by: syzbot+9c1be56e9317b795e874@syzkaller.appspotmail.com
Fixes: a51486266c3b ("net: sched: remove NET_CLS_IND config option")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: BUG: unable to handle kernel paging request in fl_dump_key

[syzbot]

syzbot has bisected this issue to:

commit a51486266c3ba8e035a47fa96df67f274fe0c7d0
Author: Jiri Pirko <jiri@mellanox.com>
Date:   Sat Jun 15 09:03:49 2019 +0000

    net: sched: remove NET_CLS_IND config option

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=17463509900000
start commit:   1ca0fafd tcp: md5: allow changing MD5 keys in all socket s..
git tree:       net
final oops:     https://syzkaller.appspot.com/x/report.txt?x=14c63509900000
console output: https://syzkaller.appspot.com/x/log.txt?x=10c63509900000
kernel config:  https://syzkaller.appspot.com/x/.config?x=bf3aec367b9ab569
dashboard link: https://syzkaller.appspot.com/bug?extid=9c1be56e9317b795e874
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1062a40b100000

Reported-by: syzbot+9c1be56e9317b795e874@syzkaller.appspotmail.com
Fixes: a51486266c3b ("net: sched: remove NET_CLS_IND config option")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: BUG: unable to handle kernel paging request in fl_dump_key

[syzbot]

syzbot has bisected this issue to:

commit a51486266c3ba8e035a47fa96df67f274fe0c7d0
Author: Jiri Pirko <jiri@mellanox.com>
Date:   Sat Jun 15 09:03:49 2019 +0000

    net: sched: remove NET_CLS_IND config option

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=17463509900000
start commit:   1ca0fafd tcp: md5: allow changing MD5 keys in all socket s..
git tree:       net
final oops:     https://syzkaller.appspot.com/x/report.txt?x=14c63509900000
console output: https://syzkaller.appspot.com/x/log.txt?x=10c63509900000
kernel config:  https://syzkaller.appspot.com/x/.config?x=bf3aec367b9ab569
dashboard link: https://syzkaller.appspot.com/bug?extid=9c1be56e9317b795e874
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1062a40b100000

Reported-by: syzbot+9c1be56e9317b795e874@syzkaller.appspotmail.com
Fixes: a51486266c3b ("net: sched: remove NET_CLS_IND config option")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection