From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch iproute2] u32: add terminal parameter Date: Tue, 15 Apr 2014 13:17:50 -0700 Message-ID: References: <1396631826-15188-1-git-send-email-xiyou.wangcong@gmail.com> <20140411140446.6412e9dc@nehalam.linuxnetplumber.net> <20140411175800.08e9ffe3@nehalam.linuxnetplumber.net> <534926F7.10505@mojatatu.com> <534C6BDE.8020600@mojatatu.com> <534D2D62.5080109@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Stephen Hemminger , Linux Kernel Network Developers , David Miller To: Jamal Hadi Salim Return-path: Received: from mail-oa0-f50.google.com ([209.85.219.50]:64071 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036AbaDOURv (ORCPT ); Tue, 15 Apr 2014 16:17:51 -0400 Received: by mail-oa0-f50.google.com with SMTP id i7so11558117oag.9 for ; Tue, 15 Apr 2014 13:17:50 -0700 (PDT) In-Reply-To: <534D2D62.5080109@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Apr 15, 2014 at 6:00 AM, Jamal Hadi Salim wrote: > On 04/14/14 21:57, Cong Wang wrote: > >> So essentially why u32 filters can't just do matching without bothering > > > u32 is a special animal. You can actually have intermediate nodes > which are _not_ terminal. i.e you can build a tree of hashes which > interconnect other hashes eventually leading to terminal nodes. > I knew, I thought at least classid is an alternative for action, that is, one doing classify and one doing some other action. > >> classid especially when they are attached to an ingress qdisc? I still >> fail to see a reason why I have to care about classid here. > > > It is more of a historical artifact with "benefits". > Historical in that egress qdiscs with classes existed before ingress; > so it makes sense to keep the syntax people are already familiar with. > Benefits because infact with the right approach the flowid even at > ingress can be used as input(look at the route classifier for example > and association with route accounting of the source). > I see. The next question would be what is a reasonable classid value for a classless qdisc? Or can we set it to some value to express "we don't care"? Thanks!