From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [patch net v2 1/4] net/sched: Change tc_action refcnt and bindcnt to atomic Date: Mon, 23 Oct 2017 08:39:52 -0700 Message-ID: References: <1508152718-28726-1-git-send-email-chrism@mellanox.com> <1508152718-28726-2-git-send-email-chrism@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Jamal Hadi Salim , Linux Kernel Network Developers , Lucas Bates , Jiri Pirko , David Miller To: Chris Mi Return-path: Received: from mail-pg0-f44.google.com ([74.125.83.44]:54567 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932126AbdJWPkO (ORCPT ); Mon, 23 Oct 2017 11:40:14 -0400 Received: by mail-pg0-f44.google.com with SMTP id l24so12056170pgu.11 for ; Mon, 23 Oct 2017 08:40:13 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Oct 22, 2017 at 7:47 PM, Chris Mi wrote: > > It seems it is not easy to discard call_rcu(). I'm afraid even if we have a final solution > without call_rcu(), it is not mature at the beginning as well. I mean we also need time Why do you believe it is not easy? RTNL lock is already there, list_splice_init_rcu() is there too. I can naturally divide my patches for each module so that they are much easier to backport than yours. > to fix the possible bugs of the new design. And maybe to destroy the filters in parallel > is the right direction. If this bug is the last bug brought by call_rcu(), then changing it > may not be a good idea. Again, you have to prove this is the last bug, I seriously doubt it is. > > Patch 1 is straightforward to use atomic. Patch 2 is to convert the list to array. Both are big in size. > I think there is no harm to the new design. Patch 3 and 4 are useful test case. It definitely doesn't harm, but why do we waste time on it when we know there is a better way? It is clearly not easy for backport either, in fact it is harder w.r.t. size. > We also need it with new design to make sure there is no regression. > Are you saying I can't trust your test cases? ;) > So I think my patch set should not be held so long time. I think your patches should be dropped except the last two, I will take the last two for you. Thanks!