From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch net] 8021q: fix a memory leak for VLAN 0 device Date: Tue, 9 Jan 2018 14:47:26 -0800 Message-ID: References: <20180109214041.26842-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Linux Kernel Network Developers , Dmitry Vyukov , Vlad Yasevich , Ben Hutchings To: Nikolay Aleksandrov Return-path: Received: from mail-pg0-f53.google.com ([74.125.83.53]:38065 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754294AbeAIWrr (ORCPT ); Tue, 9 Jan 2018 17:47:47 -0500 Received: by mail-pg0-f53.google.com with SMTP id t67so9021183pgc.5 for ; Tue, 09 Jan 2018 14:47:47 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 9, 2018 at 2:30 PM, Nikolay Aleksandrov wrote: > > Just for reference - this is identical to the first part of: > https://patchwork.ozlabs.org/patch/252891/ > > I knew this looked familiar. :-) > Yeah, except bonding is not even involved. Unless I misread, DaveM rejected it because of bond, which I never touch here. The refcnt is paired in vlan_vid_{add,del}, and the calls are paired in register/unreigster and NETDEV_UP/NETDEV_DOWN after this patch.