From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH net-next] net:sched: add action inheritdsfield to skbmod
Date: Wed, 23 May 2018 16:01:17 -0700
Message-ID: <CAM_iQpWJ0=w5A5+onbF-Ngo+emgHm-JMpyJdWONt2NWRu9Kk2w@mail.gmail.com>
References: <2F042100-2BAC-48E5-887C-5D426B1D5A5B@bu.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        Michel Machado <michel@digirati.com.br>
To: "Fu, Qiaobin" <qiaobinf@bu.edu>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f67.google.com ([209.85.160.67]:43836 "EHLO
        mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934854AbeEWXBi (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 23 May 2018 19:01:38 -0400
Received: by mail-pl0-f67.google.com with SMTP id c41-v6so13893856plj.10
        for <netdev@vger.kernel.org>; Wed, 23 May 2018 16:01:38 -0700 (PDT)
In-Reply-To: <2F042100-2BAC-48E5-887C-5D426B1D5A5B@bu.edu>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, May 17, 2018 at 12:33 PM, Fu, Qiaobin <qiaobinf@bu.edu> wrote:
> net/sched: add action inheritdsfield to skbmod
>
> The new action inheritdsfield copies the field DS of
> IPv4 and IPv6 packets into skb->prioriry. This enables
> later classification of packets based on the DS field.
>
> Original idea by Jamal Hadi Salim <jhs@mojatatu.com>
>
> Signed-off-by: Qiaobin Fu <qiaobinf@bu.edu>
> Reviewed-by: Michel Machado <michel@digirati.com.br>

Hmm, but skbedit seems better than skbmod for this job,
given:

1) It already modifies skb->priority, although with a given value

2) skbmod doesn't change skb metadata, it only changes payload

I am _not_ saying there is strict rule for what skbmod can or can't
change, it calls itself "data modifier", so I am saying we probably
need to follow this existing practice.