From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D048C433E0 for ; Tue, 9 Feb 2021 01:41:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 011C664E66 for ; Tue, 9 Feb 2021 01:41:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbhBIBlY (ORCPT ); Mon, 8 Feb 2021 20:41:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhBIBlC (ORCPT ); Mon, 8 Feb 2021 20:41:02 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BF67C061788; Mon, 8 Feb 2021 17:40:21 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id l18so702658pji.3; Mon, 08 Feb 2021 17:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rGns9Si4hklyYlr4xa8f+5lVK+CURy/S5nAUBEm39b0=; b=czAuHghGLiyHJO6GvCnpR2Nfl8PlNE1LIvk/heLXFi0hCJkeSOj+yiJmSfT2zcaSyH LCN9o/ztaIyvg5TroK/Lq62XLkY8MZvRb93KK/4H2/Gi9DYXIqfKKdgipFYMwi9/hQQN jIYLCnkoZbk+m9y925041GQZj2UJjByK7qnwHdkhQe2YgUMoHBX1Pwlk+F2l8Kbi4fxV qk95s4OZdQxuFZAKutDIrQqsoNWVMwg4amPv4Q84RtGMBt1iIdRynVkyry9sZBQGNdgp Rb9exFYd6B8MnZjLpX1aFdU9sJlC1UvtR6V2BSBGCmE+UH6rDqffLeAQQxx6HWuCz3G0 kFrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rGns9Si4hklyYlr4xa8f+5lVK+CURy/S5nAUBEm39b0=; b=twr9B38HxQDmihh3O78vhDMCwJcWJPcX45ReKsNyScgdRVtIGyfN6qnJjCYNfICqiR IpOkKXznuwpyRqBO8MVHCyxYOmI+wyIIoDFnYJUG4J8c/aVUcrN+JyPaF7iT9R9e4anC ZyxTgID9IEk4U67CraP/ZVCRutjQ3otK+OcDdmFlWYktZEBztOdse5lv1if9vblpR8pz 4TyL79KHxE6+v7PDlSjbd11fYLuViz27UWTa3aXzhIYolRJtwsjRvgmnQND1TD6yQoHd uDETQtZvTq++4kRcfDY3htOR/tdOXlaCHm85yqgal9pzeqysjbxa4dtJ0t4/AUDVwZh0 CQMw== X-Gm-Message-State: AOAM531GhHoL/G5/8Uv2AN9oTASga83dkcYtBYLL4w4nLNymBmDYQzuX pt/oAYwnlx/lBoLV8TrqUjJnsadDhQFm16Nnk+o= X-Google-Smtp-Source: ABdhPJwgc+HfKjDRfpse67GJBMHHYKgRHUCN4SdBzwu6uUSFAcl8khk0Offdjt/1D02F/sR1CQqVZrWPEH0ygMOY2qA= X-Received: by 2002:a17:90a:5287:: with SMTP id w7mr1683222pjh.52.1612834821220; Mon, 08 Feb 2021 17:40:21 -0800 (PST) MIME-Version: 1.0 References: <20210203041636.38555-1-xiyou.wangcong@gmail.com> <20210203041636.38555-2-xiyou.wangcong@gmail.com> <87im764xez.fsf@cloudflare.com> In-Reply-To: <87im764xez.fsf@cloudflare.com> From: Cong Wang Date: Mon, 8 Feb 2021 17:40:10 -0800 Message-ID: Subject: Re: [Patch bpf-next 01/19] bpf: rename BPF_STREAM_PARSER to BPF_SOCK_MAP To: Jakub Sitnicki Cc: Linux Kernel Network Developers , bpf , duanxiongchun@bytedance.com, Dongdong Wang , jiang.wang@bytedance.com, Cong Wang , John Fastabend , Daniel Borkmann , Lorenz Bauer Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Feb 5, 2021 at 2:32 AM Jakub Sitnicki wrote: > > On Wed, Feb 03, 2021 at 05:16 AM CET, Cong Wang wrote: > > From: Cong Wang > > > > Before we add non-TCP support, it is necessary to rename > > BPF_STREAM_PARSER as it will be no longer specific to TCP, > > and it does not have to be a parser either. > > > > This patch renames BPF_STREAM_PARSER to BPF_SOCK_MAP, so > > that sock_map.c hopefully would be protocol-independent. > > > > Also, improve its Kconfig description to avoid confusion. > > > > Cc: John Fastabend > > Cc: Daniel Borkmann > > Cc: Jakub Sitnicki > > Cc: Lorenz Bauer > > Signed-off-by: Cong Wang > > --- > > include/linux/bpf.h | 4 ++-- > > include/linux/bpf_types.h | 2 +- > > include/net/tcp.h | 4 ++-- > > include/net/udp.h | 4 ++-- > > net/Kconfig | 13 ++++++------- > > net/core/Makefile | 2 +- > > net/ipv4/Makefile | 2 +- > > net/ipv4/tcp_bpf.c | 4 ++-- > > 8 files changed, 17 insertions(+), 18 deletions(-) > > We also have a couple of references to CONFIG_BPF_STREAM_PARSER in > tools/tests: > > $ git grep -i bpf_stream_parser > ... > tools/bpf/bpftool/feature.c: { "CONFIG_BPF_STREAM_PARSER", }, > tools/testing/selftests/bpf/config:CONFIG_BPF_STREAM_PARSER=y I think I did a grep in the whole tree, but still missed these two. Thanks for catching it!