All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: David Miller <davem@davemloft.net>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	vyasevic@redhat.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Vladislav Yasevich <vyasevich@gmail.com>,
	mark.rutland@arm.com, Greg KH <gregkh@linuxfoundation.org>,
	leonro@mellanox.com, avagin@virtuozzo.com,
	Florian Westphal <fw@strlen.de>,
	roman.kapl@sysgo.com,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/3] net: Make cleanup_list and net::cleanup_list of llist type
Date: Tue, 20 Feb 2018 11:42:53 -0800	[thread overview]
Message-ID: <CAM_iQpWR0HZq2WN+DU_qoGqwJnzdyaEJ5nznYVMpa3MZLV-Mrw@mail.gmail.com> (raw)
In-Reply-To: <151903432575.8021.5189428113212356710.stgit@localhost.localdomain>

On Mon, Feb 19, 2018 at 1:58 AM, Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>  void __put_net(struct net *net)
>  {
>         /* Cleanup the network namespace in process context */
> -       unsigned long flags;
> -
> -       spin_lock_irqsave(&cleanup_list_lock, flags);
> -       list_add(&net->cleanup_list, &cleanup_list);
> -       spin_unlock_irqrestore(&cleanup_list_lock, flags);
> -
> +       llist_add(&net->cleanup_list, &cleanup_list);
>         queue_work(netns_wq, &net_cleanup_work);
>  }

Is llist safe against IRQ too?

  reply	other threads:[~2018-02-20 19:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19  9:58 [PATCH 0/3] net: Get rid of net_mutex and simplify cleanup_list queueing Kirill Tkhai
2018-02-19  9:58 ` [PATCH 1/3] net: Kill net_mutex Kirill Tkhai
2018-02-20 23:18   ` Stephen Hemminger
2018-02-21 10:16     ` Kirill Tkhai
2018-02-19  9:58 ` [PATCH 2/3] net: Make cleanup_list and net::cleanup_list of llist type Kirill Tkhai
2018-02-20 19:42   ` Cong Wang [this message]
2018-02-21  8:30     ` Kirill Tkhai
2018-02-19  9:58 ` [PATCH 3/3] net: Queue net_cleanup_work only if there is first net added Kirill Tkhai
2018-02-19 13:52 ` [PATCH 0/3] net: Get rid of net_mutex and simplify cleanup_list queueing Kirill Tkhai
2018-02-20 18:24 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpWR0HZq2WN+DU_qoGqwJnzdyaEJ5nznYVMpa3MZLV-Mrw@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=avagin@virtuozzo.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=ktkhai@virtuozzo.com \
    --cc=leonro@mellanox.com \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=roman.kapl@sysgo.com \
    --cc=vyasevic@redhat.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.