From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding
Date: Wed, 28 Nov 2018 19:40:29 -0800
Message-ID: <CAM_iQpWbCCSMcqeKVO=VWbvGncnm=A5WjQKi1s6UZZkjY3x81g@mail.gmail.com>
References: <20181128061013.3885-1-xiyou.wangcong@gmail.com>
 <CANn89iL4KM+VpE2ziHvppXZWhGUz-uuaMYTQPMkfxQooc4OpDw@mail.gmail.com>
 <CAM_iQpX2uidJu5ijU7NAVTHm=kNQ+ppvnABZzpbqV53ZqC0mfQ@mail.gmail.com>
 <CANn89iKDNfUP4VzNMxNwKwO8+gyxZwKBr9nSFAeecripnGPYNw@mail.gmail.com>
 <CAM_iQpWXXM3F28b8XLURCJJQaTVK++P9U+u=dehCbqqKEE8VHA@mail.gmail.com> <CANn89iJC6CimzRCTP0gfJMVvh_JVoQ9duXsEMo0MOzoEnU9=1A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Saeed Mahameed <saeedm@mellanox.com>
To: Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f169.google.com ([209.85.215.169]:45436 "EHLO
        mail-pg1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727022AbeK2Oog (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 29 Nov 2018 09:44:36 -0500
Received: by mail-pg1-f169.google.com with SMTP id y4so264338pgc.12
        for <netdev@vger.kernel.org>; Wed, 28 Nov 2018 19:40:42 -0800 (PST)
In-Reply-To: <CANn89iJC6CimzRCTP0gfJMVvh_JVoQ9duXsEMo0MOzoEnU9=1A@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Nov 28, 2018 at 4:07 PM Eric Dumazet <edumazet@google.com> wrote:
>
> A NIC is supposed to deliver frames, even the ones that 'seem' bad.

A quick test shows this is not the case for mlx5.

With the trafgen script you gave to me, with tot_len==40, the dest host
could receive all the packets. Changing tot_len to 80, tcpdump could no
longer see any packet. (Both sender and receiver are mlx5.)

So, packets with tot_len > skb->len are clearly dropped before tcpdump
could see it, that is likely by mlx5 hardware.