All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Linux Kernel Network Developers <netdev@vger.kernel.org>
Cc: syzbot+21f04f481f449c8db840@syzkaller.appspotmail.com,
	Florian Westphal <fw@strlen.de>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Jiri Pirko <jiri@mellanox.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Shaochun Chen <cscnull@gmail.com>
Subject: Re: [Patch net] genetlink: fix memory leaks in genl_family_rcv_msg_dumpit()
Date: Tue, 2 Jun 2020 21:29:45 -0700	[thread overview]
Message-ID: <CAM_iQpWfU0W1tn2zEPnCtWqDXD6gCmH0_5K_8kksmifjzN8cCQ@mail.gmail.com> (raw)
In-Reply-To: <20200603032942.20995-1-xiyou.wangcong@gmail.com>

On Tue, Jun 2, 2020 at 8:30 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>         if (ops->start) {
> -               genl_lock();
> +               if (!ctx->family->parallel_ops)
> +                       genl_lock();
>                 rc = ops->start(cb);
> -               genl_unlock();
> +               if (!ctx->family->parallel_ops)
> +                       genl_unlock();
>         }

Hmm, wg_get_device_start() uses cb->data, so I have to install it before this.

Will send v2.

Thanks.

      reply	other threads:[~2020-06-03  4:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03  3:29 [Patch net] genetlink: fix memory leaks in genl_family_rcv_msg_dumpit() Cong Wang
2020-06-03  4:29 ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpWfU0W1tn2zEPnCtWqDXD6gCmH0_5K_8kksmifjzN8cCQ@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=cscnull@gmail.com \
    --cc=fw@strlen.de \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=syzbot+21f04f481f449c8db840@syzkaller.appspotmail.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.