From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5950C43381 for ; Fri, 29 Mar 2019 01:17:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6685D206B6 for ; Fri, 29 Mar 2019 01:17:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UY+ts9PO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728006AbfC2BMU (ORCPT ); Thu, 28 Mar 2019 21:12:20 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:36280 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727434AbfC2BMT (ORCPT ); Thu, 28 Mar 2019 21:12:19 -0400 Received: by mail-pl1-f193.google.com with SMTP id k2so195429plt.3 for ; Thu, 28 Mar 2019 18:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8Xg5mtm8IIjAKXJG2/wQkYpvBBqII9CFfXu7Abc/roo=; b=UY+ts9POWh1X1EFVhdMAI3FLM6Gc7awdvkMiUjaLc5oO4iqXXygioApiaePWNWO2xB AXtFgGIU82PmG1K2QMQvlGNci2nZnAf/emU9h08/9twcNiD6XST1rT5HTHRoICB1hgTs 43XrZrAI5eh2UpqaSPyhKqY0LRBa7dXJENO+aQ9isirhRbA/yDHonVse+395LWVoH5Kk Mh2k3FrQDKm/DInsOdx5Y50TZ8IZUfb5gMAqOWUx48rD3oOTUZxJ5wM8wKV6swgk5d6V cIc+3xivtSHfHc64hluSCRSWtr7ZkBRKI8epEqsF55qs4ZQT8j/XJ5A9ZUtxydjRdpnp 2oHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8Xg5mtm8IIjAKXJG2/wQkYpvBBqII9CFfXu7Abc/roo=; b=hkckcR5N5rCibz276C0+9ktsujFXCjMh9g2/BkUiTXSbjivtdK+vZ7HqR0dNdo0eBq MPouSXTW/5iO0onrW1jp6o3fZuVMSRZgBNHsOxVZ0nfBm++ibN2160h+EmUAmF2pMxHY vuo7ZXOSd4LsgtGdyVPqyHWuz4Uqxb1iVgQWhr2hHCIqt/Dysofc87g+AoBr6MnGPEoU GHcYabMUW/I1RF3/qS+IURmUFqcTuyS6VOZl762ZJT6a1BPOzEy5WiLechbTX4dCEFMv /T44xHglKSvDpNntWQmMGMKbnoTGfCLlrvkcXw1dEr3ghYA6JjS/LcFKNV05SAEErj1t B+QQ== X-Gm-Message-State: APjAAAVQxueTxRE9K/0rYivzVmqXuoLN+T/cTSWE6QGm1Dn4QlMey5BL 7tmBnQ05g2HhAGvqQ3CUU8Tz/m37FcTCpPjebsVmDRiC X-Google-Smtp-Source: APXvYqw01e8/ENaPxYiwfL/mzpwRvBHKkIG7+wFqp1551DpQS44zm59O5LCeN9y6MxgnCP9YFbbMvUpjGQ4fmw8PHcI= X-Received: by 2002:a17:902:f094:: with SMTP id go20mr23212769plb.159.1553821939007; Thu, 28 Mar 2019 18:12:19 -0700 (PDT) MIME-Version: 1.0 References: <20190329001906.18594-1-leandro.maciel.dorileo@intel.com> <20190329001906.18594-2-leandro.maciel.dorileo@intel.com> In-Reply-To: <20190329001906.18594-2-leandro.maciel.dorileo@intel.com> From: Cong Wang Date: Thu, 28 Mar 2019 18:12:06 -0700 Message-ID: Subject: Re: [PATCH net V5 1/2] net/sched: taprio: fix picos_per_byte miscalculation To: Leandro Dorileo Cc: Linux Kernel Network Developers , Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Vinicius Costa Gomes , Florian Fainelli , vedang.patel@intel.com, andre.guedes@intel.com Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 28, 2019 at 5:20 PM Leandro Dorileo wrote: > +static int taprio_dev_notifier(struct notifier_block *nb, unsigned long event, > + void *ptr) > +{ > + struct net_device *dev = netdev_notifier_info_to_dev(ptr); > + struct taprio_sched *q; > + struct net_device *qdev; > + > + ASSERT_RTNL(); > + > + if (event != NETDEV_UP && event != NETDEV_CHANGE) > + return NOTIFY_DONE; > + > + spin_lock(&taprio_list_lock); > + list_for_each_entry(q, &taprio_list, taprio_list) { > + qdev = qdisc_dev(q->root); > + if (qdev == dev) { > + taprio_set_picos_per_byte(dev, q); > + break; Is it safe to call __ethtool_get_link_ksettings() with spinlock held? I mean is it blocking? Please audit all the dev->ethtool_ops->get_link_ksettings(), I just look at a few of them, it seems good. Thanks.