All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Vlad Buslov <vladbu@nvidia.com>
Cc: syzbot <syzbot+151e3e714d34ae4ce7e8@syzkaller.appspotmail.com>,
	David Miller <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Pirko <jiri@resnulli.us>, Jakub Kicinski <kuba@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: sched: fix police ext initialization
Date: Tue, 16 Feb 2021 11:05:03 -0800	[thread overview]
Message-ID: <CAM_iQpWqFgi8BqSN3QnJUNVO5Y+B+LpcnKymPgqPo4LUM=F8VQ@mail.gmail.com> (raw)
In-Reply-To: <20210216162200.1834139-1-vladbu@nvidia.com>

On Tue, Feb 16, 2021 at 8:22 AM Vlad Buslov <vladbu@nvidia.com> wrote:
>
> When police action is created by cls API tcf_exts_validate() first
> conditional that calls tcf_action_init_1() directly, the action idr is not
> updated according to latest changes in action API that require caller to
> commit newly created action to idr with tcf_idr_insert_many(). This results
> such action not being accessible through act API and causes crash reported
> by syzbot:

Good catch!

This certainly makes sense to me, and I feed it to syzbot too, it is happy
with this patch, so:

Reported-and-tested-by: syzbot+151e3e714d34ae4ce7e8@syzkaller.appspotmail.com
Reviewed-by: Cong Wang <xiyou.wangcong@gmail.com>

Thanks.

      reply	other threads:[~2021-02-16 19:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  7:37 KASAN: null-ptr-deref Read in tcf_idrinfo_destroy syzbot
2021-02-11  5:53 ` syzbot
2021-02-15 23:22   ` Cong Wang
2021-02-16 16:12     ` Vlad Buslov
2021-02-16 16:22     ` [PATCH net] net: sched: fix police ext initialization Vlad Buslov
2021-02-16 19:05       ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpWqFgi8BqSN3QnJUNVO5Y+B+LpcnKymPgqPo4LUM=F8VQ@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+151e3e714d34ae4ce7e8@syzkaller.appspotmail.com \
    --cc=vladbu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.