From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2178BC48BD1 for ; Fri, 11 Jun 2021 02:12:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED8BD61374 for ; Fri, 11 Jun 2021 02:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbhFKCOS (ORCPT ); Thu, 10 Jun 2021 22:14:18 -0400 Received: from mail-pj1-f48.google.com ([209.85.216.48]:45902 "EHLO mail-pj1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230168AbhFKCOR (ORCPT ); Thu, 10 Jun 2021 22:14:17 -0400 Received: by mail-pj1-f48.google.com with SMTP id z3-20020a17090a3983b029016bc232e40bso5056118pjb.4; Thu, 10 Jun 2021 19:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m1nvfkedOhC2O/Z+HXKqfInqZLv5+44mNv+t9W0XDcU=; b=FYQJZt9x7DDitcHxk0wAE0nKmhjgrSe6CN3w/YhNedKFLVgN49HxVqMpaQWpJJpFde RJnc5VLAaTeC+PEdHx8BwOUVHxR2vuPv8ADctPpwytXrHNLRUxDZv6VJp6pnsjF++LBg G9JUaIZgOecP2zZ23P31+XnvQiK05bKOHjKP507+uKYSNvFJhFdGHvCU7s/bJB47mNXN Ax5TGB3qOmeDS80LfYdoUh2AxlsH10/e7214pl6hHjmkYBvXkX2Rq2d3rm7X8HKZGxE3 VT2+pz4DTjGVoKlhVfmkcCgz40/EPM9sQDHZ8cPPLR/vL6uz9snZ1unEkXciNbqMKfpF KZyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m1nvfkedOhC2O/Z+HXKqfInqZLv5+44mNv+t9W0XDcU=; b=ub7Tu+07AL3WvRYuXb5dPz45RwZHifUl1i/yEEOUa6bRDmEw5PwjxHzt/D3TyYE8eR S64nmH5/2v08OFZoHAzx5ZpO5Wg4gVd8HGMCo2zUs2mfSScv0JcA6/YYCNIQz7BBGkb4 VFxZqoNh5nd4I9ZOOQ4g0SAl/6gEPoyj4RXHR4sBIzfrOoizlIQJ8b0vDDL93NnfEnQD YzSBgWb4M+tMJbki3ac1j5HAvmy9fng4BFkWMaXfnZIHbbw7qW8QaYJ2eWPdT4dqsdWz TmV16YSVCy8EpHzE2JwIGctbz05LuRIE/AnY6TUeozCe3Yayj31sUj2liqfPt0Bso+TV OJWg== X-Gm-Message-State: AOAM532JjmL3t58jxHSveWE8rxZNDwDwVFgcoPHRkzHy5SBs3FqPfKGu NbJqoFJUgb7cRxXamNGp8cqL/NED+7aamQeBlZ1AlypQrDaFKQ== X-Google-Smtp-Source: ABdhPJyjUfN9ndUVuBE7eld55wahdYSdMDQhYFCWq+qhpWeAGsrEX35EPSgZI++lz1sK4jevcCvnnu1P3JlljdcgKxo= X-Received: by 2002:a17:90b:190a:: with SMTP id mp10mr6610963pjb.145.1623377467527; Thu, 10 Jun 2021 19:11:07 -0700 (PDT) MIME-Version: 1.0 References: <20210528195946.2375109-1-memxor@gmail.com> <20210607033724.wn6qn4v42dlm4j4o@apollo> <20210607060724.4nidap5eywb23l3d@apollo> <20210608071908.sos275adj3gunewo@apollo> In-Reply-To: From: Cong Wang Date: Thu, 10 Jun 2021 19:10:56 -0700 Message-ID: Subject: Re: [PATCH RFC bpf-next 0/7] Add bpf_link based TC-BPF API To: Alexei Starovoitov Cc: Kumar Kartikeya Dwivedi , bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Jamal Hadi Salim , Vlad Buslov , Jiri Pirko , "David S. Miller" , Jakub Kicinski , Joe Stringer , Quentin Monnet , Jesper Dangaard Brouer , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Linux Kernel Network Developers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Jun 8, 2021 at 8:39 AM Alexei Starovoitov wrote: > I think it makes sense to create these objects as part of establishing bpf_link. > ingress qdisc is a fake qdisc anyway. > If we could go back in time I would argue that its existence doesn't > need to be shown in iproute2. It's an object that serves no purpose > other than attaching filters to it. It doesn't do any queuing unlike > real qdiscs. > It's an artifact of old choices. Old doesn't mean good. > The kernel is full of such quirks and oddities. New api-s shouldn't > blindly follow them. > tc qdisc add dev eth0 clsact > is a useless command with nop effect. Sounds like you just need a new bpf attach point outside of TC, probably inside __dev_queue_xmit(). You don't need to create any object, probably just need to attach it to a netdev. Thanks.