From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter Date: Tue, 15 Jan 2019 09:57:49 -0800 Message-ID: References: <20190112025542.397-1-xiyou.wangcong@gmail.com> <2c84f3cc-b1ad-5316-4813-e7e433bf9f5e@mojatatu.com> <53f2ac1d-ea4c-b779-c4a7-6268758f87bf@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Linux Kernel Network Developers , Martin Olsson , Jiri Pirko , Lucas Bates To: Jamal Hadi Salim Return-path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:45560 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbfAOR6C (ORCPT ); Tue, 15 Jan 2019 12:58:02 -0500 Received: by mail-pl1-f195.google.com with SMTP id a14so1615454plm.12 for ; Tue, 15 Jan 2019 09:58:01 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 15, 2019 at 8:21 AM Jamal Hadi Salim wrote: > > On 2019-01-15 10:59 a.m., Jamal Hadi Salim wrote: > > On 2019-01-13 4:08 p.m., Cong Wang wrote: > >> On Sat, Jan 12, 2019 at 7:41 AM Jamal Hadi Salim > > [..] > > I agree with your rationale. > > Lets have Lucas give this a run and we can move > > forward. > > And as an addendum - Martin corrected me, he did have a "continue" > after the vlan pop (not illegal to do). So i think your patch > is fine; lets not mix it up with vlan not correctly matching > (two separate issues). > > Lets have Lucas create the tdc test, then add my Ack. As I said, this case is a bit hard to add to tdc test, because: 1. It requires a vlan device on top. This is not hard to do, but still needs some extra work. 2. It requires a run-time test, like ping. This is different from other test cases which test setup-time config's. This is a bit hard because we have to parse tc filter stats to learn if some filter is hit or not. I am sure Lucas can do it, just it is not as easy as other cases. Thanks.