From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy
Date: Fri, 26 Oct 2018 11:19:02 -0700
Message-ID: <CAM_iQpWzthb3JoHyMv0AtJZQNVr9CQgkoJ8jOpsZpMSX1R7WKg@mail.gmail.com>
References: <20181024153249.15374-1-dsahern@kernel.org> <1305358874.1795395.1540553653206@mail.libero.it>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dsahern@kernel.org, David Miller <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>
To: Marco Berizzi <pupilla@libero.it>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f195.google.com ([209.85.210.195]:40343 "EHLO
        mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727844AbeJ0C5R (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 26 Oct 2018 22:57:17 -0400
Received: by mail-pf1-f195.google.com with SMTP id g21-v6so936758pfi.7
        for <netdev@vger.kernel.org>; Fri, 26 Oct 2018 11:19:15 -0700 (PDT)
In-Reply-To: <1305358874.1795395.1540553653206@mail.libero.it>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Oct 26, 2018 at 4:35 AM Marco Berizzi <pupilla@libero.it> wrote:
> Apologies for bothering you again.
> I applied your patch to 4.19, but after issuing this
> command:
>
> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> root@Calimero:~# ping 10.81.104.1
> PING 10.81.104.1 (10.81.104.1) 56(84) bytes of data.
> ^C
> --- 10.81.104.1 ping statistics ---
> 2 packets transmitted, 0 received, 100% packet loss, time 1001ms
>
> I'm losing ipv4 connectivity.
> If I remove the qdisc everything is going to work again:

Did this really work before?

You specify a default class without adding it, so the packets are dropped.

How would you expect this to work? :)