All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Vlad Buslov <vladbu@mellanox.com>
Cc: "open list:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
	David Miller <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Davide Caratti <dcaratti@redhat.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH net-next] selftests: fix flower parent qdisc
Date: Wed, 13 May 2020 11:35:08 -0700	[thread overview]
Message-ID: <CAM_iQpX2nBc3ppmvxJPoECCfZY1v1bhiYC_7fjAbXKCqdA3nLg@mail.gmail.com> (raw)
In-Reply-To: <20200513175746.7294-1-vladbu@mellanox.com>

On Wed, May 13, 2020 at 10:58 AM Vlad Buslov <vladbu@mellanox.com> wrote:
>
> Flower tests used to create ingress filter with specified parent qdisc
> "parent ffff:" but dump them on "ingress". With recent commit that fixed
> tcm_parent handling in dump those are not considered same parent anymore,
> which causes iproute2 tc to emit additional "parent ffff:" in first line of
> filter dump output. The change in output causes filter match in tests to
> fail.

My commit simply restores the old behavior prior to 4.15, so are you
saying these tests never work correctly on kernels <= 4.15? If so,
they must be fixed no matter of my commit, right?

Thanks.

  reply	other threads:[~2020-05-13 18:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 17:57 [PATCH net-next] selftests: fix flower parent qdisc Vlad Buslov
2020-05-13 18:35 ` Cong Wang [this message]
2020-05-14  6:30   ` Vlad Buslov
2020-05-13 19:57 ` David Miller
2020-05-14  6:30   ` Vlad Buslov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpX2nBc3ppmvxJPoECCfZY1v1bhiYC_7fjAbXKCqdA3nLg@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=shuah@kernel.org \
    --cc=vladbu@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.