All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Tyler Stachecki <stachecki.tyler@gmail.com>
Cc: fankaixi.li@bytedance.com, xiexiaohui.xxh@bytedance.com,
	"Cong Wang ." <cong.wang@bytedance.com>,
	Pravin B Shelar <pshelar@ovn.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	dev@openvswitch.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ovs: Only clear tstamp when changing namespaces
Date: Mon, 20 Sep 2021 09:40:51 -0700	[thread overview]
Message-ID: <CAM_iQpX4hQc3AHgVvfydZ9us0Rt21p5za849z1kgt-sLXSnWTQ@mail.gmail.com> (raw)
In-Reply-To: <CAC6wqPVopqP=erynBazgRh2QkB7=Nh-cXxLS2ZvmTzb7E0Gvaw@mail.gmail.com>

On Sun, Sep 19, 2021 at 10:44 PM Tyler Stachecki
<stachecki.tyler@gmail.com> wrote:
> Sorry if this is a no-op -- I'm admittedly not familiar with this part
> of the tree.  I had added this check based on this discussion on the
> OVS mailing list:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2021-February/050966.html
>
> The motivation to add it was based on the fact that skb_scrub_packet
> is doing it conditionally as well, but you seem to indicate that
> skb_scrub_packet itself is already being done somewhere?

I mean, skb->tstamp has been cleared when crossing netns,
so: 1) you don't need to clear it again for this case; 2) clearly we
fix other cases with commit 01634047bf0d, so your patch break
it again.

Thanks.

      reply	other threads:[~2021-09-20 16:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19 15:43 [PATCH] ovs: Only clear tstamp when changing namespaces Tyler J. Stachecki
2021-09-19 23:33 ` Cong Wang
2021-09-20  5:44   ` Tyler Stachecki
2021-09-20 16:40     ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpX4hQc3AHgVvfydZ9us0Rt21p5za849z1kgt-sLXSnWTQ@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=cong.wang@bytedance.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=fankaixi.li@bytedance.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@ovn.org \
    --cc=stachecki.tyler@gmail.com \
    --cc=xiexiaohui.xxh@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.