From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E12C43381 for ; Fri, 22 Feb 2019 17:36:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BF08206B6 for ; Fri, 22 Feb 2019 17:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="icRN4IYE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfBVRgK (ORCPT ); Fri, 22 Feb 2019 12:36:10 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:45561 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725986AbfBVRgJ (ORCPT ); Fri, 22 Feb 2019 12:36:09 -0500 Received: by mail-pf1-f196.google.com with SMTP id v21so1396955pfm.12 for ; Fri, 22 Feb 2019 09:36:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G/p0G6AaoKKgRvNpr3TIRMrX5chuLlHtwoG0IwlgrfI=; b=icRN4IYEiL9kK0cc7zt5lhr+E8/vYMApjASLm7MHlJjhjbuxCyQ5gW0682QD8qp8Qw VqgS4BhtI8FNAa7ZWbPI2PGz1MY0PfI25rDH97yUmzIyfkMns8bTB12qoyd2GnS1s7Ws okq6T6h68/qfMTm/kwOYkdky0dRNveqQ/lo16l32+jMrp2ac7pQkiAXTn/M1Cfy2uYhy CqGx0bydzp6aR+QvX60u8i0sh/n26Asm4jUB+5iTk/B+Xvs7xRoOruIN7YW0YVfqnwb+ Z2HRw6wzwDXB6IHYyqZZwH7qqe9571qv4lnRMq/Rh9mU6ESj85mdndvjyF5UgcQDEbVU 8Zww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G/p0G6AaoKKgRvNpr3TIRMrX5chuLlHtwoG0IwlgrfI=; b=ebF6d3p/0wRDPEHroFJ9KeBuPAgMsqGFatuRVKC0xOgzLAd2flUAtCEUKzUkNK/zdi /gsgLuSW2Oeti7GvnanXE3u3ti3idE4XCQ0TeQYjCS6PzqvAyfCXKphSRAxRR2+1itDF nALAV2qW1JS2VMQRMxHhgkR9HUsGFkBeFZq+wRnf4Q4bkJAd8NPBnFmi3EE3Y4YdTobL jK+AaB6N3XFG2RJhJU96mlpUVbytberlSgzAQoyOa1o269SyuALrFAWVddmhyRkJcVc2 bojlilOjFXxg2FMRNixHxOD4JkcJ+IORw1ha7V+pnqyrLBQ8Y0Im2p4cD+YYxxOyYuW9 +M4Q== X-Gm-Message-State: AHQUAuYr5yPt783BegN1r1MgRuxrNk6j5VOvNVEukWDkG1dkUHwFJ7A+ MYdqLw16JQ2kjYUDjfLcqYChu5Qz+DvIENZA3Ss= X-Google-Smtp-Source: AHgI3IbrGubhSq5mvohJ25Ez8Ww+EqajwNLEpJ5pK9LhI1KzCYUcbBfFXuVaJ1OhtYxRLvz+j9BAxlCxrH1p9/AwxuI= X-Received: by 2002:a62:70c9:: with SMTP id l192mr5346438pfc.207.1550856968792; Fri, 22 Feb 2019 09:36:08 -0800 (PST) MIME-Version: 1.0 References: <20190222140047.13215-1-vladbu@mellanox.com> In-Reply-To: <20190222140047.13215-1-vladbu@mellanox.com> From: Cong Wang Date: Fri, 22 Feb 2019 09:35:57 -0800 Message-ID: Subject: Re: [PATCH net-next 0/8] Add tests for unlocked flower classifier implementation To: Vlad Buslov Cc: Linux Kernel Network Developers , Jamal Hadi Salim , David Miller , shuah@kernel.org, batuhanosmantaskaya@gmail.com, Lucas Bates , Davide Caratti , Marcelo Ricardo Leitner , Chris Mi Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 22, 2019 at 6:00 AM Vlad Buslov wrote: > > Implement tests for tdc testsuite to verify concurrent rules update with > rtnl-unlocked flower classifier implementation. The goal of these tests > is to verify general flower classifier correctness by updating filters > on same classifier instance in parallel and to verify its atomicity by > concurrently updating filters in same handle range. All three filter > update operations (add, replace, delete) are tested. > > Existing script tdc_batch.py is re-used for batch file generation. It is > extended with several optional CLI arguments that are needed for > concurrency tests. Thin wrapper tdc_multibatch.py is implemented on top > of tdc_batch.py to simplify its usage when generating multiple batch > files for several test configurations. > > Parallelism in tests is implemented by running multiple instances of tc > in batch mode with xargs tool. Xargs is chosen for its ease of use and > because it is available by default on most modern Linux distributions. I don't look into the details, but I love to see we have tests for parallel filter updates! So for the whole patchset: Acked-by: Cong Wang Thanks!