From: Cong Wang <xiyou.wangcong@gmail.com>
To: Ivan Vecera <ivecera@redhat.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Saeed Mahameed <saeed@kernel.org>
Subject: Re: [PATCH net] team: protect features update by RCU to avoid deadlock
Date: Mon, 25 Jan 2021 12:53:22 -0800 [thread overview]
Message-ID: <CAM_iQpX85wZn0ihG_XxPq=inM5P8dKvf4BE6kNwG2na=NAnGzw@mail.gmail.com> (raw)
In-Reply-To: <20210125074416.4056484-1-ivecera@redhat.com>
On Sun, Jan 24, 2021 at 11:44 PM Ivan Vecera <ivecera@redhat.com> wrote:
>
> Function __team_compute_features() is protected by team->lock
> mutex when it is called from team_compute_features() used when
> features of an underlying device is changed. This causes
> a deadlock when NETDEV_FEAT_CHANGE notifier for underlying device
> is fired due to change propagated from team driver (e.g. MTU
> change). It's because callbacks like team_change_mtu() or
> team_vlan_rx_{add,del}_vid() protect their port list traversal
> by team->lock mutex.
>
> Example (r8169 case where this driver disables TSO for certain MTU
> values):
> ...
> [ 6391.348202] __mutex_lock.isra.6+0x2d0/0x4a0
> [ 6391.358602] team_device_event+0x9d/0x160 [team]
> [ 6391.363756] notifier_call_chain+0x47/0x70
> [ 6391.368329] netdev_update_features+0x56/0x60
> [ 6391.373207] rtl8169_change_mtu+0x14/0x50 [r8169]
> [ 6391.378457] dev_set_mtu_ext+0xe1/0x1d0
> [ 6391.387022] dev_set_mtu+0x52/0x90
> [ 6391.390820] team_change_mtu+0x64/0xf0 [team]
> [ 6391.395683] dev_set_mtu_ext+0xe1/0x1d0
> [ 6391.399963] do_setlink+0x231/0xf50
> ...
>
> In fact team_compute_features() called from team_device_event()
> does not need to be protected by team->lock mutex and rcu_read_lock()
> is sufficient there for port list traversal.
Reviewed-by: Cong Wang <xiyou.wangcong@gmail.com>
In the future, please version your patch so that we can easily
find out which is the latest.
Thanks.
next prev parent reply other threads:[~2021-01-25 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 7:44 [PATCH net] team: protect features update by RCU to avoid deadlock Ivan Vecera
2021-01-25 20:53 ` Cong Wang [this message]
2021-01-26 6:36 ` Ivan Vecera
2021-01-26 10:02 ` Jiri Pirko
2021-01-27 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpX85wZn0ihG_XxPq=inM5P8dKvf4BE6kNwG2na=NAnGzw@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.